Re: [PR PATCH] [Updated] apparmor: update pulseaudio profile

Re: [PR PATCH] [Updated] apparmor: update pulseaudio profile

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages aa-pulse
https://github.com/void-linux/void-packages/pull/24734

apparmor: update pulseaudio profile
The pulseaudio profile was referring to the gconf helper, which has been
replaced with the gsettings-helper.

A patch file from https://github.com/void-linux/void-packages/pull/24734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aa-pulse-24734.patch --]
[-- Type: text/x-diff, Size: 2812 bytes --]

From 3b50d243e7850808ff78832c869b4edd555dd063 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Mon, 7 Sep 2020 07:56:34 -0700
Subject: [PATCH] apparmor: update pulseaudio profile

The pulseaudio profile was referring to the gconf helper, which has been
replaced with the gsettings-helper.
---
 .../files/profiles/usr.bin.pulseaudio         | 20 ++++++++++++-------
 srcpkgs/apparmor/template                     |  2 +-
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio b/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio
index e23c5bf0043..4b17e6edc08 100644
--- a/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio
+++ b/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio
@@ -1,6 +1,6 @@
 #include <tunables/global>
 
-/usr/bin/pulseaudio {
+profile pulseaudio /usr/bin/pulseaudio {
   #include <abstractions/base>
   #include <abstractions/audio>
   #include <abstractions/dbus-session>
@@ -23,6 +23,7 @@
 
   unix (connect, receive, send) type=stream peer=(addr="@/tmp/.ICE-unix/[0-9]*"),
   ptrace (read,trace) peer=@{profile_name},
+  signal (send) peer=pulseaudio//pulse-gsettings-helper,
 
   /usr/bin/pulseaudio mixr,
 
@@ -70,7 +71,7 @@
   /usr/share/applications/* r,
   /usr/share/pulseaudio/** r,
   /usr/lib/pulse-[1-9]*.[0-9]/modules/*.so mr,
-  /usr/lib/pulseaudio/pulse/gconf-helper Cx,
+  /usr/libexec/pulse/gsettings-helper Cx,
 
   owner /var/lib/gdm3/.config/pulse/ rw,
   owner /var/lib/gdm3/.config/pulse/* rw,
@@ -89,8 +90,7 @@
   /var/lib/pulse/*.tdb rw,
 
   owner @{PROC}/@{pid}/fd/ r,
-  owner @{PROC}/@{pid}/maps r,
-  owner @{PROC}/@{pid}/stat r,
+  owner @{PROC}/@{pid}/{maps,mountinfo,stat} r,
 
   owner /tmp/pulse-*/pid rwk,
   owner /tmp/pulse-*/native rwk,
@@ -105,10 +105,16 @@
   owner /tmp/.esd-@{pid}*/ rw,
   owner /tmp/.esd-@{pid}*/socket rw,
 
-  profile /usr/lib/pulseaudio/pulse/gconf-helper {
+  profile pulse-gsettings-helper /usr/libexec/pulse/gsettings-helper {
     #include <abstractions/base>
-
-    /usr/lib/pulseaudio/pulse/gconf-helper mr,
+    #include <abstractions/gnome>
+    #include <abstractions/dconf>
+
+    /usr/libexec/pulse/gsettings-helper mr,
+    owner /{,var/}run/user/*/dconf/user rw,
+    owner @{HOME}/.config/dconf/user rw,
+    owner @{PROC}/@{pid}/fd/ r,
+    signal (receive) peer=pulseaudio,
   }
 
   # Site-specific additions and overrides. See local/README for details.
diff --git a/srcpkgs/apparmor/template b/srcpkgs/apparmor/template
index cd7073fdcfb..711c7fd788c 100644
--- a/srcpkgs/apparmor/template
+++ b/srcpkgs/apparmor/template
@@ -1,7 +1,7 @@
 # Template file for 'apparmor'
 pkgname=apparmor
 version=2.13.4
-revision=2
+revision=3
 wrksrc="${pkgname}-v${version}"
 build_wrksrc=libraries/libapparmor
 build_style=gnu-configure

Re: apparmor: update pulseaudio profile

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/24734#issuecomment-700404413

Comment:
should be good now

Re: apparmor: update pulseaudio profile

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24734#issuecomment-700421053

Comment:
Oh! Remove `noarch` as well.

Re: [PR PATCH] [Updated] apparmor: update pulseaudio profile

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages aa-pulse
https://github.com/void-linux/void-packages/pull/24734

apparmor: update pulseaudio profile
The pulseaudio profile was referring to the gconf helper, which has been
replaced with the gsettings-helper.

A patch file from https://github.com/void-linux/void-packages/pull/24734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aa-pulse-24734.patch --]
[-- Type: text/x-diff, Size: 2812 bytes --]

From e4124aec6a2fca1d58823a4f95a2044d7cb7ef41 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Mon, 7 Sep 2020 07:56:34 -0700
Subject: [PATCH] apparmor: update pulseaudio profile

The pulseaudio profile was referring to the gconf helper, which has been
replaced with the gsettings-helper.
---
 .../files/profiles/usr.bin.pulseaudio         | 20 ++++++++++++-------
 srcpkgs/apparmor/template                     |  2 +-
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio b/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio
index e23c5bf0043..4b17e6edc08 100644
--- a/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio
+++ b/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio
@@ -1,6 +1,6 @@
 #include <tunables/global>
 
-/usr/bin/pulseaudio {
+profile pulseaudio /usr/bin/pulseaudio {
   #include <abstractions/base>
   #include <abstractions/audio>
   #include <abstractions/dbus-session>
@@ -23,6 +23,7 @@
 
   unix (connect, receive, send) type=stream peer=(addr="@/tmp/.ICE-unix/[0-9]*"),
   ptrace (read,trace) peer=@{profile_name},
+  signal (send) peer=pulseaudio//pulse-gsettings-helper,
 
   /usr/bin/pulseaudio mixr,
 
@@ -70,7 +71,7 @@
   /usr/share/applications/* r,
   /usr/share/pulseaudio/** r,
   /usr/lib/pulse-[1-9]*.[0-9]/modules/*.so mr,
-  /usr/lib/pulseaudio/pulse/gconf-helper Cx,
+  /usr/libexec/pulse/gsettings-helper Cx,
 
   owner /var/lib/gdm3/.config/pulse/ rw,
   owner /var/lib/gdm3/.config/pulse/* rw,
@@ -89,8 +90,7 @@
   /var/lib/pulse/*.tdb rw,
 
   owner @{PROC}/@{pid}/fd/ r,
-  owner @{PROC}/@{pid}/maps r,
-  owner @{PROC}/@{pid}/stat r,
+  owner @{PROC}/@{pid}/{maps,mountinfo,stat} r,
 
   owner /tmp/pulse-*/pid rwk,
   owner /tmp/pulse-*/native rwk,
@@ -105,10 +105,16 @@
   owner /tmp/.esd-@{pid}*/ rw,
   owner /tmp/.esd-@{pid}*/socket rw,
 
-  profile /usr/lib/pulseaudio/pulse/gconf-helper {
+  profile pulse-gsettings-helper /usr/libexec/pulse/gsettings-helper {
     #include <abstractions/base>
-
-    /usr/lib/pulseaudio/pulse/gconf-helper mr,
+    #include <abstractions/gnome>
+    #include <abstractions/dconf>
+
+    /usr/libexec/pulse/gsettings-helper mr,
+    owner /{,var/}run/user/*/dconf/user rw,
+    owner @{HOME}/.config/dconf/user rw,
+    owner @{PROC}/@{pid}/fd/ r,
+    signal (receive) peer=pulseaudio,
   }
 
   # Site-specific additions and overrides. See local/README for details.
diff --git a/srcpkgs/apparmor/template b/srcpkgs/apparmor/template
index aec653c100c..886ef5b587c 100644
--- a/srcpkgs/apparmor/template
+++ b/srcpkgs/apparmor/template
@@ -1,7 +1,7 @@
 # Template file for 'apparmor'
 pkgname=apparmor
 version=2.13.4
-revision=4
+revision=5
 wrksrc="${pkgname}-v${version}"
 build_wrksrc=libraries/libapparmor
 build_style=gnu-configure

Re: apparmor: update pulseaudio profile

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/24734#issuecomment-707445797

Comment:
noarch removed

Re: [PR REVIEW] apparmor: update pulseaudio profile

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24734#discussion_r509843096

Comment:
Is it definitely `//` here?

Re: [PR REVIEW] apparmor: update pulseaudio profile

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/24734#discussion_r510383405

Comment:
yea, that is how subprofiles are named

Re: [PR PATCH] [Updated] apparmor: update pulseaudio profile

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages aa-pulse
https://github.com/void-linux/void-packages/pull/24734

apparmor: update pulseaudio profile
The pulseaudio profile was referring to the gconf helper, which has been
replaced with the gsettings-helper.

A patch file from https://github.com/void-linux/void-packages/pull/24734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aa-pulse-24734.patch --]
[-- Type: text/x-diff, Size: 3336 bytes --]

From 463962b347c4174cbe5e8962f7a6dd28e2f7a0ab Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Mon, 7 Sep 2020 07:56:34 -0700
Subject: [PATCH] apparmor: update pulseaudio profile

The pulseaudio profile was referring to the gconf helper, which has been
replaced with the gsettings-helper.
---
 .../files/profiles/usr.bin.pulseaudio         | 20 ++++++++++++-------
 srcpkgs/apparmor/template                     |  4 ++--
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio b/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio
index e23c5bf0043..4b17e6edc08 100644
--- a/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio
+++ b/srcpkgs/apparmor/files/profiles/usr.bin.pulseaudio
@@ -1,6 +1,6 @@
 #include <tunables/global>
 
-/usr/bin/pulseaudio {
+profile pulseaudio /usr/bin/pulseaudio {
   #include <abstractions/base>
   #include <abstractions/audio>
   #include <abstractions/dbus-session>
@@ -23,6 +23,7 @@
 
   unix (connect, receive, send) type=stream peer=(addr="@/tmp/.ICE-unix/[0-9]*"),
   ptrace (read,trace) peer=@{profile_name},
+  signal (send) peer=pulseaudio//pulse-gsettings-helper,
 
   /usr/bin/pulseaudio mixr,
 
@@ -70,7 +71,7 @@
   /usr/share/applications/* r,
   /usr/share/pulseaudio/** r,
   /usr/lib/pulse-[1-9]*.[0-9]/modules/*.so mr,
-  /usr/lib/pulseaudio/pulse/gconf-helper Cx,
+  /usr/libexec/pulse/gsettings-helper Cx,
 
   owner /var/lib/gdm3/.config/pulse/ rw,
   owner /var/lib/gdm3/.config/pulse/* rw,
@@ -89,8 +90,7 @@
   /var/lib/pulse/*.tdb rw,
 
   owner @{PROC}/@{pid}/fd/ r,
-  owner @{PROC}/@{pid}/maps r,
-  owner @{PROC}/@{pid}/stat r,
+  owner @{PROC}/@{pid}/{maps,mountinfo,stat} r,
 
   owner /tmp/pulse-*/pid rwk,
   owner /tmp/pulse-*/native rwk,
@@ -105,10 +105,16 @@
   owner /tmp/.esd-@{pid}*/ rw,
   owner /tmp/.esd-@{pid}*/socket rw,
 
-  profile /usr/lib/pulseaudio/pulse/gconf-helper {
+  profile pulse-gsettings-helper /usr/libexec/pulse/gsettings-helper {
     #include <abstractions/base>
-
-    /usr/lib/pulseaudio/pulse/gconf-helper mr,
+    #include <abstractions/gnome>
+    #include <abstractions/dconf>
+
+    /usr/libexec/pulse/gsettings-helper mr,
+    owner /{,var/}run/user/*/dconf/user rw,
+    owner @{HOME}/.config/dconf/user rw,
+    owner @{PROC}/@{pid}/fd/ r,
+    signal (receive) peer=pulseaudio,
   }
 
   # Site-specific additions and overrides. See local/README for details.
diff --git a/srcpkgs/apparmor/template b/srcpkgs/apparmor/template
index aec653c100c..1ce7af5d4ee 100644
--- a/srcpkgs/apparmor/template
+++ b/srcpkgs/apparmor/template
@@ -1,7 +1,7 @@
 # Template file for 'apparmor'
 pkgname=apparmor
 version=2.13.4
-revision=4
+revision=5
 wrksrc="${pkgname}-v${version}"
 build_wrksrc=libraries/libapparmor
 build_style=gnu-configure
@@ -26,7 +26,7 @@ fi
 post_patch() {
 	# Make.rules feeds some system headers to the C preprocessor to produce
 	# lists of capability and address-family names that, respectively,
-	# populate `parser/cap_names.h` and `parser/af_names.h`. The escaping
+	# populate 'parser/cap_names.h' and 'parser/af_names.h'. The escaping
 	# backslash in the '\#include" directives here is seen by the
 	# preprocessor, causing it to skip the system headers and produce empty
 	# files. Removing the backslash ensures correct behavior.

Re: [PR PATCH] [Merged]: apparmor: update pulseaudio profile

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

There's a merged pull request on the void-packages repository

apparmor: update pulseaudio profile
https://github.com/void-linux/void-packages/pull/24734

Description:
The pulseaudio profile was referring to the gconf helper, which has been
replaced with the gsettings-helper.