* [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao
@ 2020-10-29 21:52 lumigch
2020-10-29 22:09 ` New packages: " ericonr
` (17 more replies)
0 siblings, 18 replies; 19+ messages in thread
From: lumigch @ 2020-10-29 21:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
There is a new pull request by lumigch against master on the void-packages repository
https://github.com/lumigch/void-packages hunspell-pt_PT
https://github.com/void-linux/void-packages/pull/25973
New packagew: hunspell-pt_PT and hunspell-pt_PT-preao
Two new packages containing the dictionaries for pt_PT. These are the pre- (hunspell-pt_PT) and post- (hunspell-pt_PT-preao) 1990 Orthographic Agreement.
Since these two packages I related, I decided to create a single pull-request. This is my 1st pull-request for the project, so maybe you prefer two separate requests. Please let me know any problems with these packages.
A patch file from https://github.com/void-linux/void-packages/pull/25973.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hunspell-pt_PT-25973.patch --]
[-- Type: text/x-diff, Size: 2635 bytes --]
From ed7145917156a12b841af1b72aea052c254fbbcc Mon Sep 17 00:00:00 2001
From: Luis Henriques <lhenriques@suse.de>
Date: Thu, 29 Oct 2020 21:34:13 +0000
Subject: [PATCH 1/2] New package: hunspell-pt_PT-20201029
---
srcpkgs/hunspell-pt_PT/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/hunspell-pt_PT/template
diff --git a/srcpkgs/hunspell-pt_PT/template b/srcpkgs/hunspell-pt_PT/template
new file mode 100644
index 00000000000..598de4519bc
--- /dev/null
+++ b/srcpkgs/hunspell-pt_PT/template
@@ -0,0 +1,18 @@
+# Template file for 'hunspell-pt_PT'
+pkgname=hunspell-pt_PT
+version=20201029
+revision=1
+wrksrc=${pkgname}-${version}
+depends="hunspell"
+short_desc="Portuguese dictionary for hunspell"
+maintainer="Luis Henriques <henrix@camandro.org>"
+license="GPL-2.0-only, LGPL-2.1-only, MPL-1.1"
+homepage="https://natura.di.uminho.pt/wiki/doku.php?id=dicionarios:main"
+distfiles="https://natura.di.uminho.pt/download/sources/Dictionaries/hunspell/${pkgname}-${version}.tar.gz"
+checksum=711b2a2c755546cb341e5cf8ed70157fc4adaacc74b84e132c85b174d791c8db
+
+do_install() {
+ vinstall ${wrksrc}/pt_PT.aff 644 usr/share/hunspell
+ vinstall ${wrksrc}/pt_PT.dic 644 usr/share/hunspell
+ vdoc ${wrksrc}/README_pt_PT.txt
+}
From 2d9d7977a5bd841ceb7f05130eedc8f6905699cd Mon Sep 17 00:00:00 2001
From: Luis Henriques <lhenriques@suse.de>
Date: Thu, 29 Oct 2020 21:34:38 +0000
Subject: [PATCH 2/2] New package: hunspell-pt_PT-preao-20201029
---
srcpkgs/hunspell-pt_PT-preao/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/hunspell-pt_PT-preao/template
diff --git a/srcpkgs/hunspell-pt_PT-preao/template b/srcpkgs/hunspell-pt_PT-preao/template
new file mode 100644
index 00000000000..c568e86bc35
--- /dev/null
+++ b/srcpkgs/hunspell-pt_PT-preao/template
@@ -0,0 +1,18 @@
+# Template file for 'hunspell-pt_PT-preao'
+pkgname=hunspell-pt_PT-preao
+version=20201029
+revision=1
+wrksrc=${pkgname}-${version}
+depends="hunspell"
+short_desc="Portuguese dictionary for hunspell (prior 1990 Orthographic Agreement)"
+maintainer="Luis Henriques <henrix@camandro.org>"
+license="GPL-2.0-only, LGPL-2.1-only, MPL-1.1"
+homepage="https://natura.di.uminho.pt/wiki/doku.php?id=dicionarios:main"
+distfiles="https://natura.di.uminho.pt/download/sources/Dictionaries/hunspell/${pkgname}-${version}.tar.gz"
+checksum=9427f1b21b9a3e8126fce62d008e6215b0b631498232ae567859d363351fbac4
+
+do_install() {
+ vinstall ${wrksrc}/pt_PT-preao.aff 644 usr/share/hunspell
+ vinstall ${wrksrc}/pt_PT-preao.dic 644 usr/share/hunspell
+ vdoc ${wrksrc}/README_pt_PT.txt
+}
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
@ 2020-10-29 22:09 ` ericonr
2020-10-29 23:54 ` sgn
` (16 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2020-10-29 22:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-719052451
Comment:
I believe it's ok in this case.
> These are the pre- (hunspell-pt_PT) and post- (hunspell-pt_PT-preao) 1990 Orthographic Agreement.
You switched them, right? Should be " post- (hunspell-pt_PT) and pre- (hunspell-pt_PT-preao) 1990 Orthographic Agreement.", I think, going by the package names.
Is the pre-acordo ortográfico one necessary? I know in Brazil we have basically switched over to post acordo by now.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
2020-10-29 22:09 ` New packages: " ericonr
@ 2020-10-29 23:54 ` sgn
2020-10-30 0:16 ` [PR REVIEW] " ericonr
` (15 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: sgn @ 2020-10-29 23:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-719088790
Comment:
> Is the pre-acordo ortográfico one necessary? I know in Brazil we have basically switched over to post acordo by now.
I don't speak Portuguese but I could imagine it's useful for literature and linguistic researcher.
I don't have any strong opinion on including them. If someone find it's helpful, it's helpful.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
2020-10-29 22:09 ` New packages: " ericonr
2020-10-29 23:54 ` sgn
@ 2020-10-30 0:16 ` ericonr
2020-10-30 0:18 ` ericonr
` (14 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2020-10-30 0:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 155 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#discussion_r514638518
Comment:
prior to
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (2 preceding siblings ...)
2020-10-30 0:16 ` [PR REVIEW] " ericonr
@ 2020-10-30 0:18 ` ericonr
2020-10-30 0:19 ` ericonr
` (13 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2020-10-30 0:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#discussion_r514638812
Comment:
I don't think you should be using `${wrksrc}` here, templates are run inside the wrksrc by default.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (3 preceding siblings ...)
2020-10-30 0:18 ` ericonr
@ 2020-10-30 0:19 ` ericonr
2020-10-30 0:19 ` ericonr
` (12 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2020-10-30 0:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#discussion_r514639163
Comment:
The other hunspell templates don't do this.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR REVIEW] New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (4 preceding siblings ...)
2020-10-30 0:19 ` ericonr
@ 2020-10-30 0:19 ` ericonr
2020-10-30 9:28 ` lumigch
` (11 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2020-10-30 0:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#discussion_r514638863
Comment:
This is default.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (5 preceding siblings ...)
2020-10-30 0:19 ` ericonr
@ 2020-10-30 9:28 ` lumigch
2020-10-30 9:29 ` lumigch
` (10 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: lumigch @ 2020-10-30 9:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
New comment by lumigch on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-719444314
Comment:
> I believe it's ok in this case.
>
> > These are the pre- (hunspell-pt_PT) and post- (hunspell-pt_PT-preao) 1990 Orthographic Agreement.
>
> You switched them, right? Should be " post- (hunspell-pt_PT) and pre- (hunspell-pt_PT-preao) 1990 Orthographic Agreement.", I think, going by the package names.
Ah! Right, I did messed that up indeed.
> Is the pre-acordo ortográfico one necessary? I know in Brazil we have basically switched over to post acordo by now.
Well, in Portugal the pre-acordo is still wildly used -- there are newspapers, authors, etc that keep using it. So, it is still relevant I believe.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (6 preceding siblings ...)
2020-10-30 9:28 ` lumigch
@ 2020-10-30 9:29 ` lumigch
2020-10-30 21:35 ` [PR PATCH] [Updated] " lumigch
` (9 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: lumigch @ 2020-10-30 9:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
New comment by lumigch on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-719444982
Comment:
> Please apply the comments to both templates.
Thanks a lot for the review. I'll work through the comments later today and update my branch accordingly.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Updated] New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (7 preceding siblings ...)
2020-10-30 9:29 ` lumigch
@ 2020-10-30 21:35 ` lumigch
2020-10-30 21:38 ` lumigch
` (8 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: lumigch @ 2020-10-30 21:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
There is an updated pull request by lumigch against master on the void-packages repository
https://github.com/lumigch/void-packages hunspell-pt_PT
https://github.com/void-linux/void-packages/pull/25973
New packages: hunspell-pt_PT and hunspell-pt_PT-preao
Two new packages containing the dictionaries for pt_PT. These are the pre- (hunspell-pt_PT-preao) and post- (hunspell-pt_PT) 1990 Orthographic Agreement.
Since these two packages I related, I decided to create a single pull-request. This is my 1st pull-request for the project, so maybe you prefer two separate requests. Please let me know any problems with these packages.
A patch file from https://github.com/void-linux/void-packages/pull/25973.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hunspell-pt_PT-25973.patch --]
[-- Type: text/x-diff, Size: 2474 bytes --]
From 1e3616b7424b19d0ac7f2c45677778c2e3487889 Mon Sep 17 00:00:00 2001
From: Luis Henriques <lhenriques@suse.de>
Date: Thu, 29 Oct 2020 21:34:13 +0000
Subject: [PATCH 1/2] New package: hunspell-pt_PT-20201029
---
srcpkgs/hunspell-pt_PT/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/hunspell-pt_PT/template
diff --git a/srcpkgs/hunspell-pt_PT/template b/srcpkgs/hunspell-pt_PT/template
new file mode 100644
index 00000000000..96317685854
--- /dev/null
+++ b/srcpkgs/hunspell-pt_PT/template
@@ -0,0 +1,16 @@
+# Template file for 'hunspell-pt_PT'
+pkgname=hunspell-pt_PT
+version=20201029
+revision=1
+short_desc="Portuguese dictionary for hunspell"
+maintainer="Luis Henriques <henrix@camandro.org>"
+license="GPL-2.0-only, LGPL-2.1-only, MPL-1.1"
+homepage="https://natura.di.uminho.pt/wiki/doku.php?id=dicionarios:main"
+distfiles="https://natura.di.uminho.pt/download/sources/Dictionaries/hunspell/${pkgname}-${version}.tar.gz"
+checksum=711b2a2c755546cb341e5cf8ed70157fc4adaacc74b84e132c85b174d791c8db
+
+do_install() {
+ vinstall pt_PT.aff 644 usr/share/hunspell
+ vinstall pt_PT.dic 644 usr/share/hunspell
+ vdoc README_pt_PT.txt
+}
From 7c5fcea1e3819d4b793277af450bdf29e55d2dfd Mon Sep 17 00:00:00 2001
From: Luis Henriques <lhenriques@suse.de>
Date: Thu, 29 Oct 2020 21:34:38 +0000
Subject: [PATCH 2/2] New package: hunspell-pt_PT-preao-20201029
---
srcpkgs/hunspell-pt_PT-preao/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/hunspell-pt_PT-preao/template
diff --git a/srcpkgs/hunspell-pt_PT-preao/template b/srcpkgs/hunspell-pt_PT-preao/template
new file mode 100644
index 00000000000..db8f65fc027
--- /dev/null
+++ b/srcpkgs/hunspell-pt_PT-preao/template
@@ -0,0 +1,16 @@
+# Template file for 'hunspell-pt_PT-preao'
+pkgname=hunspell-pt_PT-preao
+version=20201029
+revision=1
+short_desc="Portuguese dictionary for hunspell (prior to 1990 Orthographic Agreement)"
+maintainer="Luis Henriques <henrix@camandro.org>"
+license="GPL-2.0-only, LGPL-2.1-only, MPL-1.1"
+homepage="https://natura.di.uminho.pt/wiki/doku.php?id=dicionarios:main"
+distfiles="https://natura.di.uminho.pt/download/sources/Dictionaries/hunspell/${pkgname}-${version}.tar.gz"
+checksum=9427f1b21b9a3e8126fce62d008e6215b0b631498232ae567859d363351fbac4
+
+do_install() {
+ vinstall pt_PT-preao.aff 644 usr/share/hunspell
+ vinstall pt_PT-preao.dic 644 usr/share/hunspell
+ vdoc README_pt_PT.txt
+}
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (8 preceding siblings ...)
2020-10-30 21:35 ` [PR PATCH] [Updated] " lumigch
@ 2020-10-30 21:38 ` lumigch
2020-10-31 18:58 ` lumigch
` (7 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: lumigch @ 2020-10-30 21:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
New comment by lumigch on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-719811738
Comment:
I've just pushed a new version of my branch, which includes all the suggestions made by @ericonr (thanks!). Basically:
- dropped usage of 'wrksrc'
- dropped 'depends' on hunspell
- fixed typo on -preao package description
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (9 preceding siblings ...)
2020-10-30 21:38 ` lumigch
@ 2020-10-31 18:58 ` lumigch
2020-10-31 19:04 ` ericonr
` (6 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: lumigch @ 2020-10-31 18:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
New comment by lumigch on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-719973826
Comment:
Looks like there are a bunch of CI failures that aren't really related to the hunspell packages. The only relevant seems to be the hunspell-pt_PT-preao short description being 73 chars instead of the maximum allowed 72. Is this a hard limit, or are the 73 chars allowed? I can change "`Portuguese dictionary for hunspell (prior to 1990 Orthographic Agreement)`" to "`Portuguese dictionary for hunspell (prior to '90 Orthographic Agreement)`" if really needed.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (10 preceding siblings ...)
2020-10-31 18:58 ` lumigch
@ 2020-10-31 19:04 ` ericonr
2020-10-31 19:44 ` lumigch
` (5 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2020-10-31 19:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-719974475
Comment:
CI is a bit wack recently.
Have you built the packages locally and tested them out?
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (11 preceding siblings ...)
2020-10-31 19:04 ` ericonr
@ 2020-10-31 19:44 ` lumigch
2020-11-05 22:06 ` lumigch
` (4 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: lumigch @ 2020-10-31 19:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
New comment by lumigch on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-719979016
Comment:
> CI is a bit wack recently.
>
> Have you built the packages locally and tested them out?
Yes, I did built them, installed and have been using them.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (12 preceding siblings ...)
2020-10-31 19:44 ` lumigch
@ 2020-11-05 22:06 ` lumigch
2020-11-05 22:19 ` ericonr
` (3 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: lumigch @ 2020-11-05 22:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
New comment by lumigch on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-722673655
Comment:
So... @ericonr sorry to bother you again but is there anything else I can/need to do to have these 2 packages merged into void-packages?
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (13 preceding siblings ...)
2020-11-05 22:06 ` lumigch
@ 2020-11-05 22:19 ` ericonr
2020-11-05 23:14 ` lumigch
` (2 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2020-11-05 22:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-722678762
Comment:
Don't worry, thanks for pinging.
Do you think the READMEs need to be added?
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (14 preceding siblings ...)
2020-11-05 22:19 ` ericonr
@ 2020-11-05 23:14 ` lumigch
2020-11-05 23:37 ` ericonr
2020-11-09 3:20 ` [PR PATCH] [Merged]: " ericonr
17 siblings, 0 replies; 19+ messages in thread
From: lumigch @ 2020-11-05 23:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
New comment by lumigch on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-722699010
Comment:
> Don't worry, thanks for pinging.
>
> Do you think the READMEs need to be added?
I checked a few other distros packages and some include it, some don't.
The most relevant argument to include it is that the [mozilla addon](https://addons.mozilla.org/en-US/firefox/addon/european-portuguese-spellcheck/), which seems to be packaged by the dictionaries authors themselves, **does** include the README file.
Anyway, I'm OK either way: I can re-push the branch without it if you rather not include it.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (15 preceding siblings ...)
2020-11-05 23:14 ` lumigch
@ 2020-11-05 23:37 ` ericonr
2020-11-09 3:20 ` [PR PATCH] [Merged]: " ericonr
17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2020-11-05 23:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25973#issuecomment-722706742
Comment:
Sounds reasonable to me. I will wait to merge it, because the builder is currently building libreoffice and that takes a while; merging new packages in the meantime can lead to it not being built.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PR PATCH] [Merged]: New packages: hunspell-pt_PT and hunspell-pt_PT-preao
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
` (16 preceding siblings ...)
2020-11-05 23:37 ` ericonr
@ 2020-11-09 3:20 ` ericonr
17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2020-11-09 3:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
There's a merged pull request on the void-packages repository
New packages: hunspell-pt_PT and hunspell-pt_PT-preao
https://github.com/void-linux/void-packages/pull/25973
Description:
Two new packages containing the dictionaries for pt_PT. These are the pre- (hunspell-pt_PT-preao) and post- (hunspell-pt_PT) 1990 Orthographic Agreement.
Since these two packages I related, I decided to create a single pull-request. This is my 1st pull-request for the project, so maybe you prefer two separate requests. Please let me know any problems with these packages.
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2020-11-09 3:20 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 21:52 [PR PATCH] New packagew: hunspell-pt_PT and hunspell-pt_PT-preao lumigch
2020-10-29 22:09 ` New packages: " ericonr
2020-10-29 23:54 ` sgn
2020-10-30 0:16 ` [PR REVIEW] " ericonr
2020-10-30 0:18 ` ericonr
2020-10-30 0:19 ` ericonr
2020-10-30 0:19 ` ericonr
2020-10-30 9:28 ` lumigch
2020-10-30 9:29 ` lumigch
2020-10-30 21:35 ` [PR PATCH] [Updated] " lumigch
2020-10-30 21:38 ` lumigch
2020-10-31 18:58 ` lumigch
2020-10-31 19:04 ` ericonr
2020-10-31 19:44 ` lumigch
2020-11-05 22:06 ` lumigch
2020-11-05 22:19 ` ericonr
2020-11-05 23:14 ` lumigch
2020-11-05 23:37 ` ericonr
2020-11-09 3:20 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).