[PR PATCH] ardour: add pulseaudio backend

Github messages for voidlinux
 help / color / mirror / Atom feed

* [PR PATCH] ardour: add pulseaudio backend
@ 2020-11-04 20:02 krkk
  2020-11-05  7:12 ` krkk
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: krkk @ 2020-11-04 20:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

There is a new pull request by krkk against master on the void-packages repository

https://github.com/krkk/void-packages ardour-pulseaudio
https://github.com/void-linux/void-packages/pull/26135

ardour: add pulseaudio backend


A patch file from https://github.com/void-linux/void-packages/pull/26135.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ardour-pulseaudio-26135.patch --]
[-- Type: text/x-diff, Size: 1444 bytes --]

From 9de64815711fe40901e684958404cca1f2c7a3ca Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Wed, 4 Nov 2020 20:50:23 +0100
Subject: [PATCH] ardour: add pulseaudio backend

---
 srcpkgs/ardour/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ardour/template b/srcpkgs/ardour/template
index fcedeb358a1..f44dd707260 100644
--- a/srcpkgs/ardour/template
+++ b/srcpkgs/ardour/template
@@ -1,10 +1,10 @@
 # Template file for 'ardour'
 pkgname=ardour
 version=6.3.0
-revision=1
+revision=2
 wrksrc="Ardour-${version}"
 build_style=waf3
-configure_args="--cxx11 --no-phone-home --with-backends=jack,alsa,dummy
+configure_args="--cxx11 --no-phone-home --with-backends=jack,alsa,pulseaudio,dummy
  --libjack=weak --optimize --docs --use-external-libs --freedesktop"
 hostmakedepends="python3 graphviz doxygen pkg-config clang perl
  itstool gettext tar readline-devel"
@@ -12,7 +12,7 @@ makedepends="boost-devel liblrdf-devel liblo-devel lilv-devel suil-devel
  taglib-devel aubio-devel rubberband-devel alsa-lib-devel libsndfile-devel
  vamp-plugin-sdk-devel fftw-devel jack-devel libsamplerate-devel lv2
  sratom-devel gtkmm2-devel libarchive-devel fluidsynth-devel hidapi-devel
- libltc-devel glibmm-devel"
+ libltc-devel glibmm-devel pulseaudio-devel"
 short_desc="Professional-grade digital audio workstation"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
@ 2020-11-05  7:12 ` krkk
  2020-11-05 13:15 ` ericonr
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: krkk @ 2020-11-05  7:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New comment by krkk on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-722189670

Comment:
uhhh while the patch overall does its job, closing the app with this backend freezes itself, which isn't so great (x86_64-musl). :(

can be closed it if that isn't okay with you.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
  2020-11-05  7:12 ` krkk
@ 2020-11-05 13:15 ` ericonr
  2020-11-05 15:57 ` krkk
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2020-11-05 13:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-722370921

Comment:
>  closing the app with this backend freezes itself, which isn't so great (x86_64-musl).

Might be an issue with how it interacts with musl; PA has some design choices that may depend on glibc behaviors. Does it still freeze if you don't use the backend, and it's only been compiled in?

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
  2020-11-05  7:12 ` krkk
  2020-11-05 13:15 ` ericonr
@ 2020-11-05 15:57 ` krkk
  2020-12-20  4:32 ` ericonr
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: krkk @ 2020-11-05 15:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by krkk on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-722467459

Comment:
> Does it still freeze if you don't use the backend, and it's only been compiled in?

No, it doesn't freeze with alsa

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (2 preceding siblings ...)
  2020-11-05 15:57 ` krkk
@ 2020-12-20  4:32 ` ericonr
  2020-12-20  4:34 ` ericonr
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2020-12-20  4:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-748561657

Comment:
I guess when you have pulseaudio running and use the alsa backend, it runs alsa through pulse anyway? Which wouldn't have locking issues.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (3 preceding siblings ...)
  2020-12-20  4:32 ` ericonr
@ 2020-12-20  4:34 ` ericonr
  2020-12-20 17:29 ` krkk
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2020-12-20  4:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-748561724

Comment:
If you think you should go on with the PR, please fix the download location to use https://github.com/Ardour/ardour/ ; they delete old tarballs.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (4 preceding siblings ...)
  2020-12-20  4:34 ` ericonr
@ 2020-12-20 17:29 ` krkk
  2020-12-20 23:04 ` ericonr
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: krkk @ 2020-12-20 17:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

New comment by krkk on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-748636258

Comment:
> I guess when you have pulseaudio running and use the alsa backend, it runs alsa through pulse anyway? Which wouldn't have locking issues.

Well, running ardour with alsa backend does lock pulse at my machine.

> If you think you should go on with the PR, please fix the download location to use https://github.com/Ardour/ardour/ ; they delete old tarballs.

they also [exclude everything] from tarballs – the only thing that's shipped inside is [README-GITHUB.txt].

[exclude everything]: https://github.com/Ardour/ardour/blob/6.3/.gitattributes
[README-GITHUB.txt]: https://github.com/Ardour/ardour/blob/6.3/README-GITHUB.txt


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (5 preceding siblings ...)
  2020-12-20 17:29 ` krkk
@ 2020-12-20 23:04 ` ericonr
  2020-12-24  9:49 ` krkk
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2020-12-20 23:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-748683825

Comment:
If you have an account in their bug tracker, could you complain about that? It'd be okay if they at least provided tarballs for all releases, but given that they remove old ones...

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (6 preceding siblings ...)
  2020-12-20 23:04 ` ericonr
@ 2020-12-24  9:49 ` krkk
  2020-12-24 14:23 ` ericonr
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: krkk @ 2020-12-24  9:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by krkk on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-750828321

Comment:
Sorry, I don't have an account there.


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (7 preceding siblings ...)
  2020-12-24  9:49 ` krkk
@ 2020-12-24 14:23 ` ericonr
  2021-07-20 20:23 ` ericonr
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2020-12-24 14:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-750896577

Comment:
No problem. If you still use the software, we can perhaps repurpose this PR to update it to 6.5 :) 

Otherwise, there's a chance the hang was caused by a very specific pattern, and might be solved in Musl 1.2.2. We can revisit enabling pulse then. Or you can make it an off by default build option.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (8 preceding siblings ...)
  2020-12-24 14:23 ` ericonr
@ 2021-07-20 20:23 ` ericonr
  2021-07-20 21:19 ` [PR PATCH] [Closed]: " krkk
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-07-20 20:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-883670339

Comment:
@krkk do you still have interest in pursuing this PR? I can send you a branch with newer musl for testing purposes, if you want.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Closed]: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (9 preceding siblings ...)
  2021-07-20 20:23 ` ericonr
@ 2021-07-20 21:19 ` krkk
  2021-07-20 21:19 ` krkk
  2021-07-20 21:21 ` ericonr
  12 siblings, 0 replies; 14+ messages in thread
From: krkk @ 2021-07-20 21:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

There's a closed pull request on the void-packages repository

ardour: add pulseaudio backend
https://github.com/void-linux/void-packages/pull/26135

Description:


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (10 preceding siblings ...)
  2021-07-20 21:19 ` [PR PATCH] [Closed]: " krkk
@ 2021-07-20 21:19 ` krkk
  2021-07-20 21:21 ` ericonr
  12 siblings, 0 replies; 14+ messages in thread
From: krkk @ 2021-07-20 21:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by krkk on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-883715702

Comment:
I'm sorry, I don't. I no longer use musl and pulseaudio.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ardour: add pulseaudio backend
  2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
                   ` (11 preceding siblings ...)
  2021-07-20 21:19 ` krkk
@ 2021-07-20 21:21 ` ericonr
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-07-20 21:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26135#issuecomment-883716751

Comment:
No worries :)

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2021-07-20 21:21 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04 20:02 [PR PATCH] ardour: add pulseaudio backend krkk
2020-11-05  7:12 ` krkk
2020-11-05 13:15 ` ericonr
2020-11-05 15:57 ` krkk
2020-12-20  4:32 ` ericonr
2020-12-20  4:34 ` ericonr
2020-12-20 17:29 ` krkk
2020-12-20 23:04 ` ericonr
2020-12-24  9:49 ` krkk
2020-12-24 14:23 ` ericonr
2021-07-20 20:23 ` ericonr
2021-07-20 21:19 ` [PR PATCH] [Closed]: " krkk
2021-07-20 21:19 ` krkk
2021-07-20 21:21 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).