[PR PATCH] bitcoin: update to 0.20.1

[PR PATCH] bitcoin: update to 0.20.1

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

There is a new pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages bitcoin
https://github.com/void-linux/void-packages/pull/26228

bitcoin: update to 0.20.1


A patch file from https://github.com/void-linux/void-packages/pull/26228.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bitcoin-26228.patch --]
[-- Type: text/x-diff, Size: 1903 bytes --]

From e159fa57e6a50b4946f67e856de07ed4b040e0e6 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Sun, 8 Nov 2020 15:05:03 -0600
Subject: [PATCH] bitcoin: update to 0.20.1

---
 srcpkgs/bitcoin/template | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/bitcoin/template b/srcpkgs/bitcoin/template
index df1ab218e16..84647652374 100644
--- a/srcpkgs/bitcoin/template
+++ b/srcpkgs/bitcoin/template
@@ -1,11 +1,11 @@
 # Template file for 'bitcoin'
 pkgname=bitcoin
-version=0.19.1
-revision=3
+version=0.20.1
+revision=1
 build_style=gnu-configure
 configure_args="--with-incompatible-bdb --disable-ccache --disable-static
  --enable-hardening --with-boost=${XBPS_CROSS_BASE}/usr"
-hostmakedepends="pkg-config yasm protobuf"
+hostmakedepends="pkg-config yasm protobuf autoconf automake libtool"
 makedepends="db-devel protobuf-devel libprotoc-devel boost-devel
  miniupnpc-devel libevent-devel qrencode-devel libatomic-devel"
 short_desc="Bitcoin is a peer-to-peer network based digital currency"
@@ -15,7 +15,7 @@ homepage="https://bitcoin.org/"
 distfiles="https://bitcoin.org/bin/bitcoin-core-${version}/bitcoin-${version}.tar.gz
  https://raw.github.com/bitcoin-core/packaging/master/debian/bitcoin-qt.desktop
  https://raw.github.com/bitcoin/bitcoin/v${version}/share/pixmaps/bitcoin128.png"
-checksum="f2591d555b8e8c2e1bd780e40d53a91e165d8b3c7e0391ae2d24a0c0f23a7cc0
+checksum="4bbd62fd6acfa5e9864ebf37a24a04bc2dcfe3e3222f056056288d854c53b978
  0a46bbadda140599e807be38999e6848c89f9c3523d26fede02d34d62d50f632
  ad880c8459ecfdb96abe6a4689af06bdd27906e0edcd39d0915482f2da91e722"
 conflicts="litecoin>=0" # Both provide libbitcoinconsensus.so.0
@@ -29,6 +29,10 @@ if [ -z "$CROSS_BUILD" ]; then
 	subpackages+=" bitcoin-qt"
 fi
 
+pre_configure() {
+  autoreconf -fi
+}
+
 post_install() {
 	rm "${DESTDIR}"/usr/bin/{test,bench}_bitcoin
 

Re: [PR REVIEW] bitcoin: update to 0.20.1

[ofiala-a51]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by ofiala-a51 on void-packages repository

https://github.com/void-linux/void-packages/pull/26228#discussion_r519480335

Comment:
those are already implicitly required by setting the `build_style` to `gnu-configure`

Re: [PR REVIEW] bitcoin: update to 0.20.1

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/26228#discussion_r519480878

Comment:
It's already set as gnu-configure and it doesn't pull them

Re: [PR REVIEW] bitcoin: update to 0.20.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26228#discussion_r519483161

Comment:
Those are additional, yeah. Autohell welcomes you :) 

Re: [PR PATCH] [Closed]: bitcoin: update to 0.20.1

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

There's a closed pull request on the void-packages repository

bitcoin: update to 0.20.1
https://github.com/void-linux/void-packages/pull/26228

Description:

Re: bitcoin: update to 0.20.1

[ev-ermakov]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by ev-ermakov on void-packages repository

https://github.com/void-linux/void-packages/pull/26228#issuecomment-724123082

Comment:
There are no need for `protobuf`, `protobuf-devel` and `libprotoc-devel` anymore.

Re: bitcoin: update to 0.20.1

[ev-ermakov]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by ev-ermakov on void-packages repository

https://github.com/void-linux/void-packages/pull/26228#issuecomment-724125029

Comment:
Also, seems the patch `qt5.15.patch` can be removed.

Re: bitcoin: update to 0.20.1

[ev-ermakov]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

New comment by ev-ermakov on void-packages repository

https://github.com/void-linux/void-packages/pull/26228#issuecomment-724130344

Comment:
The following code block should be added:
```sh
pre_build() {
	export BITCOIN_GENBUILD_NO_GIT=1
}
```

And just a little cosmetic change:
```diff
-		vinstall contrib/${b}.bash-completion 644 usr/share/bash-completion $b
+		vcompletion contrib/${b}.bash-completion bash $b
```

Re: [PR PATCH] [Closed]: bitcoin: update to 0.20.1

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

There's a closed pull request on the void-packages repository

bitcoin: update to 0.20.1
https://github.com/void-linux/void-packages/pull/26246

Description: