* Re: [PR PATCH] [Closed]: engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
@ 2020-10-31 19:20 ` skmpz
2020-11-12 20:53 ` [PR REVIEW] " Piraty
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2020-10-31 19:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
There's a closed pull request on the void-packages repository
engrampa: update to 1.24.1.
https://github.com/void-linux/void-packages/pull/26005
Description:
cross compilation broken.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
2020-10-31 19:20 ` [PR PATCH] [Closed]: " skmpz
@ 2020-11-12 20:53 ` Piraty
2020-11-12 21:11 ` ericonr
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Piraty @ 2020-11-12 20:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#discussion_r522419317
Comment:
this is unacceptable, please file an issue upstream. commit that broke it: https://github.com/mate-desktop/engrampa/commit/25b2bdbcfb95c91a33fd62370cac28a863567c3f
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
2020-10-31 19:20 ` [PR PATCH] [Closed]: " skmpz
2020-11-12 20:53 ` [PR REVIEW] " Piraty
@ 2020-11-12 21:11 ` ericonr
2020-11-12 21:19 ` ericonr
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-11-12 21:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#discussion_r522428609
Comment:
If they want to keep their (imo terrible) test, they should at least run it with host CC.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR REVIEW] engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
` (2 preceding siblings ...)
2020-11-12 21:11 ` ericonr
@ 2020-11-12 21:19 ` ericonr
2020-11-13 11:57 ` sgn
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-11-12 21:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#discussion_r522432418
Comment:
Alternatively, they can just check for the two possible ZSTD values and not require all this machinery.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
` (3 preceding siblings ...)
2020-11-12 21:19 ` ericonr
@ 2020-11-13 11:57 ` sgn
2020-11-25 12:55 ` Piraty
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-11-13 11:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#issuecomment-726724933
Comment:
On 2020-11-12 13:19:14-0800, Érico Nogueira Rolim <notifications@github.com> wrote:
> @ericonr commented on this pull request.
>
>
>
> > license="GPL-2.0-or-later"
> homepage="https://mate-desktop.org"
> distfiles="https://pub.mate-desktop.org/releases/${version%.*}/${pkgname}-${version}.tar.xz"
> -checksum=d415f486edc9a5474024b3928ff1127ba4534a703a60993a3912fffcf0988a8d
> +checksum=fe24e04efb34a67374d2a46a3bf2a0a445b77e0ec43216e4c3f14e5cd0b7722a
> +nocross="cannot run test program while cross compiling"
>
> Alternatively, they can just check for the two possible ZSTD values and not require all this machinery.
The check is terrible, let's patch it.
--
Danh
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
` (4 preceding siblings ...)
2020-11-13 11:57 ` sgn
@ 2020-11-25 12:55 ` Piraty
2020-11-25 12:59 ` skmpz
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Piraty @ 2020-11-25 12:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#issuecomment-733689630
Comment:
ping @skmpz
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
` (5 preceding siblings ...)
2020-11-25 12:55 ` Piraty
@ 2020-11-25 12:59 ` skmpz
2020-11-25 13:00 ` skmpz
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2020-11-25 12:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
New comment by skmpz on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#issuecomment-733691758
Comment:
yeah, how should we proceed with this? I saw you commented on the commit upstream, but no changes yet.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
` (6 preceding siblings ...)
2020-11-25 12:59 ` skmpz
@ 2020-11-25 13:00 ` skmpz
2020-11-25 13:01 ` skmpz
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2020-11-25 13:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New comment by skmpz on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#issuecomment-733691758
Comment:
yeah, how should we proceed with this? I saw you commented on the commit upstream, but no changes or replies yet.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
` (7 preceding siblings ...)
2020-11-25 13:00 ` skmpz
@ 2020-11-25 13:01 ` skmpz
2020-11-25 20:25 ` ndowens
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: skmpz @ 2020-11-25 13:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
New comment by skmpz on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#issuecomment-733691758
Comment:
yeah, how should we proceed with this? I saw you commented on the commit upstream, but no changes or replies yet. Shall we just patch it reverting the changes of that commit ?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
` (8 preceding siblings ...)
2020-11-25 13:01 ` skmpz
@ 2020-11-25 20:25 ` ndowens
2020-12-01 16:40 ` Piraty
2020-12-18 0:25 ` [PR PATCH] [Closed]: " sgn
11 siblings, 0 replies; 13+ messages in thread
From: ndowens @ 2020-11-25 20:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
New comment by ndowens on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#issuecomment-733930331
Comment:
@skmpz Here is a patch I did that allowed me to cross-build https://termbin.com/s44og
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
` (9 preceding siblings ...)
2020-11-25 20:25 ` ndowens
@ 2020-12-01 16:40 ` Piraty
2020-12-18 0:25 ` [PR PATCH] [Closed]: " sgn
11 siblings, 0 replies; 13+ messages in thread
From: Piraty @ 2020-12-01 16:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/26005#issuecomment-736670755
Comment:
> yeah, how should we proceed with this? I saw you commented on the commit upstream, but no changes or replies yet. Shall we just patch it reverting the changes of that commit ?
@skmpz as said before, file an upstream issue
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PR PATCH] [Closed]: engrampa: update to 1.24.1.
2020-10-31 18:17 [PR PATCH] engrampa: update to 1.24.1 skmpz
` (10 preceding siblings ...)
2020-12-01 16:40 ` Piraty
@ 2020-12-18 0:25 ` sgn
11 siblings, 0 replies; 13+ messages in thread
From: sgn @ 2020-12-18 0:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
There's a closed pull request on the void-packages repository
engrampa: update to 1.24.1.
https://github.com/void-linux/void-packages/pull/26005
Description:
cross compilation broken.
^ permalink raw reply [flat|nested] 13+ messages in thread