From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] libsecret: update to 0.20.4
Date: Fri, 13 Nov 2020 20:15:04 +0100 [thread overview]
Message-ID: <20201113191504.rZjSMDCbq_uWzaWClA6NvOqC4g1TB8q2UcTATA22L4A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26278@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/26278#discussion_r523170428
Comment:
There's not a compelling reason to guard this in a `$CROSS_BUILD` test; just add `glib-devel` to `hostmakedepends` and `makedepends` in all cases.
next prev parent reply other threads:[~2020-11-13 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 0:29 [PR PATCH] " ndowens
2020-11-13 19:15 ` ahesford [this message]
2020-11-14 0:23 ` [PR PATCH] [Updated] " ndowens
2020-11-14 1:10 ` ndowens
2020-11-14 4:26 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113191504.rZjSMDCbq_uWzaWClA6NvOqC4g1TB8q2UcTATA22L4A@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).