[PR PATCH] duplicity: update to 0.8.17

[PR PATCH] duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

There is a new pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages duplicity
https://github.com/void-linux/void-packages/pull/26369

duplicity: update to 0.8.17
[ci skip]

A patch file from https://github.com/void-linux/void-packages/pull/26369.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-duplicity-26369.patch --]
[-- Type: text/x-diff, Size: 1395 bytes --]

From 93a7b280b3da442536397f53e532fff5ff54d362 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Fri, 13 Nov 2020 23:48:40 -0600
Subject: [PATCH] duplicity: update to 0.8.17

[ci skip]
---
 srcpkgs/duplicity/template | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/duplicity/template b/srcpkgs/duplicity/template
index ff421ea456f..cf7e23094f6 100644
--- a/srcpkgs/duplicity/template
+++ b/srcpkgs/duplicity/template
@@ -1,7 +1,7 @@
 # Template file for 'duplicity'
 pkgname=duplicity
-version=0.8.16
-revision=2
+version=0.8.17
+revision=1
 build_style=python3-module
 hostmakedepends="gettext python3-setuptools"
 makedepends="python3-devel librsync-devel"
@@ -12,19 +12,13 @@ license="GPL-2.0-or-later"
 homepage="http://duplicity.nongnu.org/"
 changelog="http://duplicity.nongnu.org/vers8/CHANGELOG"
 distfiles="http://launchpad.net/duplicity/${version%.*}-series/${version}/+download/duplicity-${version}.tar.gz"
-checksum=2cfcd212834979751310d9df1a954b949f86b084efd5ad1f97dd744780ef9d1b
+checksum=a273b1e74d8d0b7825572f51be9c8284e579961e01f4fc1473048e95dce49984
 
 post_extract() {
 	chmod 0644 bin/*.1
 }
 
-do_check() {
-	# Disable as tests don't work
-	# tests look for pytest,instead of pytest{2,3}
-	:
-}
-
 post_install() {
-	# drop doc
-	rm -rf ${DESTDIR}/usr/share/doc
+	# Remove docs
+	rm -rf usr/share/doc
 }

Re: [PR PATCH] [Closed]: duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

There's a closed pull request on the void-packages repository

duplicity: update to 0.8.17
https://github.com/void-linux/void-packages/pull/26369

Description:

Re: [PR REVIEW] duplicity: update to 0.8.17

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26369#discussion_r523466811

Comment:
This doesn't do what you think; the working directory for `post_install` is `${wrksrc}` or, if defined, `${build_wrksrc}`; you are removing `usr/share/doc` from the build tree (which probabaly doesn't exist anyway), not the package destination.

Re: [PR PATCH] [Updated] duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages duplicity
https://github.com/void-linux/void-packages/pull/26369

duplicity: update to 0.8.17


A patch file from https://github.com/void-linux/void-packages/pull/26369.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-duplicity-26369.patch --]
[-- Type: text/x-diff, Size: 1370 bytes --]

From 65f603f55bdef289cbb47b7c67c4274c33634fe2 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Fri, 13 Nov 2020 23:48:40 -0600
Subject: [PATCH] duplicity: update to 0.8.17

[ci skip]
---
 srcpkgs/duplicity/template | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/duplicity/template b/srcpkgs/duplicity/template
index ff421ea456f..74f63aaa9fa 100644
--- a/srcpkgs/duplicity/template
+++ b/srcpkgs/duplicity/template
@@ -1,7 +1,7 @@
 # Template file for 'duplicity'
 pkgname=duplicity
-version=0.8.16
-revision=2
+version=0.8.17
+revision=1
 build_style=python3-module
 hostmakedepends="gettext python3-setuptools"
 makedepends="python3-devel librsync-devel"
@@ -12,19 +12,13 @@ license="GPL-2.0-or-later"
 homepage="http://duplicity.nongnu.org/"
 changelog="http://duplicity.nongnu.org/vers8/CHANGELOG"
 distfiles="http://launchpad.net/duplicity/${version%.*}-series/${version}/+download/duplicity-${version}.tar.gz"
-checksum=2cfcd212834979751310d9df1a954b949f86b084efd5ad1f97dd744780ef9d1b
+checksum=a273b1e74d8d0b7825572f51be9c8284e579961e01f4fc1473048e95dce49984
 
 post_extract() {
 	chmod 0644 bin/*.1
 }
 
-do_check() {
-	# Disable as tests don't work
-	# tests look for pytest,instead of pytest{2,3}
-	:
-}
-
 post_install() {
-	# drop doc
+	# Remove docs
 	rm -rf ${DESTDIR}/usr/share/doc
 }

Re: [PR REVIEW] duplicity: update to 0.8.17

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26369#discussion_r523473744

Comment:
If at all possible, I'd like this to run with `rm -r` only, so it can catch the possibility of the file no longer existing. Most packages shouldn't be write protected, so I think it would work.

That said, why are docs being removed?

Re: [PR REVIEW] duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/26369#discussion_r523473881

Comment:
Seems it was possibly removed before due to containing just these:
./usr/share/doc/duplicity-0.8.17/README.md
./usr/share/doc/duplicity-0.8.17/README-TESTING.md
./usr/share/doc/duplicity-0.8.17/README-REPO.md
./usr/share/doc/duplicity-0.8.17/README-LOG.md
./usr/share/doc/duplicity-0.8.17/COPYING
./usr/share/doc/duplicity-0.8.17/CHANGELOG.md
./usr/share/doc/duplicity-0.8.17/AUTHORS

So sorta, IMO, worthless as it doesn't contain things just as manpages and other helpful docs

Re: [PR PATCH] [Updated] duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages duplicity
https://github.com/void-linux/void-packages/pull/26369

duplicity: update to 0.8.17


A patch file from https://github.com/void-linux/void-packages/pull/26369.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-duplicity-26369.patch --]
[-- Type: text/x-diff, Size: 1405 bytes --]

From 6c34713e9347ed43f4e4f7cb77c9f53b99640dc1 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Fri, 13 Nov 2020 23:48:40 -0600
Subject: [PATCH] duplicity: update to 0.8.17

[ci skip]
---
 srcpkgs/duplicity/template | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/duplicity/template b/srcpkgs/duplicity/template
index ff421ea456f..22bec8d95ba 100644
--- a/srcpkgs/duplicity/template
+++ b/srcpkgs/duplicity/template
@@ -1,7 +1,7 @@
 # Template file for 'duplicity'
 pkgname=duplicity
-version=0.8.16
-revision=2
+version=0.8.17
+revision=1
 build_style=python3-module
 hostmakedepends="gettext python3-setuptools"
 makedepends="python3-devel librsync-devel"
@@ -12,19 +12,13 @@ license="GPL-2.0-or-later"
 homepage="http://duplicity.nongnu.org/"
 changelog="http://duplicity.nongnu.org/vers8/CHANGELOG"
 distfiles="http://launchpad.net/duplicity/${version%.*}-series/${version}/+download/duplicity-${version}.tar.gz"
-checksum=2cfcd212834979751310d9df1a954b949f86b084efd5ad1f97dd744780ef9d1b
+checksum=a273b1e74d8d0b7825572f51be9c8284e579961e01f4fc1473048e95dce49984
 
 post_extract() {
 	chmod 0644 bin/*.1
 }
 
-do_check() {
-	# Disable as tests don't work
-	# tests look for pytest,instead of pytest{2,3}
-	:
-}
-
 post_install() {
-	# drop doc
-	rm -rf ${DESTDIR}/usr/share/doc
+	# Remove docs
+	rm -r ${DESTDIR}/usr/share/doc
 }

Re: [PR REVIEW] duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/26369#discussion_r523473881

Comment:
Seems it was possibly removed before due to containing just these:
./usr/share/doc/duplicity-0.8.17/README.md
./usr/share/doc/duplicity-0.8.17/README-TESTING.md
./usr/share/doc/duplicity-0.8.17/README-REPO.md
./usr/share/doc/duplicity-0.8.17/README-LOG.md
./usr/share/doc/duplicity-0.8.17/COPYING
./usr/share/doc/duplicity-0.8.17/CHANGELOG.md
./usr/share/doc/duplicity-0.8.17/AUTHORS

So sorta, IMO, worthless as it doesn't contain things just as manpages and other helpful docs.

P.S. Changed to rm -r

Re: [PR REVIEW] duplicity: update to 0.8.17

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26369#discussion_r523474086

Comment:
Did upstream completely remove their tests? Right now there isn't a `test` target in `setup.py`, but they could be using `pytest` directly.

Re: [PR REVIEW] duplicity: update to 0.8.17

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26369#discussion_r523474108

Comment:
Fair enough.

Re: [PR REVIEW] duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/26369#discussion_r523477068

Comment:
Looks like they did change it to pytest. will update

Re: [PR REVIEW] duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/26369#discussion_r523477068

Comment:
Looks like they did change it to pytest. will update.

Edit: I added sh testing/run-tests and it has test failures, so we may not can merge this after all.

Re: [PR PATCH] [Updated] duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages duplicity
https://github.com/void-linux/void-packages/pull/26369

duplicity: update to 0.8.17


A patch file from https://github.com/void-linux/void-packages/pull/26369.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-duplicity-26369.patch --]
[-- Type: text/x-diff, Size: 2430 bytes --]

From 6c34713e9347ed43f4e4f7cb77c9f53b99640dc1 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Fri, 13 Nov 2020 23:48:40 -0600
Subject: [PATCH 1/2] duplicity: update to 0.8.17

[ci skip]
---
 srcpkgs/duplicity/template | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/duplicity/template b/srcpkgs/duplicity/template
index ff421ea456f..22bec8d95ba 100644
--- a/srcpkgs/duplicity/template
+++ b/srcpkgs/duplicity/template
@@ -1,7 +1,7 @@
 # Template file for 'duplicity'
 pkgname=duplicity
-version=0.8.16
-revision=2
+version=0.8.17
+revision=1
 build_style=python3-module
 hostmakedepends="gettext python3-setuptools"
 makedepends="python3-devel librsync-devel"
@@ -12,19 +12,13 @@ license="GPL-2.0-or-later"
 homepage="http://duplicity.nongnu.org/"
 changelog="http://duplicity.nongnu.org/vers8/CHANGELOG"
 distfiles="http://launchpad.net/duplicity/${version%.*}-series/${version}/+download/duplicity-${version}.tar.gz"
-checksum=2cfcd212834979751310d9df1a954b949f86b084efd5ad1f97dd744780ef9d1b
+checksum=a273b1e74d8d0b7825572f51be9c8284e579961e01f4fc1473048e95dce49984
 
 post_extract() {
 	chmod 0644 bin/*.1
 }
 
-do_check() {
-	# Disable as tests don't work
-	# tests look for pytest,instead of pytest{2,3}
-	:
-}
-
 post_install() {
-	# drop doc
-	rm -rf ${DESTDIR}/usr/share/doc
+	# Remove docs
+	rm -r ${DESTDIR}/usr/share/doc
 }

From 19a200f38882bb8d220f16da9529fd7504a95095 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Sat, 14 Nov 2020 17:55:09 -0600
Subject: [PATCH 2/2] Add test

---
 srcpkgs/duplicity/template | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/srcpkgs/duplicity/template b/srcpkgs/duplicity/template
index 22bec8d95ba..cdf52c9f110 100644
--- a/srcpkgs/duplicity/template
+++ b/srcpkgs/duplicity/template
@@ -5,6 +5,8 @@ revision=1
 build_style=python3-module
 hostmakedepends="gettext python3-setuptools"
 makedepends="python3-devel librsync-devel"
+checkdepends="python3-pytest python3-future python3-fasteners
+ python3-mock python3-pexpect"
 depends="python3-fasteners gnupg python3-future python3-urllib3"
 short_desc="Encrypted bandwidth-efficient backup using the rsync algorithm"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -18,6 +20,10 @@ post_extract() {
 	chmod 0644 bin/*.1
 }
 
+do_check() {
+	pytest
+}
+
 post_install() {
 	# Remove docs
 	rm -r ${DESTDIR}/usr/share/doc

Re: [PR PATCH] [Closed]: duplicity: update to 0.8.17

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

There's a closed pull request on the void-packages repository

duplicity: update to 0.8.17
https://github.com/void-linux/void-packages/pull/26369

Description: