* [PR PATCH] grafana: Create /var/log/grafana on install
@ 2020-11-15 6:35 Goorzhel
2020-11-15 6:37 ` Goorzhel
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Goorzhel @ 2020-11-15 6:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
There is a new pull request by Goorzhel against master on the void-packages repository
https://github.com/Goorzhel/void-packages grafana
https://github.com/void-linux/void-packages/pull/26391
grafana: Create /var/log/grafana on install
Directory is referenced in `[template](https://github.com/Goorzhel/void-packages/blob/25102fb7685b04c1abf23456d3f78ce31c3094ce/srcpkgs/grafana/template#L49)`.
@the-maldridge
A patch file from https://github.com/void-linux/void-packages/pull/26391.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grafana-26391.patch --]
[-- Type: text/x-diff, Size: 681 bytes --]
From 25102fb7685b04c1abf23456d3f78ce31c3094ce Mon Sep 17 00:00:00 2001
From: Antonio Gurgel <antonio@goorzhel.com>
Date: Sat, 14 Nov 2020 22:20:21 -0800
Subject: [PATCH] grafana: Create /var/log/grafana on install
---
srcpkgs/grafana/INSTALL | 2 ++
1 file changed, 2 insertions(+)
diff --git a/srcpkgs/grafana/INSTALL b/srcpkgs/grafana/INSTALL
index da69a64d86f..b233e20d946 100644
--- a/srcpkgs/grafana/INSTALL
+++ b/srcpkgs/grafana/INSTALL
@@ -4,6 +4,8 @@ case "$ACTION" in
:
else
chown _grafana:_grafana var/lib/grafana
+ vmkdir var/log/grafana
+ chown _grafana:_grafana var/log/grafana
fi
;;
esac
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: grafana: Create /var/log/grafana on install
2020-11-15 6:35 [PR PATCH] grafana: Create /var/log/grafana on install Goorzhel
@ 2020-11-15 6:37 ` Goorzhel
2020-11-15 6:37 ` [PR PATCH] [Closed]: " Goorzhel
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Goorzhel @ 2020-11-15 6:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
New comment by Goorzhel on void-packages repository
https://github.com/void-linux/void-packages/pull/26391#issuecomment-727523936
Comment:
Oh, dear, this is an old patch I thought I'd send up, before I saw the [`make_dirs`](https://github.com/Goorzhel/void-packages/blob/25102fb7685b04c1abf23456d3f78ce31c3094ce/srcpkgs/grafana/template#L18) line. My apologies.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: grafana: Create /var/log/grafana on install
2020-11-15 6:35 [PR PATCH] grafana: Create /var/log/grafana on install Goorzhel
2020-11-15 6:37 ` Goorzhel
@ 2020-11-15 6:37 ` Goorzhel
2020-11-15 6:37 ` [PR REVIEW] " the-maldridge
2020-11-15 6:38 ` the-maldridge
3 siblings, 0 replies; 5+ messages in thread
From: Goorzhel @ 2020-11-15 6:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
There's a closed pull request on the void-packages repository
grafana: Create /var/log/grafana on install
https://github.com/void-linux/void-packages/pull/26391
Description:
Directory is referenced in [`template`](https://github.com/Goorzhel/void-packages/blob/25102fb7685b04c1abf23456d3f78ce31c3094ce/srcpkgs/grafana/template#L49).
@the-maldridge
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] grafana: Create /var/log/grafana on install
2020-11-15 6:35 [PR PATCH] grafana: Create /var/log/grafana on install Goorzhel
2020-11-15 6:37 ` Goorzhel
2020-11-15 6:37 ` [PR PATCH] [Closed]: " Goorzhel
@ 2020-11-15 6:37 ` the-maldridge
2020-11-15 6:38 ` the-maldridge
3 siblings, 0 replies; 5+ messages in thread
From: the-maldridge @ 2020-11-15 6:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New review comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/26391#discussion_r523715475
Comment:
vmkdir is not available in an INSTALL script. You need to do a normal mkdir here.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: grafana: Create /var/log/grafana on install
2020-11-15 6:35 [PR PATCH] grafana: Create /var/log/grafana on install Goorzhel
` (2 preceding siblings ...)
2020-11-15 6:37 ` [PR REVIEW] " the-maldridge
@ 2020-11-15 6:38 ` the-maldridge
3 siblings, 0 replies; 5+ messages in thread
From: the-maldridge @ 2020-11-15 6:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/26391#issuecomment-727524011
Comment:
That works too.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-15 6:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-15 6:35 [PR PATCH] grafana: Create /var/log/grafana on install Goorzhel
2020-11-15 6:37 ` Goorzhel
2020-11-15 6:37 ` [PR PATCH] [Closed]: " Goorzhel
2020-11-15 6:37 ` [PR REVIEW] " the-maldridge
2020-11-15 6:38 ` the-maldridge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).