Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: fuzzypkg-1.0.0
@ 2020-10-09 22:16 zdykstra
  2020-10-09 22:31 ` [PR REVIEW] " ericonr
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: zdykstra @ 2020-10-09 22:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

There is a new pull request by zdykstra against master on the void-packages repository

https://github.com/zdykstra/void-packages fuzzypkg-v1.0.0
https://github.com/void-linux/void-packages/pull/25481

New package: fuzzypkg-1.0.0


A patch file from https://github.com/void-linux/void-packages/pull/25481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fuzzypkg-v1.0.0-25481.patch --]
[-- Type: text/x-diff, Size: 1128 bytes --]

From c3aeffb8b62d7fbd82a2852d755a458aea97e7bc Mon Sep 17 00:00:00 2001
From: Zach Dykstra <dykstra.zachary@gmail.com>
Date: Fri, 9 Oct 2020 16:46:48 -0500
Subject: [PATCH] New package: fuzzypkg-1.0.0

---
 srcpkgs/fuzzypkg/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/fuzzypkg/template

diff --git a/srcpkgs/fuzzypkg/template b/srcpkgs/fuzzypkg/template
new file mode 100644
index 00000000000..e82b1cfca2e
--- /dev/null
+++ b/srcpkgs/fuzzypkg/template
@@ -0,0 +1,25 @@
+# Template file for 'fuzzypkg'
+pkgname=fuzzypkg
+version=1.0.0
+revision=1
+depends="bash"
+short_desc="XBPS fuzzy package manager"
+maintainer="Zach Dykstra <dykstra.zachary@gmail.com>"
+license="MIT"
+homepage="https://github.com/zdykstra/fuzzypkg"
+distfiles="https://github.com/zdykstra/fuzzypkg/archive/v${version}.tar.gz"
+checksum=1c62aaaf9d86dcc8bbe1bbac5b97bb18b38f6ea67f2ed8848ab2a8d2622a648f
+
+case "$XBPS_TARGET_MACHINE" in
+	x86_64*|i686*|armv[67]*|aarch64*|ppc64le*)
+		depends+=" fzf"
+		;;
+	*)
+		depends+=" skim"
+		;;
+esac
+
+do_install() {
+	vlicense LICENSE
+	vbin fuzzypkg
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: fuzzypkg-1.0.0
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
@ 2020-10-09 22:31 ` ericonr
  2020-10-10  0:46 ` q66
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2020-10-09 22:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25481#discussion_r502694724

Comment:
This is logic that's also present in the `zfsbootmenu` template, and the `void-docs-browse` one could also take advantage of it. Unless we can make virtual packages work well for cases where one of the packages isn't available on a platform (can we?), I think there should be a `void-fuzzy-finder` metapackage or similar.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New package: fuzzypkg-1.0.0
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
  2020-10-09 22:31 ` [PR REVIEW] " ericonr
@ 2020-10-10  0:46 ` q66
  2020-10-10  1:07 ` zdykstra
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: q66 @ 2020-10-10  0:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25481#issuecomment-706457170

Comment:
it has previously been decided that simple bash scripts are not a target for packaging and people should just fetch them themselves instead of cluttering xbps-src with it

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New package: fuzzypkg-1.0.0
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
  2020-10-09 22:31 ` [PR REVIEW] " ericonr
  2020-10-10  0:46 ` q66
@ 2020-10-10  1:07 ` zdykstra
  2020-10-10  1:17 ` q66
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: zdykstra @ 2020-10-10  1:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/25481#issuecomment-706460392

Comment:
That seems pretty arbitrary. There are a multitude of 'simple bash scripts' packaged in xbps-src - including `vsv` and `vpm` - that are Void-specific tools. Why force people, using Void, to use another installation mechanism for a tool that will only ever be used on Void?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New package: fuzzypkg-1.0.0
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
                   ` (2 preceding siblings ...)
  2020-10-10  1:07 ` zdykstra
@ 2020-10-10  1:17 ` q66
  2020-10-10  2:34 ` [PR PATCH] [Updated] " zdykstra
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: q66 @ 2020-10-10  1:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25481#issuecomment-706461868

Comment:
I haven't made up those rules, just pointing that out, since other stuff has been rejected on this basis before

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] New package: fuzzypkg-1.0.0
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
                   ` (3 preceding siblings ...)
  2020-10-10  1:17 ` q66
@ 2020-10-10  2:34 ` zdykstra
  2020-10-10  3:32 ` [PR REVIEW] New package: fuzzypkg-1.0.1 q66
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: zdykstra @ 2020-10-10  2:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

There is an updated pull request by zdykstra against master on the void-packages repository

https://github.com/zdykstra/void-packages fuzzypkg-v1.0.0
https://github.com/void-linux/void-packages/pull/25481

New package: fuzzypkg-1.0.0


A patch file from https://github.com/void-linux/void-packages/pull/25481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fuzzypkg-v1.0.0-25481.patch --]
[-- Type: text/x-diff, Size: 1128 bytes --]

From a7daa69a6bc5f70bfafa2075b0d204d1f76f6f42 Mon Sep 17 00:00:00 2001
From: Zach Dykstra <dykstra.zachary@gmail.com>
Date: Fri, 9 Oct 2020 16:46:48 -0500
Subject: [PATCH] New package: fuzzypkg-1.0.1

---
 srcpkgs/fuzzypkg/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/fuzzypkg/template

diff --git a/srcpkgs/fuzzypkg/template b/srcpkgs/fuzzypkg/template
new file mode 100644
index 00000000000..ac42f3e08ab
--- /dev/null
+++ b/srcpkgs/fuzzypkg/template
@@ -0,0 +1,25 @@
+# Template file for 'fuzzypkg'
+pkgname=fuzzypkg
+version=1.0.1
+revision=1
+depends="bash"
+short_desc="XBPS fuzzy package manager"
+maintainer="Zach Dykstra <dykstra.zachary@gmail.com>"
+license="MIT"
+homepage="https://github.com/zdykstra/fuzzypkg"
+distfiles="https://github.com/zdykstra/fuzzypkg/archive/v${version}.tar.gz"
+checksum=4e1d2f80d926bead92540294a20ca65b577259b5cc4b659d7118b0896e1e0b84
+
+case "$XBPS_TARGET_MACHINE" in
+	x86_64*|i686*|armv[67]*|aarch64*|ppc64le*)
+		depends+=" fzf"
+		;;
+	*)
+		depends+=" skim"
+		;;
+esac
+
+do_install() {
+	vlicense LICENSE
+	vbin fuzzypkg
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: fuzzypkg-1.0.1
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
                   ` (4 preceding siblings ...)
  2020-10-10  2:34 ` [PR PATCH] [Updated] " zdykstra
@ 2020-10-10  3:32 ` q66
  2020-10-10  3:48 ` zdykstra
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: q66 @ 2020-10-10  3:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25481#discussion_r502740334

Comment:
this is not resolved, as was mentioned on IRC, the dependency should be unconditionally `skim` (same in `zfsbootmenu`) and if people want `fzf`, they should install it themselves

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: fuzzypkg-1.0.1
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
                   ` (5 preceding siblings ...)
  2020-10-10  3:32 ` [PR REVIEW] New package: fuzzypkg-1.0.1 q66
@ 2020-10-10  3:48 ` zdykstra
  2020-10-10  3:52 ` q66
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: zdykstra @ 2020-10-10  3:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

New review comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/25481#discussion_r502741477

Comment:
What is the reasoning behind that? `skim` isn't feature-for-feature compatible with `fzf`. There are distinct things that it can't do. I don't understand why the default experience for everybody should be degraded to the lowest common denominator.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: fuzzypkg-1.0.1
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
                   ` (6 preceding siblings ...)
  2020-10-10  3:48 ` zdykstra
@ 2020-10-10  3:52 ` q66
  2020-10-10  4:45 ` [PR PATCH] [Updated] " zdykstra
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: q66 @ 2020-10-10  3:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25481#discussion_r502741823

Comment:
it already checks for both either way and they don't conflict when installed on the same system, so unless there is something *really* important that `fzf` can do and `skim` can't, i see no reason to make arbitrary target-specific distinctions when a portable implementation already exists

there is no degrading everybody's experience, since those who need the features can just install `fzf` manually and be done with it

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] New package: fuzzypkg-1.0.1
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
                   ` (7 preceding siblings ...)
  2020-10-10  3:52 ` q66
@ 2020-10-10  4:45 ` zdykstra
  2020-10-10  5:22 ` [PR REVIEW] New package: fuzzypkg-1.0.2 zdykstra
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: zdykstra @ 2020-10-10  4:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

There is an updated pull request by zdykstra against master on the void-packages repository

https://github.com/zdykstra/void-packages fuzzypkg-v1.0.0
https://github.com/void-linux/void-packages/pull/25481

New package: fuzzypkg-1.0.1


A patch file from https://github.com/void-linux/void-packages/pull/25481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fuzzypkg-v1.0.0-25481.patch --]
[-- Type: text/x-diff, Size: 1128 bytes --]

From 7c6bbfd94a699f31bb35dcf9a2c053f859383165 Mon Sep 17 00:00:00 2001
From: Zach Dykstra <dykstra.zachary@gmail.com>
Date: Fri, 9 Oct 2020 16:46:48 -0500
Subject: [PATCH] New package: fuzzypkg-1.0.2

---
 srcpkgs/fuzzypkg/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/fuzzypkg/template

diff --git a/srcpkgs/fuzzypkg/template b/srcpkgs/fuzzypkg/template
new file mode 100644
index 00000000000..6243aa202a7
--- /dev/null
+++ b/srcpkgs/fuzzypkg/template
@@ -0,0 +1,25 @@
+# Template file for 'fuzzypkg'
+pkgname=fuzzypkg
+version=1.0.2
+revision=1
+depends="bash"
+short_desc="XBPS fuzzy package manager"
+maintainer="Zach Dykstra <dykstra.zachary@gmail.com>"
+license="MIT"
+homepage="https://github.com/zdykstra/fuzzypkg"
+distfiles="https://github.com/zdykstra/fuzzypkg/archive/v${version}.tar.gz"
+checksum=f9aa5bd0d679f43d7d78654ba579fa460c5625b4504c4221a35a90623d59d90f
+
+case "$XBPS_TARGET_MACHINE" in
+	x86_64*|i686*|armv[67]*|aarch64*|ppc64le*)
+		depends+=" fzf"
+		;;
+	*)
+		depends+=" skim"
+		;;
+esac
+
+do_install() {
+	vlicense LICENSE
+	vbin fuzzypkg
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: fuzzypkg-1.0.2
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
                   ` (8 preceding siblings ...)
  2020-10-10  4:45 ` [PR PATCH] [Updated] " zdykstra
@ 2020-10-10  5:22 ` zdykstra
  2020-10-10 14:45 ` q66
  2020-11-22  3:27 ` [PR PATCH] [Merged]: " the-maldridge
  11 siblings, 0 replies; 13+ messages in thread
From: zdykstra @ 2020-10-10  5:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

New review comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/25481#discussion_r502748720

Comment:
I'm not trying to be difficult here. I just haven't seen a reasonable technical argument against changing run-time depends based on availability. 

It's obviously not an issue to have both `skim` and `fzf` installed - upstream (in this case, me) prefers the usage of `fzf` where possible. Since you're now putting me in the position of having to meet someones definition of *something really important*, I don't know what else to say. I simply wanted to contribute a tool that I thought would be useful.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: fuzzypkg-1.0.2
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
                   ` (9 preceding siblings ...)
  2020-10-10  5:22 ` [PR REVIEW] New package: fuzzypkg-1.0.2 zdykstra
@ 2020-10-10 14:45 ` q66
  2020-11-22  3:27 ` [PR PATCH] [Merged]: " the-maldridge
  11 siblings, 0 replies; 13+ messages in thread
From: q66 @ 2020-10-10 14:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25481#discussion_r502797946

Comment:
presenting some good arguments *for* having the platform distinctions rather than using a single portable implementation by default would be a good start

i'm not going to be using this and have no experience with either fzf or skim, so i don't know what differences there are, that's why i'm asking you to make your case

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Merged]: New package: fuzzypkg-1.0.2
  2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
                   ` (10 preceding siblings ...)
  2020-10-10 14:45 ` q66
@ 2020-11-22  3:27 ` the-maldridge
  11 siblings, 0 replies; 13+ messages in thread
From: the-maldridge @ 2020-11-22  3:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

There's a merged pull request on the void-packages repository

New package: fuzzypkg-1.0.2
https://github.com/void-linux/void-packages/pull/25481

Description:


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2020-11-22  3:27 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09 22:16 [PR PATCH] New package: fuzzypkg-1.0.0 zdykstra
2020-10-09 22:31 ` [PR REVIEW] " ericonr
2020-10-10  0:46 ` q66
2020-10-10  1:07 ` zdykstra
2020-10-10  1:17 ` q66
2020-10-10  2:34 ` [PR PATCH] [Updated] " zdykstra
2020-10-10  3:32 ` [PR REVIEW] New package: fuzzypkg-1.0.1 q66
2020-10-10  3:48 ` zdykstra
2020-10-10  3:52 ` q66
2020-10-10  4:45 ` [PR PATCH] [Updated] " zdykstra
2020-10-10  5:22 ` [PR REVIEW] New package: fuzzypkg-1.0.2 zdykstra
2020-10-10 14:45 ` q66
2020-11-22  3:27 ` [PR PATCH] [Merged]: " the-maldridge

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git