* Re: c-ares: update to 1.17.1.
2020-11-20 21:14 [PR PATCH] c-ares: update to 1.17.1 ailiop-git
@ 2020-11-23 5:41 ` ericonr
2020-11-23 5:42 ` [PR REVIEW] " ericonr
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-11-23 5:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26534#issuecomment-731938664
Comment:
Please add a changelog: https://c-ares.haxx.se/changelog.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR REVIEW] c-ares: update to 1.17.1.
2020-11-20 21:14 [PR PATCH] c-ares: update to 1.17.1 ailiop-git
2020-11-23 5:41 ` ericonr
@ 2020-11-23 5:42 ` ericonr
2020-11-23 9:48 ` [PR PATCH] [Updated] " ailiop-git
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-11-23 5:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26534#discussion_r528480829
Comment:
You can remove this case and make it unconditional, I think. We always set `FORTIFY_SOURCE`
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] c-ares: update to 1.17.1.
2020-11-20 21:14 [PR PATCH] c-ares: update to 1.17.1 ailiop-git
2020-11-23 5:41 ` ericonr
2020-11-23 5:42 ` [PR REVIEW] " ericonr
@ 2020-11-23 9:48 ` ailiop-git
2020-11-23 16:18 ` [PR REVIEW] " ericonr
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ailiop-git @ 2020-11-23 9:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
There is an updated pull request by ailiop-git against master on the void-packages repository
https://github.com/ailiop-git/void-packages c-ares
https://github.com/void-linux/void-packages/pull/26534
c-ares: update to 1.17.1.
A patch file from https://github.com/void-linux/void-packages/pull/26534.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-c-ares-26534.patch --]
[-- Type: text/x-diff, Size: 1431 bytes --]
From da9739585ec32a04ae26bde7f071091b114baf20 Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Mon, 23 Nov 2020 10:47:50 +0100
Subject: [PATCH] c-ares: update to 1.17.1.
---
srcpkgs/c-ares/template | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/srcpkgs/c-ares/template b/srcpkgs/c-ares/template
index e1849f9b3c0..fa01c288cbe 100644
--- a/srcpkgs/c-ares/template
+++ b/srcpkgs/c-ares/template
@@ -1,22 +1,19 @@
# Template file for 'c-ares'
pkgname=c-ares
-version=1.16.1
+version=1.17.1
revision=1
build_style=gnu-configure
short_desc="C library that performs DNS requests and name resolves asynchronously"
maintainer="Orphaned <orphan@voidlinux.org>"
license="MIT"
homepage="https://c-ares.haxx.se/"
-distfiles="https://c-ares.haxx.se/download/${pkgname}-${version}.tar.gz"
-checksum=d08312d0ecc3bd48eee0a4cc0d2137c9f194e0a28de2028928c0f6cae85f86ce
+changelog="${homepage}/changelog.html"
+distfiles="${homepage}/download/${pkgname}-${version}.tar.gz"
+checksum=d73dd0f6de824afd407ce10750ea081af47eba52b8a6cb307d220131ad93fc40
pre_configure() {
- case "$CFLAGS" in
- *"-D_FORTIFY_SOURCE=2"*)
- export CFLAGS=${CFLAGS/-D_FORTIFY_SOURCE=?/}
- export CPPFLAGS+=" -D_FORTIFY_SOURCE=2"
- ;;
- esac
+ export CFLAGS=${CFLAGS/-D_FORTIFY_SOURCE=?/}
+ export CPPFLAGS+=" -D_FORTIFY_SOURCE=2"
export CFLAGS=${CFLAGS/-I${XBPS_CROSS_BASE}\/usr\/include/}
}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR REVIEW] c-ares: update to 1.17.1.
2020-11-20 21:14 [PR PATCH] c-ares: update to 1.17.1 ailiop-git
` (2 preceding siblings ...)
2020-11-23 9:48 ` [PR PATCH] [Updated] " ailiop-git
@ 2020-11-23 16:18 ` ericonr
2020-11-23 16:24 ` [PR PATCH] [Updated] " ailiop-git
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-11-23 16:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26534#discussion_r528827836
Comment:
Put the link without any variables, it's good to be able to copy and paste it directly from the template into a browser.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] c-ares: update to 1.17.1.
2020-11-20 21:14 [PR PATCH] c-ares: update to 1.17.1 ailiop-git
` (3 preceding siblings ...)
2020-11-23 16:18 ` [PR REVIEW] " ericonr
@ 2020-11-23 16:24 ` ailiop-git
2020-11-23 16:31 ` [PR REVIEW] " ailiop-git
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ailiop-git @ 2020-11-23 16:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
There is an updated pull request by ailiop-git against master on the void-packages repository
https://github.com/ailiop-git/void-packages c-ares
https://github.com/void-linux/void-packages/pull/26534
c-ares: update to 1.17.1.
A patch file from https://github.com/void-linux/void-packages/pull/26534.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-c-ares-26534.patch --]
[-- Type: text/x-diff, Size: 1442 bytes --]
From f012a51b9c689ff45aa63effba45c7999c6acc48 Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Mon, 23 Nov 2020 17:24:10 +0100
Subject: [PATCH] c-ares: update to 1.17.1.
---
srcpkgs/c-ares/template | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/srcpkgs/c-ares/template b/srcpkgs/c-ares/template
index e1849f9b3c0..9f81b95462c 100644
--- a/srcpkgs/c-ares/template
+++ b/srcpkgs/c-ares/template
@@ -1,22 +1,19 @@
# Template file for 'c-ares'
pkgname=c-ares
-version=1.16.1
+version=1.17.1
revision=1
build_style=gnu-configure
short_desc="C library that performs DNS requests and name resolves asynchronously"
maintainer="Orphaned <orphan@voidlinux.org>"
license="MIT"
homepage="https://c-ares.haxx.se/"
-distfiles="https://c-ares.haxx.se/download/${pkgname}-${version}.tar.gz"
-checksum=d08312d0ecc3bd48eee0a4cc0d2137c9f194e0a28de2028928c0f6cae85f86ce
+changelog="https://c-ares.haxx.se/changelog.html"
+distfiles="${homepage}/download/${pkgname}-${version}.tar.gz"
+checksum=d73dd0f6de824afd407ce10750ea081af47eba52b8a6cb307d220131ad93fc40
pre_configure() {
- case "$CFLAGS" in
- *"-D_FORTIFY_SOURCE=2"*)
- export CFLAGS=${CFLAGS/-D_FORTIFY_SOURCE=?/}
- export CPPFLAGS+=" -D_FORTIFY_SOURCE=2"
- ;;
- esac
+ export CFLAGS=${CFLAGS/-D_FORTIFY_SOURCE=?/}
+ export CPPFLAGS+=" -D_FORTIFY_SOURCE=2"
export CFLAGS=${CFLAGS/-I${XBPS_CROSS_BASE}\/usr\/include/}
}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR REVIEW] c-ares: update to 1.17.1.
2020-11-20 21:14 [PR PATCH] c-ares: update to 1.17.1 ailiop-git
` (4 preceding siblings ...)
2020-11-23 16:24 ` [PR PATCH] [Updated] " ailiop-git
@ 2020-11-23 16:31 ` ailiop-git
2020-11-23 19:40 ` ericonr
2020-11-23 20:16 ` [PR PATCH] [Merged]: " ericonr
7 siblings, 0 replies; 9+ messages in thread
From: ailiop-git @ 2020-11-23 16:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
New review comment by ailiop-git on void-packages repository
https://github.com/void-linux/void-packages/pull/26534#discussion_r528837082
Comment:
It crossed my mind but I wasn't sure if anyone is accessing this "manually" from the template (vs. xbps-query or xbps-src), but sounds reasonable.
BTW it may worth codifying those kind of stylistic preferences within the manual, as well as xlint.
thanks for the reviews!
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR REVIEW] c-ares: update to 1.17.1.
2020-11-20 21:14 [PR PATCH] c-ares: update to 1.17.1 ailiop-git
` (5 preceding siblings ...)
2020-11-23 16:31 ` [PR REVIEW] " ailiop-git
@ 2020-11-23 19:40 ` ericonr
2020-11-23 20:16 ` [PR PATCH] [Merged]: " ericonr
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-11-23 19:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26534#discussion_r528951458
Comment:
Indeed, it would make sense. Feel free to open a PR / issue about it, otherwise I will try to get to it.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Merged]: c-ares: update to 1.17.1.
2020-11-20 21:14 [PR PATCH] c-ares: update to 1.17.1 ailiop-git
` (6 preceding siblings ...)
2020-11-23 19:40 ` ericonr
@ 2020-11-23 20:16 ` ericonr
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-11-23 20:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
There's a merged pull request on the void-packages repository
c-ares: update to 1.17.1.
https://github.com/void-linux/void-packages/pull/26534
Description:
^ permalink raw reply [flat|nested] 9+ messages in thread