* Re: [PR REVIEW] sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
@ 2020-12-01 11:12 ` Piraty
2020-12-01 19:57 ` [PR PATCH] [Updated] " ndowens
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Piraty @ 2020-12-01 11:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/26851#discussion_r533328129
Comment:
please align with what qt5-webengine's template actually does to limit building on arm
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
2020-12-01 11:12 ` [PR REVIEW] " Piraty
@ 2020-12-01 19:57 ` ndowens
2020-12-01 19:57 ` [PR REVIEW] " ndowens
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ndowens @ 2020-12-01 19:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
There is an updated pull request by ndowens against master on the void-packages repository
https://github.com/ndowens/void-packages sigil
https://github.com/void-linux/void-packages/pull/26851
sigil: update to 1.4.2
A patch file from https://github.com/void-linux/void-packages/pull/26851.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sigil-26851.patch --]
[-- Type: text/x-diff, Size: 1563 bytes --]
From b943d9a3745146f5c77decd7045f99a65e676b90 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Mon, 30 Nov 2020 19:30:22 -0600
Subject: [PATCH] sigil: update to 1.4.2
---
srcpkgs/sigil/template | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/sigil/template b/srcpkgs/sigil/template
index 0fecc98fba7..3e20001a9e1 100644
--- a/srcpkgs/sigil/template
+++ b/srcpkgs/sigil/template
@@ -1,6 +1,6 @@
# Template file for 'sigil'
pkgname=sigil
-version=1.4.1
+version=1.4.2
revision=1
wrksrc="Sigil-${version}"
build_style=cmake
@@ -19,16 +19,19 @@ maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="https://github.com/Sigil-Ebook/Sigil"
distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=8e4919bde7b0e530e12a6feb8956e92e662270187d924a0102e505e942acacb1
+checksum=e31b7c84507ffe9ca896d8a169867923d3274c02d957bd59e5c6b1fd12b5e4c8
python_version=3
-case "$XBPS_TARGET_MACHINE" in
- arm*) broken="depends on qt5-webengine";;
-esac
-
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" qt5-host-tools qt5-tools-devel qt5-svg-devel
qt5-webengine-devel qt5-xmlpatterns-devel qt5-multimedia-devel
qt5-sensors-devel qt5-declarative-devel qt5-location-devel
qt5-webchannel-devel python3-devel"
fi
+
+if [ ! "$XBPS_WORDSIZE" = "$XBPS_TARGET_WORDSIZE" ]; then
+ broken="qt5-webengine dependency can be built only if word size matches"
+elif [ "$XBPS_TARGET_ENDIAN" != "le" ]; then
+ broken="qt5-webengine dependency only supports little endian"
+fi
+
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
2020-12-01 11:12 ` [PR REVIEW] " Piraty
2020-12-01 19:57 ` [PR PATCH] [Updated] " ndowens
@ 2020-12-01 19:57 ` ndowens
2020-12-01 20:04 ` ericonr
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ndowens @ 2020-12-01 19:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New review comment by ndowens on void-packages repository
https://github.com/void-linux/void-packages/pull/26851#discussion_r533683262
Comment:
Updated, is the change ok?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
` (2 preceding siblings ...)
2020-12-01 19:57 ` [PR REVIEW] " ndowens
@ 2020-12-01 20:04 ` ericonr
2020-12-01 20:11 ` ndowens
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-01 20:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26851#discussion_r533687281
Comment:
Shouldn't it fail to build automatically once `qt5-webengine-devel` can't be found as a `makedepends`?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
` (3 preceding siblings ...)
2020-12-01 20:04 ` ericonr
@ 2020-12-01 20:11 ` ndowens
2020-12-01 20:28 ` ericonr
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ndowens @ 2020-12-01 20:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
New review comment by ndowens on void-packages repository
https://github.com/void-linux/void-packages/pull/26851#discussion_r533691236
Comment:
@ericonr Correct, it does without adding anything. Normal xbps behavior
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
` (4 preceding siblings ...)
2020-12-01 20:11 ` ndowens
@ 2020-12-01 20:28 ` ericonr
2020-12-01 20:30 ` [PR PATCH] [Updated] " ndowens
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-01 20:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26851#discussion_r533700784
Comment:
I don't see why it needs "broken", then.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
` (5 preceding siblings ...)
2020-12-01 20:28 ` ericonr
@ 2020-12-01 20:30 ` ndowens
2020-12-01 20:31 ` [PR REVIEW] " ndowens
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ndowens @ 2020-12-01 20:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
There is an updated pull request by ndowens against master on the void-packages repository
https://github.com/ndowens/void-packages sigil
https://github.com/void-linux/void-packages/pull/26851
sigil: update to 1.4.2
A patch file from https://github.com/void-linux/void-packages/pull/26851.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sigil-26851.patch --]
[-- Type: text/x-diff, Size: 1197 bytes --]
From 4ea89dd16debe4b0664055ef292a1fe752783d0e Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Mon, 30 Nov 2020 19:30:22 -0600
Subject: [PATCH] sigil: update to 1.4.2
---
srcpkgs/sigil/template | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/sigil/template b/srcpkgs/sigil/template
index 0fecc98fba7..b0b614759ac 100644
--- a/srcpkgs/sigil/template
+++ b/srcpkgs/sigil/template
@@ -1,6 +1,6 @@
# Template file for 'sigil'
pkgname=sigil
-version=1.4.1
+version=1.4.2
revision=1
wrksrc="Sigil-${version}"
build_style=cmake
@@ -19,13 +19,9 @@ maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
homepage="https://github.com/Sigil-Ebook/Sigil"
distfiles="${homepage}/archive/${version}.tar.gz"
-checksum=8e4919bde7b0e530e12a6feb8956e92e662270187d924a0102e505e942acacb1
+checksum=e31b7c84507ffe9ca896d8a169867923d3274c02d957bd59e5c6b1fd12b5e4c8
python_version=3
-case "$XBPS_TARGET_MACHINE" in
- arm*) broken="depends on qt5-webengine";;
-esac
-
if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" qt5-host-tools qt5-tools-devel qt5-svg-devel
qt5-webengine-devel qt5-xmlpatterns-devel qt5-multimedia-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
` (6 preceding siblings ...)
2020-12-01 20:30 ` [PR PATCH] [Updated] " ndowens
@ 2020-12-01 20:31 ` ndowens
2020-12-07 9:25 ` Piraty
2020-12-20 3:43 ` [PR PATCH] [Merged]: " ericonr
9 siblings, 0 replies; 11+ messages in thread
From: ndowens @ 2020-12-01 20:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
New review comment by ndowens on void-packages repository
https://github.com/void-linux/void-packages/pull/26851#discussion_r533702307
Comment:
@ericonr Removed broken in this update.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
` (7 preceding siblings ...)
2020-12-01 20:31 ` [PR REVIEW] " ndowens
@ 2020-12-07 9:25 ` Piraty
2020-12-20 3:43 ` [PR PATCH] [Merged]: " ericonr
9 siblings, 0 replies; 11+ messages in thread
From: Piraty @ 2020-12-07 9:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/26851#discussion_r537351631
Comment:
@ericonr i think some maintainers like it that way as the builders bail out early and more verbose this way.
Fine with me though
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Merged]: sigil: update to 1.4.2
2020-12-01 1:29 [PR PATCH] sigil: update to 1.4.2 ndowens
` (8 preceding siblings ...)
2020-12-07 9:25 ` Piraty
@ 2020-12-20 3:43 ` ericonr
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-20 3:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
There's a merged pull request on the void-packages repository
sigil: update to 1.4.2
https://github.com/void-linux/void-packages/pull/26851
Description:
^ permalink raw reply [flat|nested] 11+ messages in thread