* Re: polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
@ 2020-12-02 18:46 ` ericonr
2020-12-02 18:47 ` pbui
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-02 18:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26887#issuecomment-737423484
Comment:
It's gonna need `libatomic` :)
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
2020-12-02 18:46 ` ericonr
@ 2020-12-02 18:47 ` pbui
2020-12-02 18:49 ` ericonr
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pbui @ 2020-12-02 18:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New comment by pbui on void-packages repository
https://github.com/void-linux/void-packages/pull/26887#issuecomment-737424003
Comment:
Yeah, I just saw that... What is the best way to handle that?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
2020-12-02 18:46 ` ericonr
2020-12-02 18:47 ` pbui
@ 2020-12-02 18:49 ` ericonr
2020-12-02 18:50 ` ericonr
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-02 18:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26887#issuecomment-737425049
Comment:
Check for `XBPS_TARGET_NO_ATOMIC8` and add `makedepends+=" libatomic-devel"`. If you're lucky it just works; otherwise you'll need to add `LDFLAGS` or `LDLIBS` that are `=-latomic`.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
` (2 preceding siblings ...)
2020-12-02 18:49 ` ericonr
@ 2020-12-02 18:50 ` ericonr
2020-12-02 18:59 ` [PR PATCH] [Updated] " pbui
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-02 18:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26887#issuecomment-737425049
Comment:
Check for `XBPS_TARGET_NO_ATOMIC8` and add `makedepends+=" libatomic-devel"`. If you're lucky it just works; otherwise you'll need to add `LDFLAGS` or `LDLIBS` that are `=-latomic`.
Actually no, it's cmake. If just adding `libatomic-devel` isn't enough, use `-DCMAKE_(CXX|C)_STANDARD_LIBRARIES=-latomic` (idk if it's C or C++).
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
` (3 preceding siblings ...)
2020-12-02 18:50 ` ericonr
@ 2020-12-02 18:59 ` pbui
2020-12-02 19:08 ` pbui
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pbui @ 2020-12-02 18:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
There is an updated pull request by pbui against master on the void-packages repository
https://github.com/pbui/void-packages polybar
https://github.com/void-linux/void-packages/pull/26887
polybar: update to 3.5.0.
A patch file from https://github.com/void-linux/void-packages/pull/26887.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-polybar-26887.patch --]
[-- Type: text/x-diff, Size: 1538 bytes --]
From d34d5c593a20813d3daff189da06840d6aa6ab4d Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 2 Dec 2020 13:30:06 -0500
Subject: [PATCH] polybar: update to 3.5.0.
- Add workaround for missing libatomic on armv6l.
---
srcpkgs/polybar/template | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/polybar/template b/srcpkgs/polybar/template
index 12f488a9cad..e4028515309 100644
--- a/srcpkgs/polybar/template
+++ b/srcpkgs/polybar/template
@@ -1,7 +1,7 @@
# Template file for 'polybar'
pkgname=polybar
-version=3.4.3
-revision=2
+version=3.5.0
+revision=1
wrksrc="$pkgname"
build_style=cmake
configure_args="
@@ -26,7 +26,7 @@ maintainer="Michael Carlberg <c@rlberg.se>"
license="MIT"
homepage="https://github.com/jaagr/polybar"
distfiles="https://github.com/jaagr/polybar/releases/download/${version}/polybar-${version}.tar"
-checksum=d4ed121c1d3960493f8268f966d65a94d94c4646a4abb131687e37b63616822f
+checksum=e8c1798c195854852fc7c99703287294123381101b371f171d4aa540aeb17afd
build_options="alsa curl i3 mpd network pulseaudio"
build_options_default="$build_options"
@@ -46,6 +46,11 @@ if [ "$build_option_network" ]; then
esac
fi
+if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
+ makedepends+=" libatomic-devel"
+ configure_args+=" -DCMAKE_EXE_LINKER_FLAGS='-latomic'"
+fi
+
post_extract() {
# Fixes compilation with musl
sed -i 's|strncpy(header->magic, g_i3_ipc_magic.c_str(),|memcpy(header->magic, g_i3_ipc_magic.c_str(),|g' lib/i3ipcpp/src/ipc-util.cpp
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
` (4 preceding siblings ...)
2020-12-02 18:59 ` [PR PATCH] [Updated] " pbui
@ 2020-12-02 19:08 ` pbui
2020-12-02 19:13 ` [PR REVIEW] " ericonr
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pbui @ 2020-12-02 19:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New comment by pbui on void-packages repository
https://github.com/void-linux/void-packages/pull/26887#issuecomment-737435391
Comment:
Ok, I added the same workaround/fix as was used in `musikcube`.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
` (5 preceding siblings ...)
2020-12-02 19:08 ` pbui
@ 2020-12-02 19:13 ` ericonr
2020-12-02 19:17 ` [PR PATCH] [Updated] " pbui
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-02 19:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26887#discussion_r534417322
Comment:
Linker flags aren't the same as libraries the binary is linked against. If it works, I'd prefer to use `STANDARD_LIBRARIES`.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
` (6 preceding siblings ...)
2020-12-02 19:13 ` [PR REVIEW] " ericonr
@ 2020-12-02 19:17 ` pbui
2020-12-02 19:18 ` [PR REVIEW] " pbui
2020-12-02 19:32 ` [PR PATCH] [Merged]: " ericonr
9 siblings, 0 replies; 11+ messages in thread
From: pbui @ 2020-12-02 19:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
There is an updated pull request by pbui against master on the void-packages repository
https://github.com/pbui/void-packages polybar
https://github.com/void-linux/void-packages/pull/26887
polybar: update to 3.5.0.
A patch file from https://github.com/void-linux/void-packages/pull/26887.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-polybar-26887.patch --]
[-- Type: text/x-diff, Size: 1544 bytes --]
From 707bfa8e68a0c98aad828eb75c1052854b1db5bc Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Wed, 2 Dec 2020 13:30:06 -0500
Subject: [PATCH] polybar: update to 3.5.0.
- Add workaround for missing libatomic on armv6l.
---
srcpkgs/polybar/template | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/polybar/template b/srcpkgs/polybar/template
index 12f488a9cad..77ef6866329 100644
--- a/srcpkgs/polybar/template
+++ b/srcpkgs/polybar/template
@@ -1,7 +1,7 @@
# Template file for 'polybar'
pkgname=polybar
-version=3.4.3
-revision=2
+version=3.5.0
+revision=1
wrksrc="$pkgname"
build_style=cmake
configure_args="
@@ -26,7 +26,7 @@ maintainer="Michael Carlberg <c@rlberg.se>"
license="MIT"
homepage="https://github.com/jaagr/polybar"
distfiles="https://github.com/jaagr/polybar/releases/download/${version}/polybar-${version}.tar"
-checksum=d4ed121c1d3960493f8268f966d65a94d94c4646a4abb131687e37b63616822f
+checksum=e8c1798c195854852fc7c99703287294123381101b371f171d4aa540aeb17afd
build_options="alsa curl i3 mpd network pulseaudio"
build_options_default="$build_options"
@@ -46,6 +46,11 @@ if [ "$build_option_network" ]; then
esac
fi
+if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
+ makedepends+=" libatomic-devel"
+ configure_args+=" -DCMAKE_CXX_STANDARD_LIBRARIES='-latomic'"
+fi
+
post_extract() {
# Fixes compilation with musl
sed -i 's|strncpy(header->magic, g_i3_ipc_magic.c_str(),|memcpy(header->magic, g_i3_ipc_magic.c_str(),|g' lib/i3ipcpp/src/ipc-util.cpp
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
` (7 preceding siblings ...)
2020-12-02 19:17 ` [PR PATCH] [Updated] " pbui
@ 2020-12-02 19:18 ` pbui
2020-12-02 19:32 ` [PR PATCH] [Merged]: " ericonr
9 siblings, 0 replies; 11+ messages in thread
From: pbui @ 2020-12-02 19:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
New review comment by pbui on void-packages repository
https://github.com/void-linux/void-packages/pull/26887#discussion_r534420068
Comment:
Ok, I've pushed an update.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Merged]: polybar: update to 3.5.0.
2020-12-02 18:33 [PR PATCH] polybar: update to 3.5.0 pbui
` (8 preceding siblings ...)
2020-12-02 19:18 ` [PR REVIEW] " pbui
@ 2020-12-02 19:32 ` ericonr
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-12-02 19:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
There's a merged pull request on the void-packages repository
polybar: update to 3.5.0.
https://github.com/void-linux/void-packages/pull/26887
Description:
^ permalink raw reply [flat|nested] 11+ messages in thread