[PR PATCH] rng-tools: fix configure to work with new jitterentropy library.

[PR PATCH] rng-tools: fix configure to work with new jitterentropy library.

[lonwillett]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

There is a new pull request by lonwillett against master on the void-packages repository

https://github.com/lonwillett/void-packages rng-tools-new-jitterentropy-fix
https://github.com/void-linux/void-packages/pull/26933

rng-tools: fix configure to work with new jitterentropy library.
The recent update to the jitterentropy library broke rng-tools
configure. This patch fixes it. The source is the upstream commit:
https://github.com/nhorman/rng-tools/commit/daff4e2dd9d3abb74829f41e72607681163bd309.

A patch file from https://github.com/void-linux/void-packages/pull/26933.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rng-tools-new-jitterentropy-fix-26933.patch --]
[-- Type: text/x-diff, Size: 2095 bytes --]

From 6f0d1fb92041b5b2ee0534b1eb45178f2ba2097b Mon Sep 17 00:00:00 2001
From: Lon Willett <xgit@lonw.net>
Date: Fri, 4 Dec 2020 00:32:08 +0100
Subject: [PATCH] rng-tools: fix configure to work with new jitterentropy
 library.

The recent update to the jitterentropy library broke rng-tools
configure. This patch fixes it. The source is the upstream commit:
https://github.com/nhorman/rng-tools/commit/daff4e2dd9d3abb74829f41e72607681163bd309.
---
 ...configure-ac-jitterentropy-needs-pthread.patch | 15 +++++++++++++++
 srcpkgs/rng-tools/template                        |  2 +-
 2 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/rng-tools/patches/0004-configure-ac-jitterentropy-needs-pthread.patch

diff --git a/srcpkgs/rng-tools/patches/0004-configure-ac-jitterentropy-needs-pthread.patch b/srcpkgs/rng-tools/patches/0004-configure-ac-jitterentropy-needs-pthread.patch
new file mode 100644
index 00000000000..4e9147b3b5e
--- /dev/null
+++ b/srcpkgs/rng-tools/patches/0004-configure-ac-jitterentropy-needs-pthread.patch
@@ -0,0 +1,15 @@
+New jitterentropy library broke configure. This patch fixes it.
+
+Upstream patch: https://github.com/nhorman/rng-tools/commit/daff4e2dd9d3abb74829f41e72607681163bd309
+
+--- a/configure.ac	2020-12-03 20:59:11.086238518 +0100
++++ b/configure.ac	2020-12-03 21:00:40.978593727 +0100
+@@ -91,7 +91,7 @@
+ 		AC_SEARCH_LIBS(jent_version,jitterentropy,
+ 				[AM_CONDITIONAL([JITTER], [true])
+ 				AC_DEFINE([HAVE_JITTER],1,[Enable JITTER])],
+-				AC_MSG_NOTICE([No Jitterentropy library found]))
++				AC_MSG_NOTICE([No Jitterentropy library found]),-lpthread)
+ 	], [AC_MSG_NOTICE([Disabling JITTER entropy source])]
+ )
+ 
diff --git a/srcpkgs/rng-tools/template b/srcpkgs/rng-tools/template
index f81c9bf3d85..57f9cb42cf3 100644
--- a/srcpkgs/rng-tools/template
+++ b/srcpkgs/rng-tools/template
@@ -1,7 +1,7 @@
 # Template file for 'rng-tools'
 pkgname=rng-tools
 version=6.10
-revision=3
+revision=4
 wrksrc=${pkgname}-${version}
 build_style=gnu-configure
 configure_args="--sbindir=/usr/bin --without-pkcs11 --without-rtlsdr"

Re: [PR REVIEW] rng-tools: fix configure to work with new jitterentropy library.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26933#discussion_r535763610

Comment:
Is a revbump necessary? It depends on `jitterentropy` right now:

```
~ ➜ xbps-query -Rx rng-tools
musl>=1.1.21_1
libsysfs>=2.1.0_1
jitterentropy>=3.0.0_1
jansson>=2.4_1
libcurl>=7.19_1
libcrypto46>=3.1.1_1
```

Having the patch is good, I just want to avoid an unnecessary rebuild.

Re: [PR REVIEW] rng-tools: fix configure to work with new jitterentropy library.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26933#discussion_r535764136

Comment:
It is necessary! This issue doesn't happen on musl :) So the packages differ between the two libcs.

Re: [PR PATCH] [Merged]: rng-tools: fix configure to work with new jitterentropy library.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

There's a merged pull request on the void-packages repository

rng-tools: fix configure to work with new jitterentropy library.
https://github.com/void-linux/void-packages/pull/26933

Description:
The recent update to the jitterentropy library broke rng-tools
configure. This patch fixes it. The source is the upstream commit:
https://github.com/nhorman/rng-tools/commit/daff4e2dd9d3abb74829f41e72607681163bd309.