Re: [PR PATCH] [Updated] nethack: fix SYSCF_FILE location

[ashpooljh <ashpooljh@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

There is an updated pull request by ashpooljh against master on the void-packages repository

https://github.com/ashpooljh/void-packages nethack
https://github.com/void-linux/void-packages/pull/27036

nethack: fix SYSCF_FILE location
I wasn't able to enter the wizard mode, even as root, e.g. `sudo nethack -D -u wizard` just printed 
```
Entering explore/discovery mode instead
```
Then I found out that `SYSCF_FILE` in the template was pointing to the directory `/usr/lib/nethack` instead of the file itself `/usr/lib/nethack/sysconf`, and used `gdb` to verify that this had lead to `src/files.c:parse_conf_file` silently failing. Updating the value fixed the issue, and now the sysconf file is read and I'm able to access the wizard mode.

A patch file from https://github.com/void-linux/void-packages/pull/27036.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nethack-27036.patch --]
[-- Type: text/x-diff, Size: 1377 bytes --]

From 0e42d6d17607a60111023620901e8d92a15a2269 Mon Sep 17 00:00:00 2001
From: Artem Zhurikhin <ashpool@xecut.net>
Date: Tue, 8 Dec 2020 20:45:29 +0300
Subject: [PATCH] nethack: fix SYSCF_FILE location, fix xlint

---
 srcpkgs/nethack/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/nethack/template b/srcpkgs/nethack/template
index b7ec4c30753..ad86ceb288e 100644
--- a/srcpkgs/nethack/template
+++ b/srcpkgs/nethack/template
@@ -1,7 +1,8 @@
 # Template file for 'nethack'
 pkgname=nethack
 version=3.6.6
-revision=1
+revision=2
+wrksrc="NetHack-NetHack-${version}_Released"
 make_dirs="/var/games/nethack/save 0775 nethack nethack"
 hostmakedepends="ncurses-devel flex"
 depends="gzip"
@@ -13,7 +14,6 @@ distfiles="https://www.nethack.org/download/${version}/nethack-${version//./}-sr
 checksum=cfde0c3ab6dd7c22ae82e1e5a59ab80152304eb23fb06e3129439271e5643ed2
 nocross=yes
 system_accounts="$pkgname"
-wrksrc="NetHack-NetHack-${version}_Released"
 
 post_extract() {
 	sed -i	-e '/COMPRESS/s/compress/gzip/g' \
@@ -29,7 +29,7 @@ do_build() {
 		CC="$CC" LINK="$CC" LFLAGS="$LDFLAGS" \
 		LEX=flex WINTTYLIB=-lncurses \
 		CFLAGS="$CFLAGS -DLINUX -DTIMED_DELAY -DDLB \
-			-DSYSCF -DSYSCF_FILE='\"/usr/lib/nethack\"' \
+			-DSYSCF -DSYSCF_FILE='\"/usr/lib/nethack/sysconf\"' \
 			-DHACKDIR='\"/var/games/nethack\"' -I../include"
 }