From: ashpooljh <ashpooljh@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] nethack: fix SYSCF_FILE location
Date: Fri, 11 Dec 2020 17:06:26 +0100 [thread overview]
Message-ID: <20201211160626.oSjPk-9p9OiJ5Jk06EjLHJmT28k5Sz-lVlTQKCPyDRI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27036@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
New review comment by ashpooljh on void-packages repository
https://github.com/void-linux/void-packages/pull/27036#discussion_r541054340
Comment:
Yes, it took me a while to find and understand why this is needed. I will try to explain this in a separate message, but for now let me just point out that by applying this patch we are not actually _changing_ anything, but maintaining the previous behavior.
Revision 3.6.6_1 of the package does not define `SECURE`, in fact, it overrides all `CFLAGS` set in `sys/unix/hints/linux` and re-defines only a subset of them as an argument to `make all`, and `SECURE` is not there. When moving away from this approach (and thus applying all the `CFLAGS` from the hints file) I discovered that defining `SECURE` in our setup would break the package entirely.
next prev parent reply other threads:[~2020-12-11 16:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 17:54 [PR PATCH] " ashpooljh
2020-12-08 18:51 ` [PR PATCH] [Updated] " ashpooljh
2020-12-08 18:52 ` ashpooljh
2020-12-08 19:08 ` ashpooljh
2020-12-08 19:10 ` ashpooljh
2020-12-08 19:13 ` leahneukirchen
2020-12-08 19:16 ` leahneukirchen
2020-12-10 9:55 ` [PR PATCH] [Updated] " ashpooljh
2020-12-10 10:02 ` ashpooljh
2020-12-10 10:04 ` ashpooljh
2020-12-11 15:10 ` [PR REVIEW] " ericonr
2020-12-11 16:05 ` ashpooljh
2020-12-11 16:06 ` ashpooljh [this message]
2020-12-11 16:16 ` ericonr
2020-12-11 23:26 ` [PR PATCH] [Updated] " ashpooljh
2020-12-11 23:40 ` ashpooljh
2020-12-11 23:41 ` ashpooljh
2020-12-11 23:43 ` ashpooljh
2020-12-11 23:49 ` ashpooljh
2020-12-12 1:44 ` ericonr
2020-12-12 9:32 ` [PR PATCH] [Updated] " ashpooljh
2020-12-12 9:48 ` ashpooljh
2020-12-16 1:26 ` ericonr
2020-12-16 1:26 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211160626.oSjPk-9p9OiJ5Jk06EjLHJmT28k5Sz-lVlTQKCPyDRI@z \
--to=ashpooljh@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).