Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Added snapper missing dependency: dbus
@ 2020-12-09 15:13 Mek101
  2020-12-09 15:24 ` ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Mek101 @ 2020-12-09 15:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

There is a new pull request by Mek101 against master on the void-packages repository

https://github.com/Mek101/void-packages patch-1
https://github.com/void-linux/void-packages/pull/27049

Added snapper missing dependency: dbus
Snapper requires dbus to work, as reported in #27047

A patch file from https://github.com/void-linux/void-packages/pull/27049.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-27049.patch --]
[-- Type: text/x-diff, Size: 982 bytes --]

From 6fabffdee6d4d64188d0658bfdfb7018abc1b462 Mon Sep 17 00:00:00 2001
From: Mek101 <34246799+Mek101@users.noreply.github.com>
Date: Wed, 9 Dec 2020 15:12:10 +0000
Subject: [PATCH] Added dbus missing dependency

Snapper requires dbus to work, as reported in #27047
---
 srcpkgs/snapper/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/snapper/template b/srcpkgs/snapper/template
index 4590842eedd..694090f5a07 100644
--- a/srcpkgs/snapper/template
+++ b/srcpkgs/snapper/template
@@ -6,7 +6,7 @@ build_style=gnu-configure
 configure_args="--disable-zypp --with-conf=/etc/conf.d"
 conf_files="/etc/conf.d/snapper"
 make_dirs="/etc/snapper/configs 0755 root root"
-hostmakedepends="automake docbook-xsl libtool libxml2-devel libxslt
+hostmakedepends="automake dbus docbook-xsl libtool libxml2-devel libxslt
  gettext pkg-config"
 makedepends="acl-devel boost-devel dbus-devel e2fsprogs-devel libbtrfs-devel
  libmount-devel libxml2-devel pam-devel"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Added snapper missing dependency: dbus
  2020-12-09 15:13 [PR PATCH] Added snapper missing dependency: dbus Mek101
@ 2020-12-09 15:24 ` ericonr
  2020-12-09 16:10 ` [PR PATCH] [Updated] snapper: add dbus dependency Mek101
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-12-09 15:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27049#issuecomment-741842608

Comment:
The commit style is `snapper: add dbus dependency`

You need to increase the `revision` for this to build a new package, and `dbus` needs to go in `depends`. `hostmakedepends` and `makedepends` are build time only.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] snapper: add dbus dependency
  2020-12-09 15:13 [PR PATCH] Added snapper missing dependency: dbus Mek101
  2020-12-09 15:24 ` ericonr
@ 2020-12-09 16:10 ` Mek101
  2020-12-09 17:38 ` ericonr
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Mek101 @ 2020-12-09 16:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

There is an updated pull request by Mek101 against master on the void-packages repository

https://github.com/Mek101/void-packages patch-1
https://github.com/void-linux/void-packages/pull/27049

snapper: add dbus dependency
Snapper requires dbus to work, as reported in #27047

A patch file from https://github.com/void-linux/void-packages/pull/27049.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-27049.patch --]
[-- Type: text/x-diff, Size: 2271 bytes --]

From 6fabffdee6d4d64188d0658bfdfb7018abc1b462 Mon Sep 17 00:00:00 2001
From: Mek101 <34246799+Mek101@users.noreply.github.com>
Date: Wed, 9 Dec 2020 15:12:10 +0000
Subject: [PATCH 1/2] Added dbus missing dependency

Snapper requires dbus to work, as reported in #27047
---
 srcpkgs/snapper/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/snapper/template b/srcpkgs/snapper/template
index 4590842eedd..694090f5a07 100644
--- a/srcpkgs/snapper/template
+++ b/srcpkgs/snapper/template
@@ -6,7 +6,7 @@ build_style=gnu-configure
 configure_args="--disable-zypp --with-conf=/etc/conf.d"
 conf_files="/etc/conf.d/snapper"
 make_dirs="/etc/snapper/configs 0755 root root"
-hostmakedepends="automake docbook-xsl libtool libxml2-devel libxslt
+hostmakedepends="automake dbus docbook-xsl libtool libxml2-devel libxslt
  gettext pkg-config"
 makedepends="acl-devel boost-devel dbus-devel e2fsprogs-devel libbtrfs-devel
  libmount-devel libxml2-devel pam-devel"

From c7725686930f3d2583cb42e14b8d961f26a31d74 Mon Sep 17 00:00:00 2001
From: Mek101 <34246799+Mek101@users.noreply.github.com>
Date: Wed, 9 Dec 2020 16:10:53 +0000
Subject: [PATCH 2/2] Fixed template

---
 srcpkgs/snapper/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/snapper/template b/srcpkgs/snapper/template
index 694090f5a07..ca82c4de031 100644
--- a/srcpkgs/snapper/template
+++ b/srcpkgs/snapper/template
@@ -1,12 +1,12 @@
 # Template file for 'snapper'
 pkgname=snapper
 version=0.8.14
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--disable-zypp --with-conf=/etc/conf.d"
 conf_files="/etc/conf.d/snapper"
 make_dirs="/etc/snapper/configs 0755 root root"
-hostmakedepends="automake dbus docbook-xsl libtool libxml2-devel libxslt
+hostmakedepends="automake docbook-xsl libtool libxml2-devel libxslt
  gettext pkg-config"
 makedepends="acl-devel boost-devel dbus-devel e2fsprogs-devel libbtrfs-devel
  libmount-devel libxml2-devel pam-devel"
@@ -55,7 +55,7 @@ libsnapper_package() {
 
 snapper-devel_package() {
 	short_desc+=" - development files"
-	depends="libsnapper>=${version}_${revision}"
+	depends="dbus libsnapper>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/include
 		vmove "usr/lib/*.so"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: snapper: add dbus dependency
  2020-12-09 15:13 [PR PATCH] Added snapper missing dependency: dbus Mek101
  2020-12-09 15:24 ` ericonr
  2020-12-09 16:10 ` [PR PATCH] [Updated] snapper: add dbus dependency Mek101
@ 2020-12-09 17:38 ` ericonr
  2020-12-10 12:16 ` Mek101
  2020-12-10 13:36 ` [PR PATCH] [Closed]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-12-09 17:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27049#issuecomment-741930228

Comment:
If you want to include a post installation, this is your chance. Otherwise I have a version of your commits fixed up locally that i can merge.

(you should note that PR title is a different thing from commit message)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: snapper: add dbus dependency
  2020-12-09 15:13 [PR PATCH] Added snapper missing dependency: dbus Mek101
                   ` (2 preceding siblings ...)
  2020-12-09 17:38 ` ericonr
@ 2020-12-10 12:16 ` Mek101
  2020-12-10 13:36 ` [PR PATCH] [Closed]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: Mek101 @ 2020-12-10 12:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by Mek101 on void-packages repository

https://github.com/void-linux/void-packages/pull/27049#issuecomment-742485607

Comment:
Sorry, you can merge

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: snapper: add dbus dependency
  2020-12-09 15:13 [PR PATCH] Added snapper missing dependency: dbus Mek101
                   ` (3 preceding siblings ...)
  2020-12-10 12:16 ` Mek101
@ 2020-12-10 13:36 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-12-10 13:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

There's a closed pull request on the void-packages repository

snapper: add dbus dependency
https://github.com/void-linux/void-packages/pull/27049

Description:
Snapper requires dbus to work, as reported in #27047

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-12-10 13:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 15:13 [PR PATCH] Added snapper missing dependency: dbus Mek101
2020-12-09 15:24 ` ericonr
2020-12-09 16:10 ` [PR PATCH] [Updated] snapper: add dbus dependency Mek101
2020-12-09 17:38 ` ericonr
2020-12-10 12:16 ` Mek101
2020-12-10 13:36 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).