Github messages for voidlinux
 help / color / mirror / Atom feed
From: ndowens <ndowens@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-saml2: update to 6.4.1.
Date: Wed, 09 Dec 2020 22:27:49 +0100	[thread overview]
Message-ID: <20201209212749.FpF_IMNcLm74bj5HuX5XO4tOTcC_JFNXFiwBgztfdCk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27050@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#discussion_r539660709

Comment:
> The automatic `pytest` option was just committed, so you will have to rebase to see it.
> 
> In general, you want to run `python3 -m pytest` rather than calling `pytest` directly. When run directly, the current working directory does not appear in the `PYTHONPATH`; when run as a module, the current working directory is the first entry in `PYTHONPATH`. This difference is enough to make a lot of tests run without further modification.
> 
> Otherwise, you can look at overriding PYTHONPATH or investigate some of the options to pytest; the automatic behavior uses `$make_check_args` and `$make_check_target` to allow you to customize to some extent without requiring you to define the function.

Thanks for the explanation

  parent reply	other threads:[~2020-12-09 21:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 16:02 [PR PATCH] " ndowens
2020-12-09 16:04 ` [PR REVIEW] " ericonr
2020-12-09 16:04 ` ericonr
2020-12-09 17:41 ` ndowens
2020-12-09 20:58 ` ericonr
2020-12-09 21:02 ` [PR REVIEW] " ahesford
2020-12-09 21:19 ` [PR PATCH] [Updated] " ndowens
2020-12-09 21:21 ` [PR REVIEW] " ndowens
2020-12-09 21:22 ` ndowens
2020-12-09 21:27 ` ndowens [this message]
2020-12-10  4:13 ` [PR PATCH] [Closed]: " ahesford
2020-12-10  4:19 ` ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209212749.FpF_IMNcLm74bj5HuX5XO4tOTcC_JFNXFiwBgztfdCk@z \
    --to=ndowens@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).