From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-saml2: update to 6.4.1.
Date: Thu, 10 Dec 2020 05:19:26 +0100 [thread overview]
Message-ID: <20201210041926.4LNigC8XS7qYBA_5E95CUqdCowjpFOX9aY7pkrsgkoM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27050@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/27050#issuecomment-742228822
Comment:
`tox` is generally disfavored because it doesn't actually test against the contents of the package and the Void-packaged dependencies. It creates a virtualenv and populates it with `pip`, then tests that.
For `pytest`, you need to make sure all dependencies are available, plus a couple of extras just for testing. We don't package a couple of these, so you have to ignore tests that require thigns we don't provide. You also need, in this case, to set `PYTHONPATH=src` because the project package are inside this subdirectory (you could also use `build/lib*` to get the staged package created by setuptools).
See https://github.com/void-linux/void-packages/commit/e285453b7d1457b1026f84a0c23e254523882664 for more information.
prev parent reply other threads:[~2020-12-10 4:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 16:02 [PR PATCH] " ndowens
2020-12-09 16:04 ` [PR REVIEW] " ericonr
2020-12-09 16:04 ` ericonr
2020-12-09 17:41 ` ndowens
2020-12-09 20:58 ` ericonr
2020-12-09 21:02 ` [PR REVIEW] " ahesford
2020-12-09 21:19 ` [PR PATCH] [Updated] " ndowens
2020-12-09 21:21 ` [PR REVIEW] " ndowens
2020-12-09 21:22 ` ndowens
2020-12-09 21:27 ` ndowens
2020-12-10 4:13 ` [PR PATCH] [Closed]: " ahesford
2020-12-10 4:19 ` ahesford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210041926.4LNigC8XS7qYBA_5E95CUqdCowjpFOX9aY7pkrsgkoM@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).