[PR PATCH] python3-saml2: update to 6.4.1.

[PR PATCH] python3-saml2: update to 6.4.1.

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

There is a new pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages saml
https://github.com/void-linux/void-packages/pull/27050

python3-saml2: update to 6.4.1.
This fixes byte-compiling upon install

A patch file from https://github.com/void-linux/void-packages/pull/27050.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-saml-27050.patch --]
[-- Type: text/x-diff, Size: 1396 bytes --]

From c9e9684e88e720a75c5c7e4b55c06cbe4f599b40 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Wed, 9 Dec 2020 09:56:13 -0600
Subject: [PATCH] python3-saml2: update to 6.4.1.

---
 srcpkgs/python3-saml2/template | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-saml2/template b/srcpkgs/python3-saml2/template
index 5506ce0828f..d423be32310 100644
--- a/srcpkgs/python3-saml2/template
+++ b/srcpkgs/python3-saml2/template
@@ -1,15 +1,20 @@
 # Template file for 'python3-saml2'
 pkgname=python3-saml2
-version=5.0.0
-revision=2
+version=6.4.1
+revision=1
 wrksrc="pysaml2-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-cryptography python3-openssl python3-dateutil python3-pytz
  python3-requests python3-six python3-defusedxml"
+checkdepends="python3-pytest"
 short_desc="Python3 implementation of SAML Version 2 Standard"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Apache-2.0"
 homepage="https://github.com/IdentityPython/pysaml2"
-distfiles="${PYPI_SITE}/p/pysaml2/pysaml2-${version}.tar.gz"
-checksum=deea75b252b5ead821f12ce01e9d88b0f6fbcde322c1595dcbb06f9660af0cc1
+distfiles="https://github.com/IdentityPython/pysaml2/archive/v${version}.tar.gz"
+checksum=341fe81e1fdff72e6082ba81645a9b75dab7482cf9b878f566d023311169f8c0
+
+do_check() {
+	pytest tests
+}

Re: [PR REVIEW] python3-saml2: update to 6.4.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#discussion_r539434045

Comment:
Pytest has been added as an automatic option, so it should work without a custom `do_check`

Re: [PR REVIEW] python3-saml2: update to 6.4.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#discussion_r539434045

Comment:
Pytest has been added as an automatic option, so it should work without a custom `do_check` (just needs to be added to `checkdepends`).

Re: [PR REVIEW] python3-saml2: update to 6.4.1.

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#discussion_r539513305

Comment:
Thanks didn’t know that; I got to dig a little more to find why tests fail, expect it to be dep missing; on this one though will be using today as it needs itself as a dep to run test

Re: python3-saml2: update to 6.4.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#issuecomment-742045104

Comment:
Oops, it hadn't been merged yet https://github.com/void-linux/void-packages/pull/26901

Re: [PR REVIEW] python3-saml2: update to 6.4.1.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#discussion_r539645329

Comment:
The automatic `pytest` option was just committed, so you will have to rebase to see it.

In general, you want to run `python3 -m pytest` rather than calling `pytest` directly. When run directly, the current working directory does not appear in the `PYTHONPATH`; when run as a module, the current working directory is the first entry in `PYTHONPATH`. This difference is enough to make a lot of tests run without further modification.

Otherwise, you can look at overriding PYTHONPATH or investigate some of the options to pytest; the automatic behavior uses `$make_check_args` and `$make_check_target` to allow you to customize to some extent without requiring you to define the function.

Re: [PR PATCH] [Updated] python3-saml2: update to 6.4.1.

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages saml
https://github.com/void-linux/void-packages/pull/27050

python3-saml2: update to 6.4.1.
This fixes byte-compiling upon install

A patch file from https://github.com/void-linux/void-packages/pull/27050.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-saml-27050.patch --]
[-- Type: text/x-diff, Size: 1499 bytes --]

From 809ca23c4c02b8505a279a3dd47e5b869743ce75 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Wed, 9 Dec 2020 09:56:13 -0600
Subject: [PATCH] python3-saml2: update to 6.4.1.

---
 srcpkgs/python3-saml2/template | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-saml2/template b/srcpkgs/python3-saml2/template
index 5506ce0828f..13190c53ffc 100644
--- a/srcpkgs/python3-saml2/template
+++ b/srcpkgs/python3-saml2/template
@@ -1,15 +1,22 @@
 # Template file for 'python3-saml2'
 pkgname=python3-saml2
-version=5.0.0
-revision=2
+version=6.4.1
+revision=1
 wrksrc="pysaml2-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-cryptography python3-openssl python3-dateutil python3-pytz
  python3-requests python3-six python3-defusedxml"
+checkdepends="tox xmlsec1 xmlsec1-devel"
 short_desc="Python3 implementation of SAML Version 2 Standard"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Apache-2.0"
 homepage="https://github.com/IdentityPython/pysaml2"
-distfiles="${PYPI_SITE}/p/pysaml2/pysaml2-${version}.tar.gz"
-checksum=deea75b252b5ead821f12ce01e9d88b0f6fbcde322c1595dcbb06f9660af0cc1
+distfiles="https://github.com/IdentityPython/pysaml2/archive/v${version}.tar.gz"
+checksum=341fe81e1fdff72e6082ba81645a9b75dab7482cf9b878f566d023311169f8c0
+
+do_check() {
+	# Remove un-used python versions
+	vsed -e '/py36/,/py38/d' -e '/pypy3/d' -i tox.ini
+	tox -c tox.ini
+}

Re: [PR REVIEW] python3-saml2: update to 6.4.1.

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#discussion_r539656596

Comment:
I tried using pytest and the command ran as expected but like I thought, had to use tox as tests needs saml itself. Tests completed and this fixed the byte-compile during install I got earlier after I received an update

Re: [PR REVIEW] python3-saml2: update to 6.4.1.

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#discussion_r539657503

Comment:
Also xmlsec1-devel is needed as it seems to have xmlsec-openssl lib in it that tests failed on before adding the -devel package

Re: [PR REVIEW] python3-saml2: update to 6.4.1.

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#discussion_r539660709

Comment:
> The automatic `pytest` option was just committed, so you will have to rebase to see it.
> 
> In general, you want to run `python3 -m pytest` rather than calling `pytest` directly. When run directly, the current working directory does not appear in the `PYTHONPATH`; when run as a module, the current working directory is the first entry in `PYTHONPATH`. This difference is enough to make a lot of tests run without further modification.
> 
> Otherwise, you can look at overriding PYTHONPATH or investigate some of the options to pytest; the automatic behavior uses `$make_check_args` and `$make_check_target` to allow you to customize to some extent without requiring you to define the function.

Thanks for the explanation

Re: [PR PATCH] [Closed]: python3-saml2: update to 6.4.1.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

There's a closed pull request on the void-packages repository

python3-saml2: update to 6.4.1.
https://github.com/void-linux/void-packages/pull/27050

Description:
This fixes byte-compiling upon install

Re: python3-saml2: update to 6.4.1.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/27050#issuecomment-742228822

Comment:
`tox` is generally disfavored because it doesn't actually test against the contents of the package and the Void-packaged dependencies. It creates a virtualenv and populates it with `pip`, then tests that.

For `pytest`, you need to make sure all dependencies are available, plus a couple of extras just for testing. We don't package a couple of these, so you have to ignore tests that require thigns we don't provide. You also need, in this case, to set `PYTHONPATH=src` because the project package are inside this subdirectory (you could also use `build/lib*` to get the staged package created by setuptools).

See https://github.com/void-linux/void-packages/commit/e285453b7d1457b1026f84a0c23e254523882664 for more information.