From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: ffcast-2.5.0
Date: Mon, 14 Dec 2020 09:30:32 +0100 [thread overview]
Message-ID: <20201214083032.L7VKI5747tfUEi4u6PHpkf2D-o3H57RNzEZMcyKdPjQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27130@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/27130#issuecomment-744271947
Comment:
The error says:
```
/void-packages/common/xbps-src/shutils/common.sh: line 31: cd: /builddir/ffcast-2.5.0: No such file or directory
=> ERROR: ffcast-2.5.0_1: cannot access wrksrc directory [/builddir/ffcast-2.5.0]
```
when we try looking inside this directory:
```
$ ls masterdir/builddir
FFcast-2.5.0
```
we can see there is no ffcast-2.5.0 directory, there is only **FF**cast-2.5.0. This means we need to tell the build-system to use it. Add `wrksrc=FFcast-${version}`.
The next problem is that you are using command `bootstrap` and `configure`. These are not executables installed in `$PATH`, they are executable files in the current directory which means you have to run them as the README suggests - `./bootstrap` and `./configure`. Now the package should build, but the template is not ideal.
There is no reason to install README.asciidoc, because it only has information about compiling the package.
./configure and make in do_build and make install in do_install is quite common, so we can add `build_style=gnu-configure` which will add basically:
```
do_configure() {
./configure with the correct flags
}
do_build() {
make
}
do_install() {
make install
}
```
We need to make sure we don't rewrite the functions do_build and do_install that build_style provided to us, so we need to move the one remaining command - `./bootstrap` we need to run **before** do_configure to pre_configure.
The last issue I see is that makedepends should be renamed to hostmakedepends.
next prev parent reply other threads:[~2020-12-14 8:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 22:47 [PR PATCH] " kawaiiamber
2020-12-14 8:30 ` paper42 [this message]
2020-12-14 8:30 ` paper42
2020-12-14 18:17 ` [PR PATCH] [Updated] " kawaiiamber
2020-12-14 18:18 ` kawaiiamber
2020-12-14 18:19 ` kawaiiamber
2020-12-14 18:27 ` [PR REVIEW] " ericonr
2020-12-14 18:29 ` [PR PATCH] [Updated] " kawaiiamber
2020-12-14 18:29 ` kawaiiamber
2020-12-14 18:30 ` [PR REVIEW] " kawaiiamber
2020-12-14 18:36 ` ericonr
2020-12-14 18:39 ` kawaiiamber
2020-12-14 23:21 ` [PR PATCH] [Updated] " kawaiiamber
2020-12-14 23:22 ` kawaiiamber
2021-04-18 21:57 ` ericonr
2021-04-18 21:57 ` [PR PATCH] [Closed]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214083032.L7VKI5747tfUEi4u6PHpkf2D-o3H57RNzEZMcyKdPjQ@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).