Re: [PR PATCH] [Updated] New package: ffcast-2.5.0

[kawaiiamber <kawaiiamber@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages ffcast
https://github.com/void-linux/void-packages/pull/27130

New package: ffcast-2.5.0
# About
Adds the package [ffcast](https://github.com/lolilolicon/FFcast).
## Issues
This is my second ever time trying to contribute. I successfully got the source to build and run on my machine, but I don't think I'm using xbps-src or correct template notation to build it as `xbps-src pkg ffcast` seems to fail and I'm not sure why, so it will most likely fail the checks here. I read the manual, and maybe it's a little over me. Any help would be <3

A patch file from https://github.com/void-linux/void-packages/pull/27130.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ffcast-27130.patch --]
[-- Type: text/x-diff, Size: 2538 bytes --]

From 69fb895b0b1402c2a563f715d01fdde57469daa3 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 13 Dec 2020 15:42:48 -0700
Subject: [PATCH 1/2] New package: ffcast-2.5.0

---
 srcpkgs/ffcast/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/ffcast/template

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
new file mode 100644
index 00000000000..1ca463151fd
--- /dev/null
+++ b/srcpkgs/ffcast/template
@@ -0,0 +1,23 @@
+# Template file for 'ffcast'
+pkgname=ffcast
+version=2.5.0
+revision=1
+makedepends="autoconf automake"
+depends="bash ffmpeg ImageMagick xdpyinfo xprop xwininfo"
+short_desc="Run command on rectangular screen regions"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/lolilolicon/FFcast"
+distfiles="https://github.com/lolilolicon/FFcast/archive/${version}.tar.gz"
+checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
+
+do_build() {
+	bootstrap
+	configure --prefix /usr --libexecdir /usr/lib
+	make
+}
+
+do_install() {
+	make install
+	vinstall README.asciidoc 644 usr/share/doc/$pkgname
+}

From bda5a6e0ba1d1f624936f899b348f0628f16ada1 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Mon, 14 Dec 2020 11:17:19 -0700
Subject: [PATCH 2/2] New package: ffcast-2.5.0

---
 srcpkgs/ffcast/template | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/ffcast/template b/srcpkgs/ffcast/template
index 1ca463151fd..b391a1dfb12 100644
--- a/srcpkgs/ffcast/template
+++ b/srcpkgs/ffcast/template
@@ -2,7 +2,9 @@
 pkgname=ffcast
 version=2.5.0
 revision=1
-makedepends="autoconf automake"
+wrksrc=FFcast-${version}
+build_style=gnu-configure
+hostmakedepends="autoconf automake"
 depends="bash ffmpeg ImageMagick xdpyinfo xprop xwininfo"
 short_desc="Run command on rectangular screen regions"
 maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
@@ -11,13 +13,18 @@ homepage="https://github.com/lolilolicon/FFcast"
 distfiles="https://github.com/lolilolicon/FFcast/archive/${version}.tar.gz"
 checksum=09ebf44f76a1813eb8db78df0256f7a1cd259562cf87908b6d683f7fd1ec6b30
 
+pre_configure() {
+	./bootstrap
+}
+
+do_configure() {
+	./configure --prefix /usr --libexecdir /usr/lib
+}
+
 do_build() {
-	bootstrap
-	configure --prefix /usr --libexecdir /usr/lib
 	make
 }
 
 do_install() {
 	make install
-	vinstall README.asciidoc 644 usr/share/doc/$pkgname
 }