[PR PATCH] sddm: remove pam_tally.so from sddm-autologin

[PR PATCH] sddm: remove pam_tally.so from sddm-autologin

[teldra]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

There is a new pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages sddm-fix-tally
https://github.com/void-linux/void-packages/pull/27102

sddm: remove pam_tally.so from sddm-autologin


A patch file from https://github.com/void-linux/void-packages/pull/27102.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sddm-fix-tally-27102.patch --]
[-- Type: text/x-diff, Size: 907 bytes --]

From d945fac70add1637eb3c957e11d666e8ece49519 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 12 Dec 2020 11:07:23 +0100
Subject: [PATCH] sddm: remove pam_tally.so from sddm-autologin

---
 srcpkgs/sddm/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/sddm/template b/srcpkgs/sddm/template
index f3bca6f9a31..82b5700c887 100644
--- a/srcpkgs/sddm/template
+++ b/srcpkgs/sddm/template
@@ -1,7 +1,7 @@
 # Template file for 'sddm'
 pkgname=sddm
 version=0.18.1
-revision=2
+revision=3
 build_style=cmake
 configure_args="-DBUILD_MAN_PAGES=1 -DNO_SYSTEMD=1 -DUSE_ELOGIND=1
  -DLOGIN_DEFS_PATH=${XBPS_SRCPKGDIR}/shadow/files/login.defs
@@ -31,5 +31,6 @@ make_dirs="/var/lib/sddm 0755 sddm sddm"
 
 post_install() {
 	sed -i 's,systemd,ck_connector,g' ${DESTDIR}/etc/pam.d/sddm-greeter
+	sed -i '/tally/d' ${DESTDIR}/etc/pam.d/sddm-autologin
 	vsv sddm
 }

Re: [PR PATCH] [Updated] sddm: remove pam_tally.so from sddm-autologin

[teldra]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

There is an updated pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages sddm-fix-tally
https://github.com/void-linux/void-packages/pull/27102

sddm: remove pam_tally.so from sddm-autologin


A patch file from https://github.com/void-linux/void-packages/pull/27102.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sddm-fix-tally-27102.patch --]
[-- Type: text/x-diff, Size: 996 bytes --]

From 66699787ab5b3b48140b1434628b2a4c01aa2230 Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 12 Dec 2020 11:07:23 +0100
Subject: [PATCH] sddm: remove pam_tally.so from sddm-autologin

---
 srcpkgs/sddm/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/sddm/template b/srcpkgs/sddm/template
index f3bca6f9a31..ab3601c9348 100644
--- a/srcpkgs/sddm/template
+++ b/srcpkgs/sddm/template
@@ -1,7 +1,7 @@
 # Template file for 'sddm'
 pkgname=sddm
 version=0.18.1
-revision=2
+revision=3
 build_style=cmake
 configure_args="-DBUILD_MAN_PAGES=1 -DNO_SYSTEMD=1 -DUSE_ELOGIND=1
  -DLOGIN_DEFS_PATH=${XBPS_SRCPKGDIR}/shadow/files/login.defs
@@ -30,6 +30,7 @@ conf_files="
 make_dirs="/var/lib/sddm 0755 sddm sddm"
 
 post_install() {
-	sed -i 's,systemd,ck_connector,g' ${DESTDIR}/etc/pam.d/sddm-greeter
+	vsed -i 's,systemd,ck_connector,g' ${DESTDIR}/etc/pam.d/sddm-greeter
+	vsed -i '/tally/d' ${DESTDIR}/etc/pam.d/sddm-autologin
 	vsv sddm
 }

Re: [PR REVIEW] sddm: remove pam_tally.so from sddm-autologin

[teldra]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New review comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/27102#discussion_r541548210

Comment:
This check seems to be not needed anymore. Should I delete it?
```
=> WARNING: sddm-0.18.1_3: vsed: regex "s,systemd,ck_connector,g" didn't change file "/destdir//sddm-0.18.1/etc/pam.d/sddm-greeter"
```

Re: [PR REVIEW] sddm: remove pam_tally.so from sddm-autologin

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27102#discussion_r541564704

Comment:
What does the file look like? A systemd Pam module should be replaced by the elogind one, perhaps. Replacing by the console kit one won't work anymore.

Re: [PR REVIEW] sddm: remove pam_tally.so from sddm-autologin

[teldra]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/27102#discussion_r541565883

Comment:
In `/etc/pam.d/sddm-greeter` is no entry with systemd but ```session         optional pam_elogind.so``` on my installed sddm.

Re: [PR PATCH] [Updated] sddm: remove pam_tally.so from sddm-autologin

[teldra]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

There is an updated pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages sddm-fix-tally
https://github.com/void-linux/void-packages/pull/27102

sddm: remove pam_tally.so from sddm-autologin


A patch file from https://github.com/void-linux/void-packages/pull/27102.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sddm-fix-tally-27102.patch --]
[-- Type: text/x-diff, Size: 996 bytes --]

From 502268e1a5a429d4ca3303e2958270cf390f15bc Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 12 Dec 2020 11:07:23 +0100
Subject: [PATCH] sddm: remove pam_tally.so from sddm-autologin

---
 srcpkgs/sddm/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/sddm/template b/srcpkgs/sddm/template
index f3bca6f9a31..ab3601c9348 100644
--- a/srcpkgs/sddm/template
+++ b/srcpkgs/sddm/template
@@ -1,7 +1,7 @@
 # Template file for 'sddm'
 pkgname=sddm
 version=0.18.1
-revision=2
+revision=3
 build_style=cmake
 configure_args="-DBUILD_MAN_PAGES=1 -DNO_SYSTEMD=1 -DUSE_ELOGIND=1
  -DLOGIN_DEFS_PATH=${XBPS_SRCPKGDIR}/shadow/files/login.defs
@@ -30,6 +30,7 @@ conf_files="
 make_dirs="/var/lib/sddm 0755 sddm sddm"
 
 post_install() {
-	sed -i 's,systemd,ck_connector,g' ${DESTDIR}/etc/pam.d/sddm-greeter
+	vsed -i 's,systemd,ck_connector,g' ${DESTDIR}/etc/pam.d/sddm-greeter
+	vsed -i '/tally/d' ${DESTDIR}/etc/pam.d/sddm-autologin
 	vsv sddm
 }

Re: [PR REVIEW] sddm: remove pam_tally.so from sddm-autologin

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/27102#discussion_r544227712

Comment:
obsolete since https://github.com/sddm/sddm/commit/96e50a76db406ab6a225b988eaaad7b62eadb3a4
that is exactly why vsed is useful

Re: [PR REVIEW] sddm: remove pam_tally.so from sddm-autologin

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/27102#discussion_r544228891

Comment:
please provide additional information/context to the commit why you remove it

Re: [PR PATCH] [Updated] sddm: remove pam_tally.so from sddm-autologin

[teldra]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

There is an updated pull request by teldra against master on the void-packages repository

https://github.com/teldra/void-packages sddm-fix-tally
https://github.com/void-linux/void-packages/pull/27102

sddm: remove pam_tally.so from sddm-autologin


A patch file from https://github.com/void-linux/void-packages/pull/27102.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sddm-fix-tally-27102.patch --]
[-- Type: text/x-diff, Size: 1111 bytes --]

From 0bf4f36be4db348a680ade33d5b2f4fa1ef547da Mon Sep 17 00:00:00 2001
From: teldra <teldra@rotce.de>
Date: Sat, 12 Dec 2020 11:07:23 +0100
Subject: [PATCH] sddm: remove pam_tally.so from sddm-autologin

Remove pam_tally from /etc/pam.d/sddm-autologin. The pam_tally module is deprecated
as of PAM 1.4.0 and was removed on PAM 1.5.0.

Remove pam_ck_connector, since it's no longer provided.
---
 srcpkgs/sddm/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/sddm/template b/srcpkgs/sddm/template
index f3bca6f9a31..c65588beaee 100644
--- a/srcpkgs/sddm/template
+++ b/srcpkgs/sddm/template
@@ -1,7 +1,7 @@
 # Template file for 'sddm'
 pkgname=sddm
 version=0.18.1
-revision=2
+revision=3
 build_style=cmake
 configure_args="-DBUILD_MAN_PAGES=1 -DNO_SYSTEMD=1 -DUSE_ELOGIND=1
  -DLOGIN_DEFS_PATH=${XBPS_SRCPKGDIR}/shadow/files/login.defs
@@ -30,6 +30,6 @@ conf_files="
 make_dirs="/var/lib/sddm 0755 sddm sddm"
 
 post_install() {
-	sed -i 's,systemd,ck_connector,g' ${DESTDIR}/etc/pam.d/sddm-greeter
+	vsed -i '/tally/d' ${DESTDIR}/etc/pam.d/sddm-autologin
 	vsv sddm
 }

Re: [PR REVIEW] sddm: remove pam_tally.so from sddm-autologin

[teldra]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New review comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/27102#discussion_r544273426

Comment:
Should be done

Re: [PR REVIEW] sddm: remove pam_tally.so from sddm-autologin

[teldra]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by teldra on void-packages repository

https://github.com/void-linux/void-packages/pull/27102#discussion_r544273545

Comment:
Removed

Re: sddm: remove pam_tally.so from sddm-autologin

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27102#issuecomment-747633551

Comment:
Btw, would be nice to report this to upstream!

Re: [PR PATCH] [Merged]: sddm: remove pam_tally.so from sddm-autologin

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

There's a merged pull request on the void-packages repository

sddm: remove pam_tally.so from sddm-autologin
https://github.com/void-linux/void-packages/pull/27102

Description: