Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mesa: update to 20.3.1.
@ 2020-12-17  2:57 HadetTheUndying
  2020-12-17 14:06 ` [PR REVIEW] " ericonr
                   ` (16 more replies)
  0 siblings, 17 replies; 36+ messages in thread
From: HadetTheUndying @ 2020-12-17  2:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

There is a new pull request by HadetTheUndying against master on the void-packages repository

https://github.com/HadetTheUndying/void-packages mesa-20.3.1
https://github.com/void-linux/void-packages/pull/27214

mesa: update to 20.3.1.
removed drm and surfaceless from platforms since they're determined automatically now.

A patch file from https://github.com/void-linux/void-packages/pull/27214.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mesa-20.3.1-27214.patch --]
[-- Type: text/x-diff, Size: 1473 bytes --]

From 80e60f640687eca44fb641b02b3a7daa2f7505cd Mon Sep 17 00:00:00 2001
From: HadetTheUndying <hadet@protonmail.com>
Date: Wed, 16 Dec 2020 20:55:08 -0600
Subject: [PATCH] mesa: update to 20.3.1.

---
 srcpkgs/mesa/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/mesa/template b/srcpkgs/mesa/template
index 5bc5a611f38..e009bb24cd1 100644
--- a/srcpkgs/mesa/template
+++ b/srcpkgs/mesa/template
@@ -1,12 +1,12 @@
 # Template file for 'mesa'
 pkgname=mesa
-version=20.2.3
+version=20.3.1
 revision=1
 wrksrc="mesa-${version}"
 build_style=meson
 configure_args="-Dglvnd=true -Dshared-glapi=true -Dgbm=true -Degl=true
  -Dosmesa=gallium -Dgles1=true -Dgles2=true -Dglx=dri -Ddri3=true
- -Dlmsensors=true -Dplatforms=x11,drm,$(vopt_if wayland wayland,)surfaceless
+ -Dlmsensors=true -Dplatforms=x11,$(vopt_if wayland wayland)
  -Dllvm=true -Db_lto=false -Dcpp_std=gnu++14"
 hostmakedepends="gettext flex llvm pkg-config python3-Mako glslang gzip
  $(vopt_if wayland 'wayland-protocols wayland-devel')"
@@ -23,7 +23,7 @@ license="MIT, LGPL-2.1-or-later"
 homepage="https://www.mesa3d.org/"
 changelog="https://docs.mesa3d.org/relnotes/${version}.html"
 distfiles="https://mesa.freedesktop.org/archive/mesa-${version}.tar.xz"
-checksum=ae1b240e11531df528d14dc214d2dc4d2b4f2e835c6230ba0b492b171eceb82b
+checksum=af751b49bb2ab0264d58c31e73d869e80333de02b2d1becc93f1b28c67aa780f
 
 build_options="wayland"
 build_options_default="wayland"

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
@ 2020-12-17 14:06 ` ericonr
  2020-12-17 14:07 ` ericonr
                   ` (15 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-17 14:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#discussion_r545114239

Comment:
Will this still build if one removes the wayland option?

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
  2020-12-17 14:06 ` [PR REVIEW] " ericonr
@ 2020-12-17 14:07 ` ericonr
  2020-12-17 14:08 ` ericonr
                   ` (14 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-17 14:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#discussion_r545116046

Comment:
Yeah, it fails

> meson.build:21:0: ERROR: Options "" are not in allowed choices: "auto, x11, wayland, haiku, android, windows"

I'm okay with removing the build option :P 

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
  2020-12-17 14:06 ` [PR REVIEW] " ericonr
  2020-12-17 14:07 ` ericonr
@ 2020-12-17 14:08 ` ericonr
  2020-12-17 14:08 ` ericonr
                   ` (13 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-17 14:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#discussion_r545116046

Comment:
Yeah, it fails

> meson.build:21:0: ERROR: Options "" are not in allowed choices: "auto, x11, wayland, haiku, android, windows"

I'm okay with removing the build option and always enabling wayland.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (2 preceding siblings ...)
  2020-12-17 14:08 ` ericonr
@ 2020-12-17 14:08 ` ericonr
  2020-12-17 20:50 ` [PR PATCH] [Updated] " HadetTheUndying
                   ` (12 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-17 14:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#discussion_r545116619

Comment:
Otherwise, `x11$(vopt_if wayland ,wayland)`

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR PATCH] [Updated] mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (3 preceding siblings ...)
  2020-12-17 14:08 ` ericonr
@ 2020-12-17 20:50 ` HadetTheUndying
  2020-12-17 20:51 ` HadetTheUndying
                   ` (11 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: HadetTheUndying @ 2020-12-17 20:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

There is an updated pull request by HadetTheUndying against master on the void-packages repository

https://github.com/HadetTheUndying/void-packages mesa-20.3.1
https://github.com/void-linux/void-packages/pull/27214

mesa: update to 20.3.1.
removed drm and surfaceless from platforms since they're determined automatically now.

A patch file from https://github.com/void-linux/void-packages/pull/27214.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mesa-20.3.1-27214.patch --]
[-- Type: text/x-diff, Size: 1454 bytes --]

From 0a8a760fecf99e7f79c70c41c3633b34f68e8fb5 Mon Sep 17 00:00:00 2001
From: HadetTheUndying <hadet@protonmail.com>
Date: Wed, 16 Dec 2020 20:55:08 -0600
Subject: [PATCH] mesa: update to 20.3.1.

---
 srcpkgs/mesa/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/mesa/template b/srcpkgs/mesa/template
index 5bc5a611f38..01c46b374ef 100644
--- a/srcpkgs/mesa/template
+++ b/srcpkgs/mesa/template
@@ -1,12 +1,12 @@
 # Template file for 'mesa'
 pkgname=mesa
-version=20.2.3
+version=20.3.1
 revision=1
 wrksrc="mesa-${version}"
 build_style=meson
 configure_args="-Dglvnd=true -Dshared-glapi=true -Dgbm=true -Degl=true
  -Dosmesa=gallium -Dgles1=true -Dgles2=true -Dglx=dri -Ddri3=true
- -Dlmsensors=true -Dplatforms=x11,drm,$(vopt_if wayland wayland,)surfaceless
+ -Dlmsensors=true -Dplatforms=x11,wayland
  -Dllvm=true -Db_lto=false -Dcpp_std=gnu++14"
 hostmakedepends="gettext flex llvm pkg-config python3-Mako glslang gzip
  $(vopt_if wayland 'wayland-protocols wayland-devel')"
@@ -23,7 +23,7 @@ license="MIT, LGPL-2.1-or-later"
 homepage="https://www.mesa3d.org/"
 changelog="https://docs.mesa3d.org/relnotes/${version}.html"
 distfiles="https://mesa.freedesktop.org/archive/mesa-${version}.tar.xz"
-checksum=ae1b240e11531df528d14dc214d2dc4d2b4f2e835c6230ba0b492b171eceb82b
+checksum=af751b49bb2ab0264d58c31e73d869e80333de02b2d1becc93f1b28c67aa780f
 
 build_options="wayland"
 build_options_default="wayland"

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (4 preceding siblings ...)
  2020-12-17 20:50 ` [PR PATCH] [Updated] " HadetTheUndying
@ 2020-12-17 20:51 ` HadetTheUndying
  2020-12-17 20:51 ` [PR REVIEW] " HadetTheUndying
                   ` (10 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: HadetTheUndying @ 2020-12-17 20:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by HadetTheUndying on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#issuecomment-747694377

Comment:
Done.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (5 preceding siblings ...)
  2020-12-17 20:51 ` HadetTheUndying
@ 2020-12-17 20:51 ` HadetTheUndying
  2020-12-17 21:05 ` ericonr
                   ` (9 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: HadetTheUndying @ 2020-12-17 20:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New review comment by HadetTheUndying on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#discussion_r545395740

Comment:
Woops commented in the wrong spot. Yeah i thought about that too. Went ahead and did it. Should be good now

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (6 preceding siblings ...)
  2020-12-17 20:51 ` [PR REVIEW] " HadetTheUndying
@ 2020-12-17 21:05 ` ericonr
  2020-12-18  2:49 ` [PR PATCH] [Updated] " HadetTheUndying
                   ` (8 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-17 21:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#discussion_r545403175

Comment:
You need to remove the build option from here, then. Also from the dependencies.

Might be simpler to still use `vopt_if` :P

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR PATCH] [Updated] mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (7 preceding siblings ...)
  2020-12-17 21:05 ` ericonr
@ 2020-12-18  2:49 ` HadetTheUndying
  2020-12-19  5:25 ` q66
                   ` (7 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: HadetTheUndying @ 2020-12-18  2:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

There is an updated pull request by HadetTheUndying against master on the void-packages repository

https://github.com/HadetTheUndying/void-packages mesa-20.3.1
https://github.com/void-linux/void-packages/pull/27214

mesa: update to 20.3.1.
removed drm and surfaceless from platforms since they're determined automatically now.

A patch file from https://github.com/void-linux/void-packages/pull/27214.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mesa-20.3.1-27214.patch --]
[-- Type: text/x-diff, Size: 2055 bytes --]

From 0b103987a6e3964bc122ad14ed573bc775dac137 Mon Sep 17 00:00:00 2001
From: HadetTheUndying <hadet@protonmail.com>
Date: Wed, 16 Dec 2020 20:55:08 -0600
Subject: [PATCH] mesa: update to 20.3.1.

---
 srcpkgs/mesa/template | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mesa/template b/srcpkgs/mesa/template
index 5bc5a611f38..4b1495c64d7 100644
--- a/srcpkgs/mesa/template
+++ b/srcpkgs/mesa/template
@@ -1,19 +1,19 @@
 # Template file for 'mesa'
 pkgname=mesa
-version=20.2.3
+version=20.3.1
 revision=1
 wrksrc="mesa-${version}"
 build_style=meson
 configure_args="-Dglvnd=true -Dshared-glapi=true -Dgbm=true -Degl=true
  -Dosmesa=gallium -Dgles1=true -Dgles2=true -Dglx=dri -Ddri3=true
- -Dlmsensors=true -Dplatforms=x11,drm,$(vopt_if wayland wayland,)surfaceless
+ -Dlmsensors=true -Dplatforms=x11,wayland
  -Dllvm=true -Db_lto=false -Dcpp_std=gnu++14"
 hostmakedepends="gettext flex llvm pkg-config python3-Mako glslang gzip
- $(vopt_if wayland 'wayland-protocols wayland-devel')"
+ wayland-protocols wayland-devel"
 makedepends="elfutils-devel expat-devel libXdamage-devel libXvMC-devel
  libXxf86vm-devel libatomic-devel libdrm-devel libffi-devel libva-devel
  libvdpau-devel libxshmfence-devel ncurses-devel zlib-devel
- $(vopt_if wayland 'wayland-devel wayland-protocols') llvm libsensors-devel
+ wayland-devel wayland-protocols llvm libsensors-devel
  libXrandr-devel libglvnd-devel libzstd-devel libxml2-devel lua53-devel
  libarchive-devel"
 depends="libglvnd"
@@ -23,10 +23,8 @@ license="MIT, LGPL-2.1-or-later"
 homepage="https://www.mesa3d.org/"
 changelog="https://docs.mesa3d.org/relnotes/${version}.html"
 distfiles="https://mesa.freedesktop.org/archive/mesa-${version}.tar.xz"
-checksum=ae1b240e11531df528d14dc214d2dc4d2b4f2e835c6230ba0b492b171eceb82b
+checksum=af751b49bb2ab0264d58c31e73d869e80333de02b2d1becc93f1b28c67aa780f
 
-build_options="wayland"
-build_options_default="wayland"
 
 # Set subpackages manually to set proper rdeps in 32bit pkgs.
 subpackages="libglapi libgbm libOSMesa"

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (8 preceding siblings ...)
  2020-12-18  2:49 ` [PR PATCH] [Updated] " HadetTheUndying
@ 2020-12-19  5:25 ` q66
  2020-12-20  1:47 ` travankor
                   ` (6 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: q66 @ 2020-12-19  5:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#issuecomment-748422197

Comment:
we should fix the driver search path according to https://github.com/void-linux/void-packages/pull/27269 while at it

basically remove

```
case "$XBPS_TARGET_MACHINE" in
        i686) configure_args+=" -Ddri-drivers-path=/usr/lib32/dri";;
esac
```

and add `-Ddri-drivers-path=/usr/lib${XBPS_TARGET_WORDSIZE}` to `configure_args`

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (9 preceding siblings ...)
  2020-12-19  5:25 ` q66
@ 2020-12-20  1:47 ` travankor
  2020-12-20  1:51 ` HadetTheUndying
                   ` (5 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: travankor @ 2020-12-20  1:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#issuecomment-748550924

Comment:
the transitional dummy packages can be removed, too (it's been  a year)

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (10 preceding siblings ...)
  2020-12-20  1:47 ` travankor
@ 2020-12-20  1:51 ` HadetTheUndying
  2020-12-20  1:58 ` ericonr
                   ` (4 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: HadetTheUndying @ 2020-12-20  1:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

New comment by HadetTheUndying on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#issuecomment-748551205

Comment:
Hey guys I'm going through a family crisis right now. Is there any way i can hand this off, or should I close my PR and let someone else submit a new one? I'm on mobile for the time being so i cannot make any of the suggested changes and don't want to hold things up.

Thanks

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (11 preceding siblings ...)
  2020-12-20  1:51 ` HadetTheUndying
@ 2020-12-20  1:58 ` ericonr
  2020-12-20  2:07 ` HadetTheUndying
                   ` (3 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-20  1:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#issuecomment-748551715

Comment:
@HadetTheUndying good luck out there.

Someone else can work on another PR that "closes" this one. Thank you for the work.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (12 preceding siblings ...)
  2020-12-20  1:58 ` ericonr
@ 2020-12-20  2:07 ` HadetTheUndying
  2020-12-20  3:37 ` ericonr
                   ` (2 subsequent siblings)
  16 siblings, 0 replies; 36+ messages in thread
From: HadetTheUndying @ 2020-12-20  2:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by HadetTheUndying on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#issuecomment-748552508

Comment:
Okay I will leave the PR open until another PR addresses it. If i have free time during the week and no one has gotten to it, I will wrap it up. Thank you.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (13 preceding siblings ...)
  2020-12-20  2:07 ` HadetTheUndying
@ 2020-12-20  3:37 ` ericonr
  2020-12-20  3:45 ` HadetTheUndying
  2020-12-20  3:45 ` [PR PATCH] [Closed]: " HadetTheUndying
  16 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-20  3:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#issuecomment-748558281

Comment:
I opened #27291 that applies the comments from here.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (14 preceding siblings ...)
  2020-12-20  3:37 ` ericonr
@ 2020-12-20  3:45 ` HadetTheUndying
  2020-12-20  3:45 ` [PR PATCH] [Closed]: " HadetTheUndying
  16 siblings, 0 replies; 36+ messages in thread
From: HadetTheUndying @ 2020-12-20  3:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by HadetTheUndying on void-packages repository

https://github.com/void-linux/void-packages/pull/27214#issuecomment-748558860

Comment:
I'll update my 21.0.0 sometime this week with the updates. Closing now. Thanks.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR PATCH] [Closed]: mesa: update to 20.3.1.
  2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
                   ` (15 preceding siblings ...)
  2020-12-20  3:45 ` HadetTheUndying
@ 2020-12-20  3:45 ` HadetTheUndying
  16 siblings, 0 replies; 36+ messages in thread
From: HadetTheUndying @ 2020-12-20  3:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

There's a closed pull request on the void-packages repository

mesa: update to 20.3.1.
https://github.com/void-linux/void-packages/pull/27214

Description:
removed drm and surfaceless from platforms since they're determined automatically now.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (16 preceding siblings ...)
  2020-12-21 17:48 ` q66
@ 2020-12-21 17:57 ` ericonr
  17 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-21 17:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546847970

Comment:
Thing is that they install packages other than only `mesa-dri`... They provide a certain convenience factor, imo.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (15 preceding siblings ...)
  2020-12-21 14:52 ` st3r4g
@ 2020-12-21 17:48 ` q66
  2020-12-21 17:57 ` ericonr
  17 siblings, 0 replies; 36+ messages in thread
From: q66 @ 2020-12-21 17:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546843701

Comment:
let's not make it legit metapackages

they are still transitional dummy packages that people should not install by default, they should just remain there since they cause no harm and removing them would break upgrading old systems

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (14 preceding siblings ...)
  2020-12-21 12:35 ` ericonr
@ 2020-12-21 14:52 ` st3r4g
  2020-12-21 17:48 ` q66
  2020-12-21 17:57 ` ericonr
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-21 14:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546748865

Comment:
If you want to make this a legit metapackage, I'd change `short_desc` to a more generic "Mesa drivers for ATI GPUs", and same for Intel and Nouveau

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (13 preceding siblings ...)
  2020-12-21  2:29 ` ericonr
@ 2020-12-21 12:35 ` ericonr
  2020-12-21 14:52 ` st3r4g
                   ` (2 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-21 12:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546681988

Comment:
Missing the fix for thw build option.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (12 preceding siblings ...)
  2020-12-20 23:37 ` q66
@ 2020-12-21  2:29 ` ericonr
  2020-12-21 12:35 ` ericonr
                   ` (3 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-21  2:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546479565

Comment:
Revbumped and fixed the dri location, thanks!

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (11 preceding siblings ...)
  2020-12-20 23:36 ` q66
@ 2020-12-20 23:37 ` q66
  2020-12-21  2:29 ` ericonr
                   ` (4 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: q66 @ 2020-12-20 23:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546453069

Comment:
~~does it? how?~~ oh, yeah, it does, let's rebuild xorg as well

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (10 preceding siblings ...)
  2020-12-20 23:24 ` st3r4g
@ 2020-12-20 23:36 ` q66
  2020-12-20 23:37 ` q66
                   ` (5 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: q66 @ 2020-12-20 23:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546453069

Comment:
does it? how?

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (9 preceding siblings ...)
  2020-12-20 23:01 ` q66
@ 2020-12-20 23:24 ` st3r4g
  2020-12-20 23:36 ` q66
                   ` (6 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-20 23:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546451622

Comment:
xorg also uses this path (via `/usr/lib/pkgconfig/dri.pc`) don't we need to rebuild xorg too? 

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (8 preceding siblings ...)
  2020-12-20 16:42 ` st3r4g
@ 2020-12-20 23:01 ` q66
  2020-12-20 23:24 ` st3r4g
                   ` (7 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: q66 @ 2020-12-20 23:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546449075

Comment:
yes, sorry, i accidentally wrote the wrong argument in the previous PR

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (7 preceding siblings ...)
  2020-12-20 16:38 ` st3r4g
@ 2020-12-20 16:42 ` st3r4g
  2020-12-20 23:01 ` q66
                   ` (8 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-20 16:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546399453

Comment:
this should be `/usr/lib${XBPS_TARGET_WORDSIZE}/dri`

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (6 preceding siblings ...)
  2020-12-20 16:33 ` st3r4g
@ 2020-12-20 16:38 ` st3r4g
  2020-12-20 16:42 ` st3r4g
                   ` (9 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-20 16:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546400078

Comment:
Also remove the block
```
case "$XBPS_TARGET_MACHINE" in
	i686) configure_args+=" -Ddri-drivers-path=/usr/lib32/dri";;
esac
```

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (5 preceding siblings ...)
  2020-12-20 14:52 ` st3r4g
@ 2020-12-20 16:33 ` st3r4g
  2020-12-20 16:38 ` st3r4g
                   ` (10 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-20 16:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546399453

Comment:
shouldn't this be `/usr/lib${XBPS_TARGET_WORDSIZE}/dri`?

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (4 preceding siblings ...)
  2020-12-20 14:44 ` ericonr
@ 2020-12-20 14:52 ` st3r4g
  2020-12-20 16:33 ` st3r4g
                   ` (11 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-20 14:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546387220

Comment:
ok

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (3 preceding siblings ...)
  2020-12-20 13:19 ` st3r4g
@ 2020-12-20 14:44 ` ericonr
  2020-12-20 14:52 ` st3r4g
                   ` (12 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: ericonr @ 2020-12-20 14:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546386243

Comment:
q66 asked not to remove the sub packages, so I will just revert this part.

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
                   ` (2 preceding siblings ...)
  2020-12-20 13:18 ` st3r4g
@ 2020-12-20 13:19 ` st3r4g
  2020-12-20 14:44 ` ericonr
                   ` (13 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-20 13:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546365342

Comment:
I think this should be `replaces=` and should be in the `mesa-dri` subpkg. Also, the syntax for provides is `provides="$vpkg-$version"`

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
  2020-12-20 11:45 ` [PR REVIEW] " st3r4g
  2020-12-20 12:08 ` st3r4g
@ 2020-12-20 13:18 ` st3r4g
  2020-12-20 13:19 ` st3r4g
                   ` (14 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-20 13:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546365342

Comment:
I think this should be `replaces=` and should be in the `mesa-dri` subpkg. Also, the syntax for provides is `provides="$pkg-$version"`

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
  2020-12-20 11:45 ` [PR REVIEW] " st3r4g
@ 2020-12-20 12:08 ` st3r4g
  2020-12-20 13:18 ` st3r4g
                   ` (15 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-20 12:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546365342

Comment:
I think this should be `replaces=` and should be in the `mesa-dri` subpkg. Or maybe both `replaces=` and `provides=`. Also, it should be `provides="$pkg-$version"`

^ permalink raw reply	[flat|nested] 36+ messages in thread

* Re: [PR REVIEW] mesa: update to 20.3.1.
  2020-12-20  3:37 [PR PATCH] " ericonr
@ 2020-12-20 11:45 ` st3r4g
  2020-12-20 12:08 ` st3r4g
                   ` (16 subsequent siblings)
  17 siblings, 0 replies; 36+ messages in thread
From: st3r4g @ 2020-12-20 11:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27291#discussion_r546365342

Comment:
I think this should be `replaces=` and should be in the `mesa-dri` subpkg

^ permalink raw reply	[flat|nested] 36+ messages in thread

end of thread, other threads:[~2020-12-21 17:57 UTC | newest]

Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17  2:57 [PR PATCH] mesa: update to 20.3.1 HadetTheUndying
2020-12-17 14:06 ` [PR REVIEW] " ericonr
2020-12-17 14:07 ` ericonr
2020-12-17 14:08 ` ericonr
2020-12-17 14:08 ` ericonr
2020-12-17 20:50 ` [PR PATCH] [Updated] " HadetTheUndying
2020-12-17 20:51 ` HadetTheUndying
2020-12-17 20:51 ` [PR REVIEW] " HadetTheUndying
2020-12-17 21:05 ` ericonr
2020-12-18  2:49 ` [PR PATCH] [Updated] " HadetTheUndying
2020-12-19  5:25 ` q66
2020-12-20  1:47 ` travankor
2020-12-20  1:51 ` HadetTheUndying
2020-12-20  1:58 ` ericonr
2020-12-20  2:07 ` HadetTheUndying
2020-12-20  3:37 ` ericonr
2020-12-20  3:45 ` HadetTheUndying
2020-12-20  3:45 ` [PR PATCH] [Closed]: " HadetTheUndying
2020-12-20  3:37 [PR PATCH] " ericonr
2020-12-20 11:45 ` [PR REVIEW] " st3r4g
2020-12-20 12:08 ` st3r4g
2020-12-20 13:18 ` st3r4g
2020-12-20 13:19 ` st3r4g
2020-12-20 14:44 ` ericonr
2020-12-20 14:52 ` st3r4g
2020-12-20 16:33 ` st3r4g
2020-12-20 16:38 ` st3r4g
2020-12-20 16:42 ` st3r4g
2020-12-20 23:01 ` q66
2020-12-20 23:24 ` st3r4g
2020-12-20 23:36 ` q66
2020-12-20 23:37 ` q66
2020-12-21  2:29 ` ericonr
2020-12-21 12:35 ` ericonr
2020-12-21 14:52 ` st3r4g
2020-12-21 17:48 ` q66
2020-12-21 17:57 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).