* [PR PATCH] gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
@ 2020-10-28 17:46 Logarithmus
2020-11-09 15:36 ` ericonr
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Logarithmus @ 2020-10-28 17:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
There is a new pull request by Logarithmus against master on the void-packages repository
https://github.com/Logarithmus/void-packages gpsim
https://github.com/void-linux/void-packages/pull/25944
gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
When using `breakpoints.h` from `gpsim-devel` package, program fails to build due to missing `config.h` header.
AFAIK this header is generated automatically by `autotools` and exists only during the build process.
Another fix is installing `eXdbm` headers along with `gpsim`.
A patch file from https://github.com/void-linux/void-packages/pull/25944.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpsim-25944.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]
From 44288d1a1b1ff845e0fb57654853e45cb7e05746 Mon Sep 17 00:00:00 2001
From: Artur Sinila <opensource@logarithmus.dev>
Date: Fri, 23 Oct 2020 01:48:33 +0300
Subject: [PATCH] gpsim: remove #include "../config.h" from breakpoints.h to
prevent errors about missing config.h
---
srcpkgs/gpsim/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gpsim/template b/srcpkgs/gpsim/template
index 1778e73658e..187584a68f9 100644
--- a/srcpkgs/gpsim/template
+++ b/srcpkgs/gpsim/template
@@ -1,7 +1,7 @@
# Template file for 'gpsim'
pkgname=gpsim
version=0.31.0
-revision=1
+revision=2
build_style=gnu-configure
hostmakedepends="pkg-config"
makedepends="gtk+-devel popt-devel readline-devel"
@@ -13,7 +13,8 @@ distfiles="https://sourceforge.net/projects/gpsim/files/gpsim/${version}/gpsim-$
checksum=110ee6be3a5d02b32803a91e480cbfc9d423ef72e0830703fc0bc97b9569923f
pre_configure() {
- vsed -i -e 's/#include "error.h"//' src/modules.cc
+ vsed -i src/modules.cc -e 's/#include "error.h"//'
+ vsed -i src/breakpoints.h -e 's/#include "\.\.\/config.h"//'
}
gpsim-devel_package() {
@@ -21,6 +22,7 @@ gpsim-devel_package() {
depends="gpsim-${version}_${revision} gtk+-devel popt-devel readline-devel"
pkg_install() {
vmove usr/include/gpsim
+ vmove usr/include/eXdbm
vmove "usr/lib/*.a"
vmove "usr/lib/*.so"
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
2020-10-28 17:46 [PR PATCH] gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h Logarithmus
@ 2020-11-09 15:36 ` ericonr
2020-11-11 1:43 ` [PR PATCH] [Updated] " Logarithmus
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-11-09 15:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25944#issuecomment-724089820
Comment:
I think adding more headers is more correct, if that's possible. They should probably have a `#ifdef HAVE_CONFIG_H` guard around that include, though.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR PATCH] [Updated] gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
2020-10-28 17:46 [PR PATCH] gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h Logarithmus
2020-11-09 15:36 ` ericonr
@ 2020-11-11 1:43 ` Logarithmus
2020-11-11 2:13 ` Logarithmus
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Logarithmus @ 2020-11-11 1:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
There is an updated pull request by Logarithmus against master on the void-packages repository
https://github.com/Logarithmus/void-packages gpsim
https://github.com/void-linux/void-packages/pull/25944
gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
When using `breakpoints.h` from `gpsim-devel` package, program fails to build due to missing `config.h` header.
AFAIK this header is generated automatically by `autotools` and exists only during the build process.
Another fix is installing `eXdbm` headers along with `gpsim`.
A patch file from https://github.com/void-linux/void-packages/pull/25944.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpsim-25944.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]
From 9be79593d31cb3e67f2d55f41358e7c05ac8b88f Mon Sep 17 00:00:00 2001
From: Artur Sinila <opensource@logarithmus.dev>
Date: Fri, 23 Oct 2020 01:48:33 +0300
Subject: [PATCH] gpsim: remove #include "../config.h" from breakpoints.h to
prevent errors about missing config.h
---
srcpkgs/gpsim/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gpsim/template b/srcpkgs/gpsim/template
index 1778e73658e..187584a68f9 100644
--- a/srcpkgs/gpsim/template
+++ b/srcpkgs/gpsim/template
@@ -1,7 +1,7 @@
# Template file for 'gpsim'
pkgname=gpsim
version=0.31.0
-revision=1
+revision=2
build_style=gnu-configure
hostmakedepends="pkg-config"
makedepends="gtk+-devel popt-devel readline-devel"
@@ -13,7 +13,8 @@ distfiles="https://sourceforge.net/projects/gpsim/files/gpsim/${version}/gpsim-$
checksum=110ee6be3a5d02b32803a91e480cbfc9d423ef72e0830703fc0bc97b9569923f
pre_configure() {
- vsed -i -e 's/#include "error.h"//' src/modules.cc
+ vsed -i src/modules.cc -e 's/#include "error.h"//'
+ vsed -i src/breakpoints.h -e 's/#include "\.\.\/config.h"//'
}
gpsim-devel_package() {
@@ -21,6 +22,7 @@ gpsim-devel_package() {
depends="gpsim-${version}_${revision} gtk+-devel popt-devel readline-devel"
pkg_install() {
vmove usr/include/gpsim
+ vmove usr/include/eXdbm
vmove "usr/lib/*.a"
vmove "usr/lib/*.so"
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR PATCH] [Updated] gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
2020-10-28 17:46 [PR PATCH] gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h Logarithmus
2020-11-09 15:36 ` ericonr
2020-11-11 1:43 ` [PR PATCH] [Updated] " Logarithmus
@ 2020-11-11 2:13 ` Logarithmus
2020-12-18 0:48 ` [PR PATCH] [Closed]: " sgn
2020-12-18 0:48 ` sgn
4 siblings, 0 replies; 6+ messages in thread
From: Logarithmus @ 2020-11-11 2:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
There is an updated pull request by Logarithmus against master on the void-packages repository
https://github.com/Logarithmus/void-packages gpsim
https://github.com/void-linux/void-packages/pull/25944
gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
When using `breakpoints.h` from `gpsim-devel` package, program fails to build due to missing `config.h` header.
AFAIK this header is generated automatically by `autotools` and exists only during the build process.
Another fix is installing `eXdbm` headers along with `gpsim`.
A patch file from https://github.com/void-linux/void-packages/pull/25944.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gpsim-25944.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]
From 44288d1a1b1ff845e0fb57654853e45cb7e05746 Mon Sep 17 00:00:00 2001
From: Artur Sinila <opensource@logarithmus.dev>
Date: Fri, 23 Oct 2020 01:48:33 +0300
Subject: [PATCH] gpsim: remove #include "../config.h" from breakpoints.h to
prevent errors about missing config.h
---
srcpkgs/gpsim/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/gpsim/template b/srcpkgs/gpsim/template
index 1778e73658e..187584a68f9 100644
--- a/srcpkgs/gpsim/template
+++ b/srcpkgs/gpsim/template
@@ -1,7 +1,7 @@
# Template file for 'gpsim'
pkgname=gpsim
version=0.31.0
-revision=1
+revision=2
build_style=gnu-configure
hostmakedepends="pkg-config"
makedepends="gtk+-devel popt-devel readline-devel"
@@ -13,7 +13,8 @@ distfiles="https://sourceforge.net/projects/gpsim/files/gpsim/${version}/gpsim-$
checksum=110ee6be3a5d02b32803a91e480cbfc9d423ef72e0830703fc0bc97b9569923f
pre_configure() {
- vsed -i -e 's/#include "error.h"//' src/modules.cc
+ vsed -i src/modules.cc -e 's/#include "error.h"//'
+ vsed -i src/breakpoints.h -e 's/#include "\.\.\/config.h"//'
}
gpsim-devel_package() {
@@ -21,6 +22,7 @@ gpsim-devel_package() {
depends="gpsim-${version}_${revision} gtk+-devel popt-devel readline-devel"
pkg_install() {
vmove usr/include/gpsim
+ vmove usr/include/eXdbm
vmove "usr/lib/*.a"
vmove "usr/lib/*.so"
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR PATCH] [Closed]: gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
2020-10-28 17:46 [PR PATCH] gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h Logarithmus
` (2 preceding siblings ...)
2020-11-11 2:13 ` Logarithmus
@ 2020-12-18 0:48 ` sgn
2020-12-18 0:48 ` sgn
4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2020-12-18 0:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
There's a closed pull request on the void-packages repository
gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
https://github.com/void-linux/void-packages/pull/25944
Description:
When using `breakpoints.h` from `gpsim-devel` package, program fails to build due to missing `config.h` header.
AFAIK this header is generated automatically by `autotools` and exists only during the build process.
Another fix is installing `eXdbm` headers along with `gpsim`.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h
2020-10-28 17:46 [PR PATCH] gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h Logarithmus
` (3 preceding siblings ...)
2020-12-18 0:48 ` [PR PATCH] [Closed]: " sgn
@ 2020-12-18 0:48 ` sgn
4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2020-12-18 0:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/25944#issuecomment-747797281
Comment:
Next time please move those patching into `post_patch`, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-18 0:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 17:46 [PR PATCH] gpsim: remove #include "../config.h" from breakpoints.h to prevent errors about missing config.h Logarithmus
2020-11-09 15:36 ` ericonr
2020-11-11 1:43 ` [PR PATCH] [Updated] " Logarithmus
2020-11-11 2:13 ` Logarithmus
2020-12-18 0:48 ` [PR PATCH] [Closed]: " sgn
2020-12-18 0:48 ` sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).