Re: [PR REVIEW] New package: Itch

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r545593123

Comment:
Maybe ask for upstream to include the script? It looks useful.

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r674341085

Comment:
It's electron, you need to work, I opened an issue to have musl versions of the framework.

https://github.com/itchio/itch/issues/2683

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r674334251

Comment:
This is the author's thing of the software, who preferred to use this arguments.

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r673083370

Comment:
Does it actually need the framework to go anything useful?

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r673082245

Comment:
Huh, why would that happen...

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r672960432

Comment:
In the case with musl, compile with archs="x86_64*" and patch_args="-Np0", but application does framework donwload to work, which are compiled for GNU libc. 

Which are these: 

https://broth.itch.ovh/itch/linux-amd64/25.5.1/archive/default

https://broth.itch.ovh/butler/linux-amd64/15.21.0/archive/default

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 3269 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r672952328

Comment:
With EXEC, it occurs that application understands, each new startup is the first, due there is it, always does the framework download, even if you have done it previously!

2021/07/19 22:29:59 itch-setup will log to /tmp/itch-setup-log.txt
2021/07/19 22:29:59 =========================================
2021/07/19 22:29:59 itch-setup "head, no build date" starting up at "2021-07-19 22:29:59.997866826 -0300 -03 m=+0.023844080" with arguments:
2021/07/19 22:29:59 "itch-setup"
2021/07/19 22:29:59 =========================================
2021/07/19 22:29:59 App name detected: itch
2021/07/19 22:29:59 Locale:  en-US
2021/07/19 22:30:00 Initializing installer GUI...
2021/07/19 22:30:00 Using GTK UI
2021/07/19 22:30:00 Initializing (itch) multiverse @ (/home/bugcrazy/.itch)
2021/07/19 22:30:00 (/home/bugcrazy/.itch)(current = "25.5.1", ready = "")
2021/07/19 22:30:00 Loading image resources...
2021/07/19 22:30:00 Setting up progress bar...
2021/07/19 22:30:00 Positioning and showing window...
2021/07/19 22:30:01 Will install version 25.5.1
2021/07/19 22:30:03 Reading signature...
2021/07/19 22:30:03 Installing 197.43 MiB (295 files, 25 dirs, 0 symlinks)
2021/07/19 22:30:03 Looks like (25.5.1) is already installed to (/home/bugcrazy/.itch/app-25.5.1)
2021/07/19 22:30:03 Let's just heal that
2021/07/19 22:30:03 Installing to (/home/bugcrazy/.itch/app-25.5.1)
2021/07/19 22:30:03 Healing (/home/bugcrazy/.itch/app-25.5.1)...
2021/07/19 22:30:07 0 B was healed @ 0 B/s (4s total)
2021/07/19 22:30:07 Healed in-place
2021/07/19 22:30:07 No validate handler, assuming good!
2021/07/19 22:30:07 Determining whether or not we've been installed via an OS package...
2021/07/19 22:30:07 Our execPath (/usr/bin/itch-setup) is somewhere in /usr, not installing desktop files
2021/07/19 22:30:07 Launching (25.5.1) from (/home/bugcrazy/.itch/app-25.5.1)
2021/07/19 22:30:07 Kernel should support SUID sandboxing, leaving it enabled
2021/07/19 22:30:07 App launched, getting out of the way

With the standard argument this does not occur. 

2021/07/19 22:36:37 itch-setup will log to /tmp/itch-setup-log.txt
2021/07/19 22:36:37 =========================================
2021/07/19 22:36:37 itch-setup "head, no build date" starting up at "2021-07-19 22:36:37.731537432 -0300 -03 m=+0.078722338" with arguments:
2021/07/19 22:36:37 "itch-setup"
2021/07/19 22:36:37 "--prefer-launch"
2021/07/19 22:36:37 "--"
2021/07/19 22:36:37 "@$"
2021/07/19 22:36:37 =========================================
2021/07/19 22:36:37 App name detected: itch
2021/07/19 22:36:37 Locale:  en-US
2021/07/19 22:36:37 Initializing installer GUI...
2021/07/19 22:36:37 Using GTK UI
2021/07/19 22:36:37 Initializing (itch) multiverse @ (/home/bugcrazy/.itch)
2021/07/19 22:36:37 (/home/bugcrazy/.itch)(current = "25.5.1", ready = "")
2021/07/19 22:36:37 Launch preferred, attempting...
2021/07/19 22:36:37 Launching (25.5.1) from (/home/bugcrazy/.itch/app-25.5.1)
2021/07/19 22:36:37 Kernel should support SUID sandboxing, leaving it enabled
2021/07/19 22:36:37 App launched, getting out of the way

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r671592866

Comment:
Why is this arch restricted? One can run windows games on musl...

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r671592699

Comment:
In this case we know better; use `exec`.

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r617157584

Comment:
Done!

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r617149370

Comment:
Ok, you can use a specific tag from that repo. I just want to avoid pulling from the development branch, since any change they make will break our build.

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r617144621

Comment:
It will stay like this! 

 https://raw.githubusercontent.com/itchio/itch/v25.4.1/release/images/itch-icons/icon16.png
 https://raw.githubusercontent.com/itchio/itch/v25.4.1/release/images/itch-icons/icon32.png
 https://raw.githubusercontent.com/itchio/itch/v25.4.1/release/images/itch-icons/icon48.png

I'm using the framework icons! 

https://github.com/itchio/itch

The compiled app does not have these icons! 

https://github.com/itchio/itch-setup

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r615344124

Comment:
Please use the icons from version instead of master

```suggestion
 https://raw.githubusercontent.com/itchio/itch/v${version}/release/images/itch-icons/icon16.png
 https://raw.githubusercontent.com/itchio/itch/master/release/images/itch-icons/icon32.png
 https://raw.githubusercontent.com/itchio/itch/master/release/images/itch-icons/icon48.png"
```

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r548747150

Comment:
In this version 1.18.0 you needed it, now in version 1.24.0 you don't need it, I will update the template and make squash the commits.

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r548746715

Comment:
The vinstall command does not work for this, as the files are downloaded separately and then moved to a folder.

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r548746127

Comment:
Only these two architectures are supported in the project code to compile.

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r548744352

Comment:
This code is provided by the project, I am following the recommendation, the project does not have a script itself, but it does provide this code.

Re: [PR REVIEW] New package: Itch

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

New review comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r548743019

Comment:
It only offers the code, no .desktop file, this code that I use to create the file.
https://github.com/itchio/itch-setup/blob/4a138757685a092640aa5fbb49c6b8133c5325cf/native/native_linux.go#L480

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r545593781

Comment:
Also, it should be `exec itch-setup`

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r545593242

Comment:
I don't think it needs to be restricted, let people install games wherever they want, they can have fun trying to run them :)

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r545593375

Comment:
Please use vinstall here as well.

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r545593616

Comment:
Why can't this use the `do_build` function from the Go build style?

Re: [PR REVIEW] New package: Itch

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22863#discussion_r545592078

Comment:
I greatly dislike creating our own desktop files. Does upstream not provide one at all?