* [PR PATCH] nwipe: update to 0.30.
@ 2020-12-21 18:08 ndowens
2020-12-21 18:17 ` [PR REVIEW] " ericonr
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: ndowens @ 2020-12-21 18:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
There is a new pull request by ndowens against master on the void-packages repository
https://github.com/ndowens/void-packages nwipe
https://github.com/void-linux/void-packages/pull/27327
nwipe: update to 0.30.
A patch file from https://github.com/void-linux/void-packages/pull/27327.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nwipe-27327.patch --]
[-- Type: text/x-diff, Size: 2739 bytes --]
From adce0c343935ba78e566c652e244bf85a7c0830b Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Mon, 21 Dec 2020 12:07:03 -0600
Subject: [PATCH] nwipe: update to 0.30.
---
.../nwipe/patches/0001-musl-build-fix.patch | 27 +++++++++++++++++++
srcpkgs/nwipe/patches/musl.patch | 16 -----------
srcpkgs/nwipe/template | 6 ++---
3 files changed, 30 insertions(+), 19 deletions(-)
create mode 100644 srcpkgs/nwipe/patches/0001-musl-build-fix.patch
delete mode 100644 srcpkgs/nwipe/patches/musl.patch
diff --git a/srcpkgs/nwipe/patches/0001-musl-build-fix.patch b/srcpkgs/nwipe/patches/0001-musl-build-fix.patch
new file mode 100644
index 00000000000..6d209269cde
--- /dev/null
+++ b/srcpkgs/nwipe/patches/0001-musl-build-fix.patch
@@ -0,0 +1,27 @@
+From 8871bf692e3b5012fdb0ea069b81c6a8db8ef85f Mon Sep 17 00:00:00 2001
+From: Nathan Owens <ndowens@artixlinux.org>
+Date: Mon, 21 Dec 2020 12:05:43 -0600
+Subject: [PATCH] musl build fix
+
+musl does not have bits/sigthread.h
+---
+ src/nwipe.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git src/nwipe.c src/nwipe.c
+index 2c9c851..487177e 100644
+--- src/nwipe.c
++++ src/nwipe.c
+@@ -32,7 +32,9 @@
+ #include <signal.h>
+ #include <pthread.h>
+ #include <sys/types.h>
++#if defined(__GLIBC__)
+ #include <bits/sigthread.h>
++#endif
+
+ #include "nwipe.h"
+ #include "context.h"
+--
+2.29.2
+
diff --git a/srcpkgs/nwipe/patches/musl.patch b/srcpkgs/nwipe/patches/musl.patch
deleted file mode 100644
index 1cdb928fe0a..00000000000
--- a/srcpkgs/nwipe/patches/musl.patch
+++ /dev/null
@@ -1,16 +0,0 @@
-diff --git src/nwipe.c src/nwipe.c
-index c7586fd..ec2eb1d 100644
---- src/nwipe.c
-+++ src/nwipe.c
-@@ -26,9 +26,10 @@
- #include <time.h>
- #include <signal.h>
- #include <pthread.h>
-+#if defined(__GLIBC__)
- #include <bits/pthreadtypes.h>
- #include <bits/sigthread.h>
--
-+#endif
- #include "nwipe.h"
- #include "context.h"
- #include "method.h"
diff --git a/srcpkgs/nwipe/template b/srcpkgs/nwipe/template
index b68af7a11b4..e3cbc2b3b65 100644
--- a/srcpkgs/nwipe/template
+++ b/srcpkgs/nwipe/template
@@ -1,6 +1,6 @@
# Template file for 'nwipe'
pkgname=nwipe
-version=0.28
+version=0.30
revision=1
build_style=gnu-configure
hostmakedepends="automake pkg-config"
@@ -10,10 +10,10 @@ maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-2.0-only"
homepage="https://github.com/martijnvanbrummelen/nwipe"
distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=4f1ccf952cd3cdb00c8ccbfe4c47f94eaecf20a98248aaf83a0c1b2198e2ce13
+checksum=85faaa9c65557a6be187f0176c5b778e8cd080e1cd9b8a7168a8a9b8e410d46d
CFLAGS="-D_FILE_OFFSET_BITS=64"
pre_configure() {
- sh init.sh
+ autoreconf -fi
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] nwipe: update to 0.30.
2020-12-21 18:08 [PR PATCH] nwipe: update to 0.30 ndowens
@ 2020-12-21 18:17 ` ericonr
2020-12-21 18:24 ` ndowens
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-12-21 18:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27327#discussion_r546856857
Comment:
If you want to upstream this (please do :) ), just tell upstream that it's completely unnecessary. This is a glibc internal file, you are never supposed to touch it yourself.
They should just define something like `#define _XOPEN_SOURCE 500` at the top of their file, if it doesn't build now.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] nwipe: update to 0.30.
2020-12-21 18:08 [PR PATCH] nwipe: update to 0.30 ndowens
2020-12-21 18:17 ` [PR REVIEW] " ericonr
@ 2020-12-21 18:24 ` ndowens
2020-12-21 18:26 ` ndowens
2020-12-22 0:08 ` [PR PATCH] [Merged]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: ndowens @ 2020-12-21 18:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New review comment by ndowens on void-packages repository
https://github.com/void-linux/void-packages/pull/27327#discussion_r546859918
Comment:
Linked issue opened upstream
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] nwipe: update to 0.30.
2020-12-21 18:08 [PR PATCH] nwipe: update to 0.30 ndowens
2020-12-21 18:17 ` [PR REVIEW] " ericonr
2020-12-21 18:24 ` ndowens
@ 2020-12-21 18:26 ` ndowens
2020-12-22 0:08 ` [PR PATCH] [Merged]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: ndowens @ 2020-12-21 18:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New review comment by ndowens on void-packages repository
https://github.com/void-linux/void-packages/pull/27327#discussion_r546859918
Comment:
Linked issue opened upstream. Also glibc builds without that header as well
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: nwipe: update to 0.30.
2020-12-21 18:08 [PR PATCH] nwipe: update to 0.30 ndowens
` (2 preceding siblings ...)
2020-12-21 18:26 ` ndowens
@ 2020-12-22 0:08 ` ericonr
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-12-22 0:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
There's a merged pull request on the void-packages repository
nwipe: update to 0.30.
https://github.com/void-linux/void-packages/pull/27327
Description:
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-22 0:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 18:08 [PR PATCH] nwipe: update to 0.30 ndowens
2020-12-21 18:17 ` [PR REVIEW] " ericonr
2020-12-21 18:24 ` ndowens
2020-12-21 18:26 ` ndowens
2020-12-22 0:08 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).