* [PR PATCH] jrnl: update to 2.5
@ 2020-12-22 9:59 Eluminae
2020-12-22 12:38 ` sgn
2020-12-22 12:39 ` [PR PATCH] [Closed]: " sgn
0 siblings, 2 replies; 12+ messages in thread
From: Eluminae @ 2020-12-22 9:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
There is a new pull request by Eluminae against master on the void-packages repository
https://github.com/Eluminae/void-packages jrnl
https://github.com/void-linux/void-packages/pull/27347
jrnl: update to 2.5
A patch file from https://github.com/void-linux/void-packages/pull/27347.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jrnl-27347.patch --]
[-- Type: text/x-diff, Size: 950 bytes --]
From b0ff730a20061ddee1a356e521bcec9ce5ae4c38 Mon Sep 17 00:00:00 2001
From: Reed Wade <reedwade@misterbanal.net>
Date: Tue, 22 Dec 2020 10:57:58 +0100
Subject: [PATCH] jrnl: update to 2.5
---
srcpkgs/jrnl/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/jrnl/template b/srcpkgs/jrnl/template
index c5c03dd9805..1f511a11b92 100644
--- a/srcpkgs/jrnl/template
+++ b/srcpkgs/jrnl/template
@@ -1,6 +1,6 @@
# Template file for 'jrnl'
pkgname=jrnl
-version=2.4.5
+version=2.5
revision=2
build_style=python3-module
hostmakedepends="python3-setuptools"
@@ -13,4 +13,4 @@ license="GPL-3.0-only"
homepage="https://jrnl.sh"
changelog="https://raw.githubusercontent.com/jrnl-org/jrnl/develop/CHANGELOG.md"
distfiles="${PYPI_SITE}/j/jrnl/jrnl-${version}.tar.gz"
-checksum=a5f069efcaa3f5d95cc7712178b3f92915f67eed4034e5f257cc063c6b0e74d9
+checksum=3984d402feb18538fca6bbba3e0b9900b2f78af0a800fffa735ab9b08896ffda
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PR PATCH] jrnl: update to 2.6.
@ 2020-12-21 17:02 ndowens
2020-12-22 3:58 ` jrnl: update to 2.5 ericonr
0 siblings, 1 reply; 12+ messages in thread
From: ndowens @ 2020-12-21 17:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
There is a new pull request by ndowens against master on the void-packages repository
https://github.com/ndowens/void-packages jrnl
https://github.com/void-linux/void-packages/pull/27324
jrnl: update to 2.6.
superceeds #26398
A patch file from https://github.com/void-linux/void-packages/pull/27324.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jrnl-27324.patch --]
[-- Type: text/x-diff, Size: 1118 bytes --]
From f9ac93c0e5952988d21fa7c0c1d53f0e93ffc362 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Mon, 21 Dec 2020 11:01:56 -0600
Subject: [PATCH] jrnl: update to 2.6.
---
srcpkgs/jrnl/template | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/jrnl/template b/srcpkgs/jrnl/template
index c5c03dd9805..14d12b70acb 100644
--- a/srcpkgs/jrnl/template
+++ b/srcpkgs/jrnl/template
@@ -1,7 +1,7 @@
# Template file for 'jrnl'
pkgname=jrnl
-version=2.4.5
-revision=2
+version=2.6
+revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3-ansiwrap python3-asteval python3-colorama python3-cryptography
@@ -13,4 +13,8 @@ license="GPL-3.0-only"
homepage="https://jrnl.sh"
changelog="https://raw.githubusercontent.com/jrnl-org/jrnl/develop/CHANGELOG.md"
distfiles="${PYPI_SITE}/j/jrnl/jrnl-${version}.tar.gz"
-checksum=a5f069efcaa3f5d95cc7712178b3f92915f67eed4034e5f257cc063c6b0e74d9
+checksum=ea2c35737bdda0ab5f8887d81733e1ad7d1f6e61fa13745102651386b530c15d
+
+do_check() {
+ : # Downloads many deps and no tests are ran
+}
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PR PATCH] jrnl: update to 2.5.
@ 2020-11-15 11:01 ashpooljh
2020-11-19 4:17 ` ericonr
` (7 more replies)
0 siblings, 8 replies; 12+ messages in thread
From: ashpooljh @ 2020-11-15 11:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
There is a new pull request by ashpooljh against master on the void-packages repository
https://github.com/ashpooljh/void-packages jrnl
https://github.com/void-linux/void-packages/pull/26398
jrnl: update to 2.5.
A patch file from https://github.com/void-linux/void-packages/pull/26398.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jrnl-26398.patch --]
[-- Type: text/x-diff, Size: 1045 bytes --]
From 219ef6fea07182b6e7ba70d348eeccc38b6d74ee Mon Sep 17 00:00:00 2001
From: Artem Zhurikhin <ashpool@xecut.net>
Date: Sun, 15 Nov 2020 13:58:54 +0300
Subject: [PATCH] jrnl: update to 2.5.
---
srcpkgs/jrnl/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/jrnl/template b/srcpkgs/jrnl/template
index c5c03dd9805..447fa23011b 100644
--- a/srcpkgs/jrnl/template
+++ b/srcpkgs/jrnl/template
@@ -1,7 +1,7 @@
# Template file for 'jrnl'
pkgname=jrnl
-version=2.4.5
-revision=2
+version=2.5
+revision=1
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="python3-ansiwrap python3-asteval python3-colorama python3-cryptography
@@ -13,4 +13,4 @@ license="GPL-3.0-only"
homepage="https://jrnl.sh"
changelog="https://raw.githubusercontent.com/jrnl-org/jrnl/develop/CHANGELOG.md"
distfiles="${PYPI_SITE}/j/jrnl/jrnl-${version}.tar.gz"
-checksum=a5f069efcaa3f5d95cc7712178b3f92915f67eed4034e5f257cc063c6b0e74d9
+checksum=3984d402feb18538fca6bbba3e0b9900b2f78af0a800fffa735ab9b08896ffda
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: jrnl: update to 2.5.
2020-11-15 11:01 [PR PATCH] " ashpooljh
@ 2020-11-19 4:17 ` ericonr
2020-11-19 14:08 ` ashpooljh
` (6 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2020-11-19 4:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26398#issuecomment-730118857
Comment:
Do you think you could add all the necessary `checkdepends` so we don't get any warnings like the one below:
```
WARNING: The pip package is not available, falling back to EasyInstall for handling setup_requires/test_requires; this is deprecated and will be removed in a future version.
```
Build with `./xbps-src -Q pkg jrnl` to check.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: jrnl: update to 2.5.
2020-11-15 11:01 [PR PATCH] " ashpooljh
2020-11-19 4:17 ` ericonr
@ 2020-11-19 14:08 ` ashpooljh
2020-11-19 14:09 ` ashpooljh
` (5 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: ashpooljh @ 2020-11-19 14:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
New comment by ashpooljh on void-packages repository
https://github.com/void-linux/void-packages/pull/26398#issuecomment-730399675
Comment:
@ericonr Apparently the `checkdepends` in this case would be the same as `depends`. Should I copy-paste the whole list or is `checkdepends="${depends}"` acceptable? Either way this fixes the warnings your mentioned.
When I run `./xbps-src -Q pkg jrnl`, however, I get [this output](http://sprunge.us/DkhQC0) with an error from `unittest`. Methinks this way of testing this particular package is not supported or is broken, so we shouldn't be worrying about it.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: jrnl: update to 2.5.
2020-11-15 11:01 [PR PATCH] " ashpooljh
2020-11-19 4:17 ` ericonr
2020-11-19 14:08 ` ashpooljh
@ 2020-11-19 14:09 ` ashpooljh
2020-11-19 15:03 ` ericonr
` (4 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: ashpooljh @ 2020-11-19 14:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
New comment by ashpooljh on void-packages repository
https://github.com/void-linux/void-packages/pull/26398#issuecomment-730399675
Comment:
@ericonr Apparently the `checkdepends` in this case would be the same as `depends`. Should I copy-paste the whole list or is `checkdepends="${depends}"` acceptable? Either way this fixes the warnings you mentioned.
When I run `./xbps-src -Q pkg jrnl`, however, I get [this output](http://sprunge.us/DkhQC0) with an error from `unittest`. Methinks this way of testing this particular package is not supported or is broken, so we shouldn't be worrying about it.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: jrnl: update to 2.5.
2020-11-15 11:01 [PR PATCH] " ashpooljh
` (2 preceding siblings ...)
2020-11-19 14:09 ` ashpooljh
@ 2020-11-19 15:03 ` ericonr
2020-11-19 15:05 ` ericonr
` (3 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2020-11-19 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26398#issuecomment-730434146
Comment:
> checkdepends="${depends}" acceptable
Acceptable and preferred :)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: jrnl: update to 2.5.
2020-11-15 11:01 [PR PATCH] " ashpooljh
` (3 preceding siblings ...)
2020-11-19 15:03 ` ericonr
@ 2020-11-19 15:05 ` ericonr
2020-11-20 0:44 ` ashpooljh
` (2 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2020-11-19 15:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26398#issuecomment-730435530
Comment:
I can't open the paste, but I can guess at the output. Might be best to use upstream's suggested method: https://github.com/jrnl-org/jrnl/blob/develop/CONTRIBUTING.md#common-development-commands
`do_check() { make test }`
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: jrnl: update to 2.5.
2020-11-15 11:01 [PR PATCH] " ashpooljh
` (4 preceding siblings ...)
2020-11-19 15:05 ` ericonr
@ 2020-11-20 0:44 ` ashpooljh
2020-11-20 0:44 ` ashpooljh
2020-11-20 0:45 ` ashpooljh
7 siblings, 0 replies; 12+ messages in thread
From: ashpooljh @ 2020-11-20 0:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
New comment by ashpooljh on void-packages repository
https://github.com/void-linux/void-packages/pull/26398#issuecomment-730727935
Comment:
Sorry, I haven't yet found a way to make this work. There's no `Makefile` bundled with the Python module on PyPI.
Things we can try:
- change the upstream to GitHub and build it using the `gnu-makefile` style, not `python3-module`, and use `make test` for checking, or
- figure out why `python3-module`-style `do_check()` fails and patch the package to pass it.
For now, I added the `checkdepends` to fix the warnings, but the check phase remains broken. For anyone who'd like to try fix it, I'll paste the full output of this phase below.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: jrnl: update to 2.5.
2020-11-15 11:01 [PR PATCH] " ashpooljh
` (5 preceding siblings ...)
2020-11-20 0:44 ` ashpooljh
@ 2020-11-20 0:44 ` ashpooljh
2020-11-20 0:45 ` ashpooljh
7 siblings, 0 replies; 12+ messages in thread
From: ashpooljh @ 2020-11-20 0:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 3028 bytes --]
New comment by ashpooljh on void-packages repository
https://github.com/void-linux/void-packages/pull/26398#issuecomment-730728083
Comment:
```
=> jrnl-2.5_1: running do_check ...
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
creating jrnl.egg-info
writing jrnl.egg-info/PKG-INFO
writing dependency_links to jrnl.egg-info/dependency_links.txt
writing entry points to jrnl.egg-info/entry_points.txt
writing requirements to jrnl.egg-info/requires.txt
writing top-level names to jrnl.egg-info/top_level.txt
writing manifest file 'jrnl.egg-info/SOURCES.txt'
reading manifest file 'jrnl.egg-info/SOURCES.txt'
writing manifest file 'jrnl.egg-info/SOURCES.txt'
running build_ext
Traceback (most recent call last):
File "/builddir/jrnl-2.5/setup.py", line 46, in <module>
setup(**setup_kwargs)
File "/usr/lib/python3.9/site-packages/setuptools/__init__.py", line 153, in setup
return distutils.core.setup(**attrs)
File "/usr/lib/python3.9/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.9/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.9/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/lib/python3.9/site-packages/setuptools/command/test.py", line 232, in run
self.run_tests()
File "/usr/lib/python3.9/site-packages/setuptools/command/test.py", line 250, in run_tests
test = unittest.main(
File "/usr/lib/python3.9/unittest/main.py", line 100, in __init__
self.parseArgs(argv)
File "/usr/lib/python3.9/unittest/main.py", line 124, in parseArgs
self._do_discovery(argv[2:])
File "/usr/lib/python3.9/unittest/main.py", line 244, in _do_discovery
self.createTests(from_discovery=True, Loader=Loader)
File "/usr/lib/python3.9/unittest/main.py", line 154, in createTests
self.test = loader.discover(self.start, self.pattern, self.top)
File "/usr/lib/python3.9/unittest/loader.py", line 349, in discover
tests = list(self._find_tests(start_dir, pattern))
File "/usr/lib/python3.9/unittest/loader.py", line 405, in _find_tests
tests, should_recurse = self._find_test_path(
File "/usr/lib/python3.9/unittest/loader.py", line 483, in _find_test_path
tests = self.loadTestsFromModule(package, pattern=pattern)
File "/usr/lib/python3.9/site-packages/setuptools/command/test.py", line 50, in loadTestsFromModule
tests.append(self.loadTestsFromName(submodule))
File "/usr/lib/python3.9/unittest/loader.py", line 214, in loadTestsFromName
raise TypeError("don't know how to make test from: %s" % obj)
TypeError: don't know how to make test from: v2.5
=> ERROR: jrnl-2.5_1: do_check: 'python3 setup.py ${make_check_target} ${make_check_args}' exited with 1
=> ERROR: in do_check() at common/build-style/python3-module.sh:35
```
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: jrnl: update to 2.5.
2020-11-15 11:01 [PR PATCH] " ashpooljh
` (6 preceding siblings ...)
2020-11-20 0:44 ` ashpooljh
@ 2020-11-20 0:45 ` ashpooljh
7 siblings, 0 replies; 12+ messages in thread
From: ashpooljh @ 2020-11-20 0:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
New comment by ashpooljh on void-packages repository
https://github.com/void-linux/void-packages/pull/26398#issuecomment-730727935
Comment:
Sorry, I haven't yet found a way to make this work. There's no `Makefile` bundled with the Python module on PyPI.
Things we can try:
- change the upstream to GitHub and build it using the `gnu-makefile` style, not `python3-module`, and use `make test` for checking, or
- figure out why `python3-module`-style `do_check()` fails and patch the package to pass it.
For now, I added the `checkdepends` to fix the warnings, but the check phase remains broken. For anyone who'd like to try to fix it, I'll paste the full output of this phase below.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-12-22 12:39 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-22 9:59 [PR PATCH] jrnl: update to 2.5 Eluminae
2020-12-22 12:38 ` sgn
2020-12-22 12:39 ` [PR PATCH] [Closed]: " sgn
-- strict thread matches above, loose matches on Subject: below --
2020-12-21 17:02 [PR PATCH] jrnl: update to 2.6 ndowens
2020-12-22 3:58 ` jrnl: update to 2.5 ericonr
2020-11-15 11:01 [PR PATCH] " ashpooljh
2020-11-19 4:17 ` ericonr
2020-11-19 14:08 ` ashpooljh
2020-11-19 14:09 ` ashpooljh
2020-11-19 15:03 ` ericonr
2020-11-19 15:05 ` ericonr
2020-11-20 0:44 ` ashpooljh
2020-11-20 0:44 ` ashpooljh
2020-11-20 0:45 ` ashpooljh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).