[PR PATCH] amfora: update to 1.7.0

[PR PATCH] amfora: update to 1.7.0

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

There is a new pull request by Eluminae against master on the void-packages repository

https://github.com/Eluminae/void-packages amfora1.7
https://github.com/void-linux/void-packages/pull/27351

amfora: update to 1.7.0


A patch file from https://github.com/void-linux/void-packages/pull/27351.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-amfora1.7-27351.patch --]
[-- Type: text/x-diff, Size: 1150 bytes --]

From 3a7d1813ee8f66c189d42bdd52c7e9a598239256 Mon Sep 17 00:00:00 2001
From: Reed Wade <reedwade@misterbanal.net>
Date: Tue, 22 Dec 2020 15:46:19 +0100
Subject: [PATCH] amfora: update to 1.7.0

---
 srcpkgs/amfora/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/amfora/template b/srcpkgs/amfora/template
index 71563985278..38a8fc79aa5 100644
--- a/srcpkgs/amfora/template
+++ b/srcpkgs/amfora/template
@@ -1,6 +1,6 @@
 # Template file for 'amfora'
 pkgname=amfora
-version=1.6.0
+version=1.7.0
 revision=2
 build_style=go
 go_import_path="github.com/makeworld-the-better-one/${pkgname}"
@@ -10,7 +10,7 @@ license="GPL-3.0-only"
 homepage="https://github.com/makeworld-the-better-one/amfora"
 changelog="https://raw.githubusercontent.com/makeworld-the-better-one/amfora/master/CHANGELOG.md"
 distfiles="https://github.com/makeworld-the-better-one/${pkgname}/archive/v${version}.tar.gz"
-checksum=a02b070679718953a4184ef2b7fbeccfcdf9bf227ca1efab34ee0d7fa21e9bd9
+checksum=ac2196d9adbea639140eaebf92c4bf86ceaf2d4cadb1450ce85c19f61722ac0b
 
 post_install() {
 	vinstall amfora.desktop 644 usr/share/applications/

Re: [PR PATCH] [Updated] amfora: update to 1.7.0

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

There is an updated pull request by Eluminae against master on the void-packages repository

https://github.com/Eluminae/void-packages amfora1.7
https://github.com/void-linux/void-packages/pull/27351

amfora: update to 1.7.0


A patch file from https://github.com/void-linux/void-packages/pull/27351.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-amfora1.7-27351.patch --]
[-- Type: text/x-diff, Size: 1150 bytes --]

From 67eb8ad1b63e256db82d967787d9bd017710d7ce Mon Sep 17 00:00:00 2001
From: Reed Wade <reedwade@misterbanal.net>
Date: Tue, 22 Dec 2020 15:46:19 +0100
Subject: [PATCH] amfora: update to 1.7.1

---
 srcpkgs/amfora/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/amfora/template b/srcpkgs/amfora/template
index 71563985278..23e558d0570 100644
--- a/srcpkgs/amfora/template
+++ b/srcpkgs/amfora/template
@@ -1,6 +1,6 @@
 # Template file for 'amfora'
 pkgname=amfora
-version=1.6.0
+version=1.7.1
 revision=2
 build_style=go
 go_import_path="github.com/makeworld-the-better-one/${pkgname}"
@@ -10,7 +10,7 @@ license="GPL-3.0-only"
 homepage="https://github.com/makeworld-the-better-one/amfora"
 changelog="https://raw.githubusercontent.com/makeworld-the-better-one/amfora/master/CHANGELOG.md"
 distfiles="https://github.com/makeworld-the-better-one/${pkgname}/archive/v${version}.tar.gz"
-checksum=a02b070679718953a4184ef2b7fbeccfcdf9bf227ca1efab34ee0d7fa21e9bd9
+checksum=55a2d98e438ed3d41ad6bae6b4e04348a04e28a279fdc09866a1fdd5ee91d3ec
 
 post_install() {
 	vinstall amfora.desktop 644 usr/share/applications/

Re: amfora: update to 1.7.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/27351#issuecomment-749619415

Comment:
What do you think about installing contrib/themes/*.toml?

Re: amfora: update to 1.7.1

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by Eluminae on void-packages repository

https://github.com/void-linux/void-packages/pull/27351#issuecomment-749756221

Comment:
I think this is not the current topic.

Re: amfora: update to 1.7.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27351#issuecomment-749757385

Comment:
> I think this is not the current topic.

What do you mean?

Re: amfora: update to 1.7.1

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

New comment by Eluminae on void-packages repository

https://github.com/void-linux/void-packages/pull/27351#issuecomment-749766669

Comment:
I mean that this MR is about upgrading the software version.

Pausing the merge to think about it is could be done in any other merge request.

Anyway, I took time to reply two time on this subject in a row so I'll take this turn to give my thought.

contrib configurations are not required for the targeted release and, for me, are present in the amfora repository for discovery reason. I don't see the point on including them in the voidlinux package.

Re: amfora: update to 1.7.1

[Eluminae]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by Eluminae on void-packages repository

https://github.com/void-linux/void-packages/pull/27351#issuecomment-749768169

Comment:
> in any other merge request

s/in any other merge request/in any dedicated merge request/

Re: amfora: update to 1.7.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27351#issuecomment-749774757

Comment:
The point against doing it in any other MR, when it could be done here, is that  we avoid

- wasting builder time
- wasting user and server bandwidth with multiple updates
- wasting time by having to review yet another PR

 I'm mostly in favor of packaging the themes, since being installed in your system is much more discoverable than being only in the upstream repo. But I don't use the package, so I don't think my opinion here matters too much.

Also, please decrease the revision in the template, it should be reset to 1 on updates.

Re: amfora: update to 1.7.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/27351#issuecomment-749806474

Comment:
> contrib configurations are not required for the targeted release and, for me, are present in the amfora repository for discovery reason. I don't see the point on including them in the voidlinux package.

Themes often change with new versions when a new element is added to the UI, so I think they should be included in the package even if just in /usr/share/examples/.

Re: [PR PATCH] [Merged]: amfora: update to 1.7.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

There's a merged pull request on the void-packages repository

amfora: update to 1.7.1
https://github.com/void-linux/void-packages/pull/27351

Description:

Re: amfora: update to 1.7.1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27351#issuecomment-750301977

Comment:
Thanks!