[PR PATCH] New package: urxvt-font-size-1.3

[PR PATCH] New package: urxvt-font-size-1.3

[tommyjanna]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

There is a new pull request by tommyjanna against master on the void-packages repository

https://github.com/tommyjanna/void-packages urxvt-font-size
https://github.com/void-linux/void-packages/pull/27361

New package: urxvt-font-size-1.3


A patch file from https://github.com/void-linux/void-packages/pull/27361.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-urxvt-font-size-27361.patch --]
[-- Type: text/x-diff, Size: 1192 bytes --]

From 86bf72df3d71fdc267676218a281369ae2e50ffc Mon Sep 17 00:00:00 2001
From: tommyjanna <25873341+tommyjanna@users.noreply.github.com>
Date: Tue, 22 Dec 2020 14:02:49 -0500
Subject: [PATCH] New package: urxvt-font-size-1.3

---
 srcpkgs/urxvt-font-size/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/urxvt-font-size/template

diff --git a/srcpkgs/urxvt-font-size/template b/srcpkgs/urxvt-font-size/template
new file mode 100644
index 00000000000..8497b1db655
--- /dev/null
+++ b/srcpkgs/urxvt-font-size/template
@@ -0,0 +1,21 @@
+# Template file for 'urxvt-font-size'
+pkgname=urxvt-font-size
+version=1.3
+revision=1
+archs="i686 x86_64"
+depends="rxvt-unicode perl"
+short_desc="Extension for rxvt-unicode to control font size"
+maintainer="Tommy Janna <t.janna@queensu.ca>"
+license="MIT"
+homepage="https://github.com/majutsushi/urxvt-font-size"
+distfiles="https://github.com/majutsushi/urxvt-font-size/archive/v${version}.tar.gz"
+checksum=98bddf0dbad4e11231b07121c1c10b10116985f0ae6019173b10eaa23491a4af
+
+do_install() {
+	vinstall font-size 644 usr/lib/urxvt/perl
+}
+
+post_install() {
+	vdoc README.markdown
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: urxvt-font-size-1.3

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27361#discussion_r547455174

Comment:
Why is this set?

Re: [PR PATCH] [Updated] New package: urxvt-font-size-1.3

[tommyjanna]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

There is an updated pull request by tommyjanna against master on the void-packages repository

https://github.com/tommyjanna/void-packages urxvt-font-size
https://github.com/void-linux/void-packages/pull/27361

New package: urxvt-font-size-1.3


A patch file from https://github.com/void-linux/void-packages/pull/27361.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-urxvt-font-size-27361.patch --]
[-- Type: text/x-diff, Size: 1169 bytes --]

From 053f0039dee39eff77d495c693208c773c498cb0 Mon Sep 17 00:00:00 2001
From: tommyjanna <25873341+tommyjanna@users.noreply.github.com>
Date: Tue, 22 Dec 2020 14:02:49 -0500
Subject: [PATCH] urxvt-font-size: update to 1.3.

---
 srcpkgs/urxvt-font-size/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/urxvt-font-size/template

diff --git a/srcpkgs/urxvt-font-size/template b/srcpkgs/urxvt-font-size/template
new file mode 100644
index 00000000000..29a2370a5b0
--- /dev/null
+++ b/srcpkgs/urxvt-font-size/template
@@ -0,0 +1,20 @@
+# Template file for 'urxvt-font-size'
+pkgname=urxvt-font-size
+version=1.3
+revision=1
+depends="rxvt-unicode perl"
+short_desc="Extension for rxvt-unicode to control font size"
+maintainer="Tommy Janna <t.janna@queensu.ca>"
+license="MIT"
+homepage="https://github.com/majutsushi/urxvt-font-size"
+distfiles="https://github.com/majutsushi/urxvt-font-size/archive/v${version}.tar.gz"
+checksum=98bddf0dbad4e11231b07121c1c10b10116985f0ae6019173b10eaa23491a4af
+
+do_install() {
+	vinstall font-size 644 usr/lib/urxvt/perl
+}
+
+post_install() {
+	vdoc README.markdown
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: urxvt-font-size-1.3

[tommyjanna]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by tommyjanna on void-packages repository

https://github.com/void-linux/void-packages/pull/27361#discussion_r547466927

Comment:
Wasn't entirely sure if required... I now see it's unnecessary from the packaging manual.

Amended the original commit.

Re: New package: urxvt-font-size-1.3

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27361#issuecomment-749737314

Comment:
That said, given that in their [README](https://github.com/majutsushi/urxvt-font-size/blob/master/README.markdown) upstream recommends installing this in `$HOME`, and that this is mostly a personal config, I'm not sure it fits within our [quality requirements(https://github.com/void-linux/void-packages/blob/master/Manual.md#quality_requirements) :/

Re: New package: urxvt-font-size-1.3

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27361#issuecomment-749737314

Comment:
That said, given that in their [README](https://github.com/majutsushi/urxvt-font-size/blob/master/README.markdown) upstream recommends installing this in `$HOME`, and that this is mostly a personal config, I'm not sure it fits within our [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality_requirements) :/

Re: New package: urxvt-font-size-1.3

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/27361#issuecomment-749752771

Comment:
I agree with @ericonr, this belongs in `$HOME` rather than as a package.

Re: [PR PATCH] [Closed]: New package: urxvt-font-size-1.3

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

There's a closed pull request on the void-packages repository

New package: urxvt-font-size-1.3
https://github.com/void-linux/void-packages/pull/27361

Description: