From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] cherrytree: update to 0.99.27
Date: Sat, 26 Dec 2020 00:35:12 +0100 [thread overview]
Message-ID: <20201225233512.RxOel3TtSEVwJM8fFHmj_8bByA-m5znE6qj7TH4GFhc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27418@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27418#discussion_r548922187
Comment:
```suggestion
configure_args+=" -DBUILD_GMOCK:BOOL='OFF'
-DBUILD_GTEST:BOOL='OFF'
-DBUILD_TESTING:BOOL='OFF'"
```
Well, tests broke because you stopped building them :P
Put this block inside a conditional like `[ -z "$XBPS_CHECK_PKGS" ]`. This is worth it only if the tests take long to build; otherwise it's easier to just allow them to build.
next prev parent reply other threads:[~2020-12-25 23:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 6:29 [PR PATCH] " logenkain
2020-12-25 17:11 ` logenkain
2020-12-25 23:35 ` ericonr [this message]
2020-12-27 19:35 ` [PR PATCH] [Updated] " logenkain
2020-12-27 19:39 ` [PR REVIEW] " logenkain
2021-01-02 2:35 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201225233512.RxOel3TtSEVwJM8fFHmj_8bByA-m5znE6qj7TH4GFhc@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).