Github messages for voidlinux
 help / color / mirror / Atom feed
From: logenkain <logenkain@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] cherrytree: update to 0.99.27
Date: Fri, 25 Dec 2020 07:29:51 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27418@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

There is a new pull request by logenkain against master on the void-packages repository

https://github.com/logenkain/void-packages master
https://github.com/void-linux/void-packages/pull/27418

cherrytree: update to 0.99.27
They decided to use gtest, which is fine, but it seems as though they expect gtest to be pulled in as a sub module, which, of course, ends up being an empty folder in the release tar ball. 

As seen here:

https://github.com/giuspen/cherrytree/tree/master/tests

If I pull in gtest, as it expects, it tests out properly, but I'm not sure how to do that properly for a void build, so I opted to disable the testing.

Always happy to learn better way to deal with things like this.

A patch file from https://github.com/void-linux/void-packages/pull/27418.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-27418.patch --]
[-- Type: text/x-diff, Size: 1193 bytes --]

From da3ef73f2d664cce7e8788fc180a2d67a4c119fb Mon Sep 17 00:00:00 2001
From: Logen Kain <logen@sudotask.com>
Date: Fri, 25 Dec 2020 01:25:08 -0500
Subject: [PATCH] cherrytree: update to 0.99.27

---
 srcpkgs/cherrytree/template | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cherrytree/template b/srcpkgs/cherrytree/template
index de4faaae43b..8de20c28212 100644
--- a/srcpkgs/cherrytree/template
+++ b/srcpkgs/cherrytree/template
@@ -1,6 +1,6 @@
 # Template file for 'cherrytree'
 pkgname=cherrytree
-version=0.99.21
+version=0.99.27
 revision=1
 build_style=cmake
 hostmakedepends="gettext pkg-config desktop-file-utils python3 glib-devel"
@@ -13,7 +13,10 @@ maintainer="Logen K <logen@sudotask.com>"
 license="GPL-3.0-or-later"
 homepage="https://www.giuspen.com/cherrytree/"
 distfiles="https://github.com/giuspen/cherrytree/archive/$version.tar.gz"
-checksum=5c180fdf5cbab43bc496a246ce952e7f39e84b2a7b4cabdb22773b9d4a415850
+checksum=fff13c6b764eaa952616308a53cb5bd863b37f913bd74891117b4da20ff29832
+configure_args+=" -DBUILD_GMOCK:BOOL='OFF' \
+		-DBUILD_GTEST:BOOL='OFF' \
+		-DBUILD_TESTING:BOOL='OFF'"
 
 do_check() {
 	xvfb-run make -C build test

             reply	other threads:[~2020-12-25  6:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-25  6:29 logenkain [this message]
2020-12-25 17:11 ` logenkain
2020-12-25 23:35 ` [PR REVIEW] " ericonr
2020-12-27 19:35 ` [PR PATCH] [Updated] " logenkain
2020-12-27 19:39 ` [PR REVIEW] " logenkain
2021-01-02  2:35 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27418@inbox.vuxu.org \
    --to=logenkain@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).