From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] nautilus-python: fix cross-build
Date: Sat, 26 Dec 2020 01:05:46 +0100 [thread overview]
Message-ID: <20201226000546.dhTX3DiGM9s7_elkAs4JRa4Dhu79EmQN53EfK_3wG9U@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27416@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/27416#discussion_r548924294
Comment:
This part looks sketchy. `${XBPS_CROSS_BASE}`
I think I'll do this instead.
```diff
diff --git a/srcpkgs/nautilus-python/template b/srcpkgs/nautilus-python/template
index 072aeedb20..2aa4b0f9c6 100644
--- a/srcpkgs/nautilus-python/template
+++ b/srcpkgs/nautilus-python/template
@@ -4,9 +4,8 @@ version=1.2.3
revision=3
build_style=gnu-configure
configure_args="--enable-gtk-doc PYTHON=python3
- am_cv_python_pythondir=${XBPS_CROSS_BASE}/${py3_lib}/site-packages
- am_cv_python_pyexecdir=${XBPS_CROSS_BASE}/${py3_lib}/site-packages
- PYTHON_INCLUDES=-I${XBPS_CROSS_BASE}/${py3_inc}"
+ PYTHON_INCLUDES=-I${XBPS_CROSS_BASE}/${py3_inc}
+ PYTHON_LIBS=-lpython${py3_ver}"
hostmakedepends="automake libtool pkg-config which python3"
makedepends="python3-devel python3-gobject-devel gtk-doc nautilus-devel"
depends="nautilus python3-gobject"
```
next prev parent reply other threads:[~2020-12-26 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 4:03 [PR PATCH] " ndowens
2020-12-26 0:05 ` sgn [this message]
2020-12-26 0:06 ` [PR REVIEW] " sgn
2020-12-26 0:15 ` [PR PATCH] [Updated] " ndowens
2020-12-26 4:48 ` [PR REVIEW] " sgn
2020-12-26 9:38 ` mnabid
2020-12-27 4:28 ` [PR PATCH] [Closed]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201226000546.dhTX3DiGM9s7_elkAs4JRa4Dhu79EmQN53EfK_3wG9U@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).