From: mnabid <mnabid@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: nautilus-python: fix cross-build
Date: Sat, 26 Dec 2020 10:38:21 +0100 [thread overview]
Message-ID: <20201226093821.GlOOg4am5zrAUcug0ZXoeiEs_GU0a3M4O8dmxkYmDe4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27416@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]
New comment by mnabid on void-packages repository
https://github.com/void-linux/void-packages/pull/27416#issuecomment-751339005
Comment:
probably add a build_options and disable it by default.
________________________________
From: Đoàn Trần Công Danh <notifications@github.com>
Sent: Saturday, December 26, 2020 10:48 AM
To: void-linux/void-packages <void-packages@noreply.github.com>
Cc: Nafis <mnabid.25@outlook.com>; Mention <mention@noreply.github.com>
Subject: Re: [void-linux/void-packages] nautilus-python: fix cross-build (#27416)
@sgn commented on this pull request.
________________________________
In srcpkgs/nautilus-python/template<https://github.com/void-linux/void-packages/pull/27416#discussion_r548942955>:
> @@ -3,16 +3,17 @@ pkgname=nautilus-python
version=1.2.3
revision=3
build_style=gnu-configure
-configure_args="--enable-gtk-doc PYTHON=python3"
-hostmakedepends="automake libtool pkg-config which"
-makedepends="python3-devel python3-gobject-devel gtk-doc nautilus-devel"
+configure_args="--disable-gtk-doc PYTHON=python3
When the configure_args changed, please bump revision.
@mnabid<https://github.com/mnabid> Do you still want to have gtk-doc? Should we add a build_options instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/void-linux/void-packages/pull/27416#pullrequestreview-558847069>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOZ5LGDX2S2ZRJJHP4A3QNLSWVTI3ANCNFSM4VIZGNBQ>.
next prev parent reply other threads:[~2020-12-26 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 4:03 [PR PATCH] " ndowens
2020-12-26 0:05 ` [PR REVIEW] " sgn
2020-12-26 0:06 ` sgn
2020-12-26 0:15 ` [PR PATCH] [Updated] " ndowens
2020-12-26 4:48 ` [PR REVIEW] " sgn
2020-12-26 9:38 ` mnabid [this message]
2020-12-27 4:28 ` [PR PATCH] [Closed]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201226093821.GlOOg4am5zrAUcug0ZXoeiEs_GU0a3M4O8dmxkYmDe4@z \
--to=mnabid@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).