[PR PATCH] musescore: update to 3.5.2.

[PR PATCH] musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages musescore
https://github.com/void-linux/void-packages/pull/27451

musescore: update to 3.5.2.


A patch file from https://github.com/void-linux/void-packages/pull/27451.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-musescore-27451.patch --]
[-- Type: text/x-diff, Size: 1372 bytes --]

From b8b22247d359339f245d997849fe9e5f804f0ac0 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Sat, 26 Dec 2020 18:47:45 +0100
Subject: [PATCH] musescore: update to 3.5.2.

---
 srcpkgs/musescore/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/musescore/template b/srcpkgs/musescore/template
index 96242d516f5..a241aadde53 100644
--- a/srcpkgs/musescore/template
+++ b/srcpkgs/musescore/template
@@ -1,10 +1,10 @@
 # Template file for 'musescore'
 pkgname=musescore
-version=3.5.1
+version=3.5.2
 revision=1
 wrksrc="MuseScore-${version}"
 build_style=gnu-makefile
-make_build_args="PREFIX=/usr USE_SYSTEM_FREETYPE=ON"
+make_build_args="PREFIX=/usr USE_SYSTEM_FREETYPE=ON MUSESCORE_BUILD_CONFIG=release"
 make_install_args="-C build.release"
 hostmakedepends="cmake pkg-config"
 makedepends="jack-devel lame-devel libsndfile-devel portaudio-devel
@@ -18,7 +18,7 @@ maintainer="Brian Olsen <bnolsen@comcast.net>"
 license="GPL-2.0-or-later"
 homepage="https://musescore.org/"
 distfiles="https://github.com/musescore/MuseScore/archive/v${version}.tar.gz"
-checksum=4fa9d3b3f90861447f78858786ed6e351ea691408551ee92e089d4bba1039e5a
+checksum=75b8e783edca9d23718770b3f715d95b88f64545e0372f4ccba58ab073cc7068
 nocross="genManual: cannot execute binary file: Exec format error"
 
 build_options="webengine"

Re: musescore: update to 3.5.2.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751384650

Comment:
The build shows `Version 0.0 of the MuseScore SoundFont is outdated, downloading version 0.2.0.`, would it be possible to instead add it as a distfile?

Re: musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751388131

Comment:
in fact it downloads not one but 5 files from https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General/
MuseScore_General.sf3
MuseScore_General_Changelog.md
MuseScore_General_License.md
MuseScore_General_Readme.md
VERSION

although I think Changelog and Readme are not that important. It's not impossible but worth it? I think it overcomplicates the template.

Re: musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751388131

Comment:
@ericonr in fact it downloads not one but 5 files from https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General/
MuseScore_General.sf3
MuseScore_General_Changelog.md
MuseScore_General_License.md
MuseScore_General_Readme.md
VERSION

although I think Changelog and Readme are not that important. It's not impossible but worth it? I think it overcomplicates the template.

Re: musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751388131

Comment:
@ericonr
in fact it downloads not one but 5 files from https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General/
MuseScore_General.sf3
MuseScore_General_Changelog.md
MuseScore_General_License.md
MuseScore_General_Readme.md
VERSION

although I think Changelog and Readme are not that important. It's not impossible but worth it? I think it overcomplicates the template.

Re: musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751388131

Comment:
@ericonr
in fact it downloads not one, but 5 files from https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General/
MuseScore_General.sf3
MuseScore_General_Changelog.md
MuseScore_General_License.md
MuseScore_General_Readme.md
VERSION

although I think Changelog and Readme are not that important. It's not impossible but worth it? I think it overcomplicates the template.

Re: musescore: update to 3.5.2.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751389052

Comment:
Are those downloads checksummed, at least?

Re: musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751390254

Comment:
> Are those downloads checksummed, at least?
i dont think so
https://github.com/musescore/MuseScore/blob/465e7b6fe50973a24a75891e27575a8d2b962f6a/CMakeLists.txt#L337-L379

Re: musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751390254

Comment:
> Are those downloads checksummed, at least?

no
https://github.com/musescore/MuseScore/blob/465e7b6fe50973a24a75891e27575a8d2b962f6a/CMakeLists.txt#L337-L379

Re: musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751390254

Comment:
> Are those downloads checksummed, at least?

no
https://github.com/musescore/MuseScore/blob/465e7b6fe50973a24a75891e27575a8d2b962f6a/CMakeLists.txt#L336-L379

Re: musescore: update to 3.5.2.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751390785

Comment:
Could we try to package the fonts, instead? I'd strongly prefer to have these in distfiles or as a separate package.

Re: musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751392610

Comment:
Maybe it's a job for the maintainer then... I just wanted to update the package

Re: musescore: update to 3.5.2.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751394312

Comment:
@tibequadorian can you leave a `# TODO:` comment in the template about this, please? Then I can merge the update.

Re: [PR PATCH] [Updated] musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages musescore
https://github.com/void-linux/void-packages/pull/27451

musescore: update to 3.5.2.


A patch file from https://github.com/void-linux/void-packages/pull/27451.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-musescore-27451.patch --]
[-- Type: text/x-diff, Size: 1570 bytes --]

From 8faecfb088002f83cdcc31209071ecaba77200b0 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Sat, 26 Dec 2020 18:47:45 +0100
Subject: [PATCH] musescore: update to 3.5.2.

---
 srcpkgs/musescore/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/musescore/template b/srcpkgs/musescore/template
index 96242d516f5..51c39aa95d7 100644
--- a/srcpkgs/musescore/template
+++ b/srcpkgs/musescore/template
@@ -1,10 +1,13 @@
 # Template file for 'musescore'
+# TODO: Add MuseScore Soundfont as distfiles or separate package instead of
+#       downloading in the build process.
+#       https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General/
 pkgname=musescore
-version=3.5.1
+version=3.5.2
 revision=1
 wrksrc="MuseScore-${version}"
 build_style=gnu-makefile
-make_build_args="PREFIX=/usr USE_SYSTEM_FREETYPE=ON"
+make_build_args="PREFIX=/usr USE_SYSTEM_FREETYPE=ON MUSESCORE_BUILD_CONFIG=release"
 make_install_args="-C build.release"
 hostmakedepends="cmake pkg-config"
 makedepends="jack-devel lame-devel libsndfile-devel portaudio-devel
@@ -18,7 +21,7 @@ maintainer="Brian Olsen <bnolsen@comcast.net>"
 license="GPL-2.0-or-later"
 homepage="https://musescore.org/"
 distfiles="https://github.com/musescore/MuseScore/archive/v${version}.tar.gz"
-checksum=4fa9d3b3f90861447f78858786ed6e351ea691408551ee92e089d4bba1039e5a
+checksum=75b8e783edca9d23718770b3f715d95b88f64545e0372f4ccba58ab073cc7068
 nocross="genManual: cannot execute binary file: Exec format error"
 
 build_options="webengine"

Re: musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751395760

Comment:
like this?

Re: [PR REVIEW] musescore: update to 3.5.2.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#discussion_r549033985

Comment:
Doesn't need the indentation, but otherwise it's great. Thanks!

Re: [PR PATCH] [Updated] musescore: update to 3.5.2.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages musescore
https://github.com/void-linux/void-packages/pull/27451

musescore: update to 3.5.2.


A patch file from https://github.com/void-linux/void-packages/pull/27451.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-musescore-27451.patch --]
[-- Type: text/x-diff, Size: 1558 bytes --]

From 0619c217685c06679c5ae2ef6aab3a1336a90ed4 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Sat, 26 Dec 2020 18:47:45 +0100
Subject: [PATCH] musescore: update to 3.5.2.

---
 srcpkgs/musescore/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/musescore/template b/srcpkgs/musescore/template
index 96242d516f5..a853eedba5d 100644
--- a/srcpkgs/musescore/template
+++ b/srcpkgs/musescore/template
@@ -1,10 +1,13 @@
 # Template file for 'musescore'
+# TODO: Add MuseScore Soundfont as distfiles or separate package instead of
+# downloading in the build process.
+# https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General/
 pkgname=musescore
-version=3.5.1
+version=3.5.2
 revision=1
 wrksrc="MuseScore-${version}"
 build_style=gnu-makefile
-make_build_args="PREFIX=/usr USE_SYSTEM_FREETYPE=ON"
+make_build_args="PREFIX=/usr USE_SYSTEM_FREETYPE=ON MUSESCORE_BUILD_CONFIG=release"
 make_install_args="-C build.release"
 hostmakedepends="cmake pkg-config"
 makedepends="jack-devel lame-devel libsndfile-devel portaudio-devel
@@ -18,7 +21,7 @@ maintainer="Brian Olsen <bnolsen@comcast.net>"
 license="GPL-2.0-or-later"
 homepage="https://musescore.org/"
 distfiles="https://github.com/musescore/MuseScore/archive/v${version}.tar.gz"
-checksum=4fa9d3b3f90861447f78858786ed6e351ea691408551ee92e089d4bba1039e5a
+checksum=75b8e783edca9d23718770b3f715d95b88f64545e0372f4ccba58ab073cc7068
 nocross="genManual: cannot execute binary file: Exec format error"
 
 build_options="webengine"

Re: musescore: update to 3.5.2.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27451#issuecomment-751400781

Comment:
Thank you!

Re: [PR PATCH] [Merged]: musescore: update to 3.5.2.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

There's a merged pull request on the void-packages repository

musescore: update to 3.5.2.
https://github.com/void-linux/void-packages/pull/27451

Description: