* [PR PATCH] polybar: include example config
@ 2020-12-27 4:31 pbui
2020-12-27 4:33 ` pbui
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: pbui @ 2020-12-27 4:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
There is a new pull request by pbui against master on the void-packages repository
https://github.com/pbui/void-packages polybar
https://github.com/void-linux/void-packages/pull/27466
polybar: include example config
Fixes #27464
A patch file from https://github.com/void-linux/void-packages/pull/27466.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-polybar-27466.patch --]
[-- Type: text/x-diff, Size: 868 bytes --]
From 3943d626fd8c1d9c1403f217a006248ac5337a31 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 26 Dec 2020 23:29:12 -0500
Subject: [PATCH] polybar: include example config
Fixes #27464
---
srcpkgs/polybar/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/polybar/template b/srcpkgs/polybar/template
index a5e685ca665..8d40c0f4495 100644
--- a/srcpkgs/polybar/template
+++ b/srcpkgs/polybar/template
@@ -1,7 +1,7 @@
# Template file for 'polybar'
pkgname=polybar
version=3.5.3
-revision=1
+revision=2
build_style=cmake
configure_args="
-DENABLE_ALSA=$(vopt_if alsa ON OFF)
@@ -51,6 +51,6 @@ if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
fi
post_install() {
- rm -rf ${DESTDIR}/usr/share/doc/polybar
+ find ${DESTDIR}/usr/share/doc/polybar/ -mindepth 1 ! -name config -delete
vlicense LICENSE
}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: polybar: include example config
2020-12-27 4:31 [PR PATCH] polybar: include example config pbui
@ 2020-12-27 4:33 ` pbui
2020-12-27 9:55 ` [PR REVIEW] " sgn
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pbui @ 2020-12-27 4:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
New comment by pbui on void-packages repository
https://github.com/void-linux/void-packages/pull/27466#issuecomment-751425114
Comment:
@ericonr @fahrberg This should remove everything *except* the sample config from `/usr/share/doc/polybar`.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] polybar: include example config
2020-12-27 4:31 [PR PATCH] polybar: include example config pbui
2020-12-27 4:33 ` pbui
@ 2020-12-27 9:55 ` sgn
2020-12-27 9:55 ` sgn
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2020-12-27 9:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/27466#discussion_r549091540
Comment:
IMO, it's better to remove everything is `/usr/share/doc/polybar` and `vdoc config` or `vsconf config`.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] polybar: include example config
2020-12-27 4:31 [PR PATCH] polybar: include example config pbui
2020-12-27 4:33 ` pbui
2020-12-27 9:55 ` [PR REVIEW] " sgn
@ 2020-12-27 9:55 ` sgn
2020-12-27 15:35 ` ericonr
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2020-12-27 9:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/27466#discussion_r549091540
Comment:
IMO, it's better to remove everything in `/usr/share/doc/polybar` and `vdoc config` or `vsconf config`.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] polybar: include example config
2020-12-27 4:31 [PR PATCH] polybar: include example config pbui
` (2 preceding siblings ...)
2020-12-27 9:55 ` sgn
@ 2020-12-27 15:35 ` ericonr
2020-12-27 17:49 ` [PR PATCH] [Updated] " pbui
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-12-27 15:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27466#discussion_r549126878
Comment:
The only problem with this approach is that it breaks if upstream changes where they put the example config. That isn't the case here.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] polybar: include example config
2020-12-27 4:31 [PR PATCH] polybar: include example config pbui
` (3 preceding siblings ...)
2020-12-27 15:35 ` ericonr
@ 2020-12-27 17:49 ` pbui
2020-12-27 17:50 ` [PR REVIEW] " pbui
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pbui @ 2020-12-27 17:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
There is an updated pull request by pbui against master on the void-packages repository
https://github.com/pbui/void-packages polybar
https://github.com/void-linux/void-packages/pull/27466
polybar: include example config
Fixes #27464
A patch file from https://github.com/void-linux/void-packages/pull/27466.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-polybar-27466.patch --]
[-- Type: text/x-diff, Size: 764 bytes --]
From 5513c988eaf26e0b07aac05f888d336d43047b5e Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 26 Dec 2020 23:29:12 -0500
Subject: [PATCH] polybar: include example config
Fixes #27464
---
srcpkgs/polybar/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/polybar/template b/srcpkgs/polybar/template
index a5e685ca665..db7aa42eaaa 100644
--- a/srcpkgs/polybar/template
+++ b/srcpkgs/polybar/template
@@ -1,7 +1,7 @@
# Template file for 'polybar'
pkgname=polybar
version=3.5.3
-revision=1
+revision=2
build_style=cmake
configure_args="
-DENABLE_ALSA=$(vopt_if alsa ON OFF)
@@ -52,5 +52,6 @@ fi
post_install() {
rm -rf ${DESTDIR}/usr/share/doc/polybar
+ vdoc config
vlicense LICENSE
}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] polybar: include example config
2020-12-27 4:31 [PR PATCH] polybar: include example config pbui
` (4 preceding siblings ...)
2020-12-27 17:49 ` [PR PATCH] [Updated] " pbui
@ 2020-12-27 17:50 ` pbui
2020-12-28 4:52 ` ericonr
2020-12-28 4:53 ` [PR PATCH] [Merged]: " ericonr
7 siblings, 0 replies; 9+ messages in thread
From: pbui @ 2020-12-27 17:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
New review comment by pbui on void-packages repository
https://github.com/void-linux/void-packages/pull/27466#discussion_r549145627
Comment:
OK, I've modifed it to `rm` the directory and then `vdoc` the `config` file. Here is the output of `xls`:
```
/usr/bin/polybar
/usr/bin/polybar-msg
/usr/share/bash-completion/completions/polybar
/usr/share/doc/polybar/config
/usr/share/licenses/polybar/LICENSE
/usr/share/man/man1/polybar.1
/usr/share/man/man5/polybar.5
/usr/share/zsh/site-functions/_polybar
/usr/share/zsh/site-functions/_polybar_msg
```
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: polybar: include example config
2020-12-27 4:31 [PR PATCH] polybar: include example config pbui
` (5 preceding siblings ...)
2020-12-27 17:50 ` [PR REVIEW] " pbui
@ 2020-12-28 4:52 ` ericonr
2020-12-28 4:53 ` [PR PATCH] [Merged]: " ericonr
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-12-28 4:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27466#issuecomment-751573967
Comment:
We might need to watch out for changes in the config location, but I hope that's unlikely to happen.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: polybar: include example config
2020-12-27 4:31 [PR PATCH] polybar: include example config pbui
` (6 preceding siblings ...)
2020-12-28 4:52 ` ericonr
@ 2020-12-28 4:53 ` ericonr
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-12-28 4:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
There's a merged pull request on the void-packages repository
polybar: include example config
https://github.com/void-linux/void-packages/pull/27466
Description:
Fixes #27464
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-12-28 4:53 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-27 4:31 [PR PATCH] polybar: include example config pbui
2020-12-27 4:33 ` pbui
2020-12-27 9:55 ` [PR REVIEW] " sgn
2020-12-27 9:55 ` sgn
2020-12-27 15:35 ` ericonr
2020-12-27 17:49 ` [PR PATCH] [Updated] " pbui
2020-12-27 17:50 ` [PR REVIEW] " pbui
2020-12-28 4:52 ` ericonr
2020-12-28 4:53 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).