From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Htop: enable sensors support
Date: Wed, 30 Dec 2020 14:02:44 +0100 [thread overview]
Message-ID: <20201230130244.ou1V1ksp8gGIQpI2ack1zpLr73ZYEFbgmC5h_yX2NRI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27527@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752566812
Comment:
This shouldn't have been merged, the commit message is wrong, it does not increase the revision resulting in no rebuild.
From the CI build logs its clear that the commit actually does not enable this feature, meaning you did not test it.
```
checking sensors/sensors.h usability... no
checking sensors/sensors.h presence... no
checking for sensors/sensors.h... no
```
next prev parent reply other threads:[~2020-12-30 13:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 10:31 [PR PATCH] Htop: enabled " Mek101
2020-12-30 6:30 ` [PR PATCH] [Closed]: Htop: enable " the-maldridge
2020-12-30 8:02 ` Mek101
2020-12-30 8:02 ` the-maldridge
2020-12-30 12:22 ` Mek101
2020-12-30 12:23 ` Mek101
2020-12-30 13:02 ` Duncaen [this message]
2021-02-21 16:55 [PR PATCH] htop: " the-eater
2021-02-21 18:18 ` ericonr
2021-02-21 18:34 ` ericonr
2021-02-21 19:03 ` BenBE
2021-02-21 19:11 ` ericonr
2021-02-21 19:34 ` the-eater
2021-02-21 20:14 ` BenBE
2021-02-24 13:03 ` the-eater
2021-05-17 16:07 ` dkwo
2021-05-17 18:15 ` the-eater
2021-05-17 18:22 ` dkwo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230130244.ou1V1ksp8gGIQpI2ack1zpLr73ZYEFbgmC5h_yX2NRI@z \
--to=duncaen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).