* [PR PATCH] Htop: enabled sensors support
@ 2020-12-29 10:31 Mek101
2020-12-30 6:30 ` [PR PATCH] [Closed]: Htop: enable " the-maldridge
` (5 more replies)
0 siblings, 6 replies; 17+ messages in thread
From: Mek101 @ 2020-12-29 10:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
There is a new pull request by Mek101 against master on the void-packages repository
https://github.com/Mek101/void-packages patch-2
https://github.com/void-linux/void-packages/pull/27527
Htop: enabled sensors support
Enables optional sensors support via `libsensors`, see https://github.com/htop-dev/htop/issues/358
From what I've been able to gather, the `libsensors` lib is linked in only at [runtime](https://github.com/htop-dev/htop/blob/master/linux/LibSensors.c), therefore the temperature sensors will be enabled only in systems with `libsensors` and cause no issue on systems without.
A patch file from https://github.com/void-linux/void-packages/pull/27527.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-27527.patch --]
[-- Type: text/x-diff, Size: 828 bytes --]
From 185e37d3db54348586ddc94a36624a5732cf6645 Mon Sep 17 00:00:00 2001
From: Mek101 <34246799+Mek101@users.noreply.github.com>
Date: Tue, 29 Dec 2020 10:28:25 +0000
Subject: [PATCH] Enabled sensors support
Enables optional sensors support via libsensors
---
srcpkgs/htop/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/htop/template b/srcpkgs/htop/template
index d57b6323f70..2f545e82050 100644
--- a/srcpkgs/htop/template
+++ b/srcpkgs/htop/template
@@ -3,7 +3,7 @@ pkgname=htop
version=3.0.4
revision=1
build_style=gnu-configure
-configure_args="--enable-unicode --enable-cgroup --enable-taskstats"
+configure_args="--enable-unicode --enable-cgroup --enable-taskstats --enable-sensors"
hostmakedepends="automake"
makedepends="ncurses-devel"
short_desc="Interactive process viewer"
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PR PATCH] [Closed]: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
@ 2020-12-30 6:30 ` the-maldridge
2020-12-30 8:02 ` Mek101
` (4 subsequent siblings)
5 siblings, 0 replies; 17+ messages in thread
From: the-maldridge @ 2020-12-30 6:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
There's a closed pull request on the void-packages repository
Htop: enable sensors support
https://github.com/void-linux/void-packages/pull/27527
Description:
Enables optional sensors support via `libsensors`, see https://github.com/htop-dev/htop/issues/358
From what I've been able to gather, the `libsensors` lib is linked in only at [runtime](https://github.com/htop-dev/htop/blob/master/linux/LibSensors.c), therefore the temperature sensors will be enabled only in systems with `libsensors` and cause no issue on systems without.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
2020-12-30 6:30 ` [PR PATCH] [Closed]: Htop: enable " the-maldridge
@ 2020-12-30 8:02 ` Mek101
2020-12-30 8:02 ` the-maldridge
` (3 subsequent siblings)
5 siblings, 0 replies; 17+ messages in thread
From: Mek101 @ 2020-12-30 8:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New comment by Mek101 on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752366639
Comment:
Why immidiate closure?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
2020-12-30 6:30 ` [PR PATCH] [Closed]: Htop: enable " the-maldridge
2020-12-30 8:02 ` Mek101
@ 2020-12-30 8:02 ` the-maldridge
2020-12-30 12:22 ` Mek101
` (2 subsequent siblings)
5 siblings, 0 replies; 17+ messages in thread
From: the-maldridge @ 2020-12-30 8:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752366769
Comment:
Because it was merged?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
` (2 preceding siblings ...)
2020-12-30 8:02 ` the-maldridge
@ 2020-12-30 12:22 ` Mek101
2020-12-30 12:23 ` Mek101
2020-12-30 13:02 ` Duncaen
5 siblings, 0 replies; 17+ messages in thread
From: Mek101 @ 2020-12-30 12:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New comment by Mek101 on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752511998
Comment:
I checked the recent commits and I confirm the merge, however here it says "Closed with unmerged commits": and now I'm just confused
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
` (3 preceding siblings ...)
2020-12-30 12:22 ` Mek101
@ 2020-12-30 12:23 ` Mek101
2020-12-30 13:02 ` Duncaen
5 siblings, 0 replies; 17+ messages in thread
From: Mek101 @ 2020-12-30 12:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
New comment by Mek101 on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752511998
Comment:
I checked the recent commits and I confirm the merge, however here it says "Closed with unmerged commits": and now I'm just confused
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
` (4 preceding siblings ...)
2020-12-30 12:23 ` Mek101
@ 2020-12-30 13:02 ` Duncaen
5 siblings, 0 replies; 17+ messages in thread
From: Duncaen @ 2020-12-30 13:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752566812
Comment:
This shouldn't have been merged, the commit message is wrong, it does not increase the revision resulting in no rebuild.
From the CI build logs its clear that the commit actually does not enable this feature, meaning you did not test it.
```
checking sensors/sensors.h usability... no
checking sensors/sensors.h presence... no
checking for sensors/sensors.h... no
```
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
` (8 preceding siblings ...)
2021-05-17 18:15 ` the-eater
@ 2021-05-17 18:22 ` dkwo
9 siblings, 0 replies; 17+ messages in thread
From: dkwo @ 2021-05-17 18:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-842535654
Comment:
Thanks.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
` (7 preceding siblings ...)
2021-05-17 16:07 ` dkwo
@ 2021-05-17 18:15 ` the-eater
2021-05-17 18:22 ` dkwo
9 siblings, 0 replies; 17+ messages in thread
From: the-eater @ 2021-05-17 18:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
New comment by the-eater on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-842531384
Comment:
Display Options -> Also show CPU Tempature
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
` (6 preceding siblings ...)
2021-02-24 13:03 ` the-eater
@ 2021-05-17 16:07 ` dkwo
2021-05-17 18:15 ` the-eater
2021-05-17 18:22 ` dkwo
9 siblings, 0 replies; 17+ messages in thread
From: dkwo @ 2021-05-17 16:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-842448507
Comment:
I do not see any temperature in `Available meters`.
Is any further configuration required?
```
$ htop --version
htop 3.0.5
$ xuname
Void 5.11.21_1 x86_64-musl GenuineIntel uptodate hold rrnFFFF
$ xpkg -v | grep sensors
libsensors-3.6.0_1
```
Thanks.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
` (5 preceding siblings ...)
2021-02-21 20:14 ` BenBE
@ 2021-02-24 13:03 ` the-eater
2021-05-17 16:07 ` dkwo
` (2 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: the-eater @ 2021-02-24 13:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
New comment by the-eater on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-785059974
Comment:
removed `--enable-cgroup --enable-taskstats` since they don't exist
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
` (4 preceding siblings ...)
2021-02-21 19:34 ` the-eater
@ 2021-02-21 20:14 ` BenBE
2021-02-24 13:03 ` the-eater
` (3 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: BenBE @ 2021-02-21 20:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
New comment by BenBE on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-782918754
Comment:
The options for `configure` have been renamed recently (cf. https://github.com/htop-dev/htop/pull/482) accompanied by changing the defaults to check for the dependencies to be present. If you want to get a stable build (ensuring features are actually compiled in) it's best to specify those options explicitly.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
` (3 preceding siblings ...)
2021-02-21 19:11 ` ericonr
@ 2021-02-21 19:34 ` the-eater
2021-02-21 20:14 ` BenBE
` (4 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: the-eater @ 2021-02-21 19:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
New comment by the-eater on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-782912620
Comment:
haha, so default value is `check` so it worked™ anyhow.
also
`configure: WARNING: unrecognized options: --enable-cgroup, --enable-taskstats` should I just remove those in that case?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
` (2 preceding siblings ...)
2021-02-21 19:03 ` BenBE
@ 2021-02-21 19:11 ` ericonr
2021-02-21 19:34 ` the-eater
` (5 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-21 19:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-782909221
Comment:
So use `--with-sensors` and leave a comment that next version will be using `--enable-sensors` instead :)
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
2021-02-21 18:18 ` ericonr
2021-02-21 18:34 ` ericonr
@ 2021-02-21 19:03 ` BenBE
2021-02-21 19:11 ` ericonr
` (6 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: BenBE @ 2021-02-21 19:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
New comment by BenBE on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-782908068
Comment:
Next release will take a few more $UnitsOfTime … ;-)
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
2021-02-21 18:18 ` ericonr
@ 2021-02-21 18:34 ` ericonr
2021-02-21 19:03 ` BenBE
` (7 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-21 18:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-782903946
Comment:
Ok, `--enable-sensors` is only in git master, this version should be using `--with-sensors`. Or we can wait for an update :)
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: htop: enable sensors support
2021-02-21 16:55 [PR PATCH] htop: " the-eater
@ 2021-02-21 18:18 ` ericonr
2021-02-21 18:34 ` ericonr
` (8 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: ericonr @ 2021-02-21 18:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28959#issuecomment-782901180
Comment:
Oh neat, good find.
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-05-17 18:22 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
2020-12-30 6:30 ` [PR PATCH] [Closed]: Htop: enable " the-maldridge
2020-12-30 8:02 ` Mek101
2020-12-30 8:02 ` the-maldridge
2020-12-30 12:22 ` Mek101
2020-12-30 12:23 ` Mek101
2020-12-30 13:02 ` Duncaen
2021-02-21 16:55 [PR PATCH] htop: " the-eater
2021-02-21 18:18 ` ericonr
2021-02-21 18:34 ` ericonr
2021-02-21 19:03 ` BenBE
2021-02-21 19:11 ` ericonr
2021-02-21 19:34 ` the-eater
2021-02-21 20:14 ` BenBE
2021-02-24 13:03 ` the-eater
2021-05-17 16:07 ` dkwo
2021-05-17 18:15 ` the-eater
2021-05-17 18:22 ` dkwo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).