* [PR PATCH] Htop: enabled sensors support
@ 2020-12-29 10:31 Mek101
2020-12-30 6:30 ` [PR PATCH] [Closed]: Htop: enable " the-maldridge
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Mek101 @ 2020-12-29 10:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
There is a new pull request by Mek101 against master on the void-packages repository
https://github.com/Mek101/void-packages patch-2
https://github.com/void-linux/void-packages/pull/27527
Htop: enabled sensors support
Enables optional sensors support via `libsensors`, see https://github.com/htop-dev/htop/issues/358
From what I've been able to gather, the `libsensors` lib is linked in only at [runtime](https://github.com/htop-dev/htop/blob/master/linux/LibSensors.c), therefore the temperature sensors will be enabled only in systems with `libsensors` and cause no issue on systems without.
A patch file from https://github.com/void-linux/void-packages/pull/27527.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-27527.patch --]
[-- Type: text/x-diff, Size: 828 bytes --]
From 185e37d3db54348586ddc94a36624a5732cf6645 Mon Sep 17 00:00:00 2001
From: Mek101 <34246799+Mek101@users.noreply.github.com>
Date: Tue, 29 Dec 2020 10:28:25 +0000
Subject: [PATCH] Enabled sensors support
Enables optional sensors support via libsensors
---
srcpkgs/htop/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/htop/template b/srcpkgs/htop/template
index d57b6323f70..2f545e82050 100644
--- a/srcpkgs/htop/template
+++ b/srcpkgs/htop/template
@@ -3,7 +3,7 @@ pkgname=htop
version=3.0.4
revision=1
build_style=gnu-configure
-configure_args="--enable-unicode --enable-cgroup --enable-taskstats"
+configure_args="--enable-unicode --enable-cgroup --enable-taskstats --enable-sensors"
hostmakedepends="automake"
makedepends="ncurses-devel"
short_desc="Interactive process viewer"
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Closed]: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
@ 2020-12-30 6:30 ` the-maldridge
2020-12-30 8:02 ` Mek101
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: the-maldridge @ 2020-12-30 6:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
There's a closed pull request on the void-packages repository
Htop: enable sensors support
https://github.com/void-linux/void-packages/pull/27527
Description:
Enables optional sensors support via `libsensors`, see https://github.com/htop-dev/htop/issues/358
From what I've been able to gather, the `libsensors` lib is linked in only at [runtime](https://github.com/htop-dev/htop/blob/master/linux/LibSensors.c), therefore the temperature sensors will be enabled only in systems with `libsensors` and cause no issue on systems without.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
2020-12-30 6:30 ` [PR PATCH] [Closed]: Htop: enable " the-maldridge
@ 2020-12-30 8:02 ` Mek101
2020-12-30 8:02 ` the-maldridge
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Mek101 @ 2020-12-30 8:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New comment by Mek101 on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752366639
Comment:
Why immidiate closure?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
2020-12-30 6:30 ` [PR PATCH] [Closed]: Htop: enable " the-maldridge
2020-12-30 8:02 ` Mek101
@ 2020-12-30 8:02 ` the-maldridge
2020-12-30 12:22 ` Mek101
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: the-maldridge @ 2020-12-30 8:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752366769
Comment:
Because it was merged?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
` (2 preceding siblings ...)
2020-12-30 8:02 ` the-maldridge
@ 2020-12-30 12:22 ` Mek101
2020-12-30 12:23 ` Mek101
2020-12-30 13:02 ` Duncaen
5 siblings, 0 replies; 7+ messages in thread
From: Mek101 @ 2020-12-30 12:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New comment by Mek101 on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752511998
Comment:
I checked the recent commits and I confirm the merge, however here it says "Closed with unmerged commits": and now I'm just confused
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
` (3 preceding siblings ...)
2020-12-30 12:22 ` Mek101
@ 2020-12-30 12:23 ` Mek101
2020-12-30 13:02 ` Duncaen
5 siblings, 0 replies; 7+ messages in thread
From: Mek101 @ 2020-12-30 12:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
New comment by Mek101 on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752511998
Comment:
I checked the recent commits and I confirm the merge, however here it says "Closed with unmerged commits": and now I'm just confused
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Htop: enable sensors support
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
` (4 preceding siblings ...)
2020-12-30 12:23 ` Mek101
@ 2020-12-30 13:02 ` Duncaen
5 siblings, 0 replies; 7+ messages in thread
From: Duncaen @ 2020-12-30 13:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/27527#issuecomment-752566812
Comment:
This shouldn't have been merged, the commit message is wrong, it does not increase the revision resulting in no rebuild.
From the CI build logs its clear that the commit actually does not enable this feature, meaning you did not test it.
```
checking sensors/sensors.h usability... no
checking sensors/sensors.h presence... no
checking for sensors/sensors.h... no
```
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-12-30 13:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29 10:31 [PR PATCH] Htop: enabled sensors support Mek101
2020-12-30 6:30 ` [PR PATCH] [Closed]: Htop: enable " the-maldridge
2020-12-30 8:02 ` Mek101
2020-12-30 8:02 ` the-maldridge
2020-12-30 12:22 ` Mek101
2020-12-30 12:23 ` Mek101
2020-12-30 13:02 ` Duncaen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).