* [PR PATCH] tcl: don't build unnecessary compatibility functions.
@ 2021-01-06 1:36 CMB
2021-01-06 4:08 ` [PR REVIEW] " ericonr
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: CMB @ 2021-01-06 1:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
There is a new pull request by CMB against master on the void-packages repository
https://github.com/CMB/void-packages tcl
https://github.com/void-linux/void-packages/pull/27708
tcl: don't build unnecessary compatibility functions.
./configure-time tests are incorrectly flagging some libc functions as
broken when cross-compiling. Hard-code correct results of tests.
Without this patch, it seems that I cannot link some things (tclx)
against tcl on aarch64.
A patch file from https://github.com/void-linux/void-packages/pull/27708.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tcl-27708.patch --]
[-- Type: text/x-diff, Size: 1229 bytes --]
From a2ea2514682f7f434f041c0b9db5a3ab10e4d6bc Mon Sep 17 00:00:00 2001
From: Christopher Brannon <chris@the-brannons.com>
Date: Tue, 5 Jan 2021 16:56:59 -0800
Subject: [PATCH] tcl: don't build unnecessary compatibility functions.
./configure-time tests are incorrectly flagging some libc functions as
broken when cross-compiling. Hard-code correct results of tests.
Without this patch, it seems that I cannot link some things (tclx)
against tcl on aarch64.
---
srcpkgs/tcl/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/tcl/template b/srcpkgs/tcl/template
index d4c77cfd4e6..9e67af7458c 100644
--- a/srcpkgs/tcl/template
+++ b/srcpkgs/tcl/template
@@ -1,13 +1,15 @@
# Template file for 'tcl'
pkgname=tcl
version=8.6.10
-revision=2
+revision=3
wrksrc="tcl${version}"
build_wrksrc=unix
build_style=gnu-configure
configure_args="--enable-threads --without-tzdata --enable-man-symlinks
--disable-static --disable-rpath --with-system-sqlite
- tcl_cv_strtod_unbroken=ok"
+ tcl_cv_strstr_unbroken=ok
+ tcl_cv_strtod_unbroken=ok
+ tcl_cv_strtoul_unbroken=ok"
makedepends="zlib-devel sqlite-devel"
short_desc="TCL scripting language"
maintainer="Orphaned <orphan@voidlinux.org>"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] tcl: don't build unnecessary compatibility functions.
2021-01-06 1:36 [PR PATCH] tcl: don't build unnecessary compatibility functions CMB
@ 2021-01-06 4:08 ` ericonr
2021-01-06 4:39 ` CMB
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-01-06 4:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27708#discussion_r552357826
Comment:
I didn't find `strtod` in the configure output, maybe only `strstr` and `strtoul` are required?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tcl: don't build unnecessary compatibility functions.
2021-01-06 1:36 [PR PATCH] tcl: don't build unnecessary compatibility functions CMB
2021-01-06 4:08 ` [PR REVIEW] " ericonr
@ 2021-01-06 4:39 ` CMB
2021-01-06 4:41 ` [PR PATCH] [Updated] " CMB
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: CMB @ 2021-01-06 4:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
New comment by CMB on void-packages repository
https://github.com/void-linux/void-packages/pull/27708#issuecomment-755073465
Comment:
> I didn't find strtod in the configure output, maybe only strstr and strtoul
> are required?
I did a quick comparison of tcl8.6.10 source with an older
version I happened to have lying around in distfiles. The strtod test
was removed at some point.
I'll remove this since it isn't needed anymore.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] tcl: don't build unnecessary compatibility functions.
2021-01-06 1:36 [PR PATCH] tcl: don't build unnecessary compatibility functions CMB
2021-01-06 4:08 ` [PR REVIEW] " ericonr
2021-01-06 4:39 ` CMB
@ 2021-01-06 4:41 ` CMB
2021-01-06 4:48 ` ericonr
2021-01-06 4:48 ` [PR PATCH] [Merged]: " ericonr
4 siblings, 0 replies; 6+ messages in thread
From: CMB @ 2021-01-06 4:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
There is an updated pull request by CMB against master on the void-packages repository
https://github.com/CMB/void-packages tcl
https://github.com/void-linux/void-packages/pull/27708
tcl: don't build unnecessary compatibility functions.
./configure-time tests are incorrectly flagging some libc functions as
broken when cross-compiling. Hard-code correct results of tests.
Without this patch, it seems that I cannot link some things (tclx)
against tcl on aarch64.
A patch file from https://github.com/void-linux/void-packages/pull/27708.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tcl-27708.patch --]
[-- Type: text/x-diff, Size: 1200 bytes --]
From a8d4c50d56933387bfe046303853e6b708b36d7e Mon Sep 17 00:00:00 2001
From: Christopher Brannon <chris@the-brannons.com>
Date: Tue, 5 Jan 2021 16:56:59 -0800
Subject: [PATCH] tcl: don't build unnecessary compatibility functions.
./configure-time tests are incorrectly flagging some libc functions as
broken when cross-compiling. Hard-code correct results of tests.
Without this patch, it seems that I cannot link some things (tclx)
against tcl on aarch64.
---
srcpkgs/tcl/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/tcl/template b/srcpkgs/tcl/template
index d4c77cfd4e6..191acaf46c3 100644
--- a/srcpkgs/tcl/template
+++ b/srcpkgs/tcl/template
@@ -1,13 +1,14 @@
# Template file for 'tcl'
pkgname=tcl
version=8.6.10
-revision=2
+revision=3
wrksrc="tcl${version}"
build_wrksrc=unix
build_style=gnu-configure
configure_args="--enable-threads --without-tzdata --enable-man-symlinks
--disable-static --disable-rpath --with-system-sqlite
- tcl_cv_strtod_unbroken=ok"
+ tcl_cv_strstr_unbroken=ok
+ tcl_cv_strtoul_unbroken=ok"
makedepends="zlib-devel sqlite-devel"
short_desc="TCL scripting language"
maintainer="Orphaned <orphan@voidlinux.org>"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tcl: don't build unnecessary compatibility functions.
2021-01-06 1:36 [PR PATCH] tcl: don't build unnecessary compatibility functions CMB
` (2 preceding siblings ...)
2021-01-06 4:41 ` [PR PATCH] [Updated] " CMB
@ 2021-01-06 4:48 ` ericonr
2021-01-06 4:48 ` [PR PATCH] [Merged]: " ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-01-06 4:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27708#issuecomment-755075691
Comment:
I hadn't even realized it was there previously! Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: tcl: don't build unnecessary compatibility functions.
2021-01-06 1:36 [PR PATCH] tcl: don't build unnecessary compatibility functions CMB
` (3 preceding siblings ...)
2021-01-06 4:48 ` ericonr
@ 2021-01-06 4:48 ` ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-01-06 4:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
There's a merged pull request on the void-packages repository
tcl: don't build unnecessary compatibility functions.
https://github.com/void-linux/void-packages/pull/27708
Description:
./configure-time tests are incorrectly flagging some libc functions as
broken when cross-compiling. Hard-code correct results of tests.
Without this patch, it seems that I cannot link some things (tclx)
against tcl on aarch64.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-06 4:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06 1:36 [PR PATCH] tcl: don't build unnecessary compatibility functions CMB
2021-01-06 4:08 ` [PR REVIEW] " ericonr
2021-01-06 4:39 ` CMB
2021-01-06 4:41 ` [PR PATCH] [Updated] " CMB
2021-01-06 4:48 ` ericonr
2021-01-06 4:48 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).