Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] chromium: update to 87.0.4280.141.
@ 2021-01-07 22:56 pbui
  2021-01-07 23:02 ` [PR PATCH] [Updated] " pbui
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: pbui @ 2021-01-07 22:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

There is a new pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages chromium
https://github.com/void-linux/void-packages/pull/27752

chromium: update to 87.0.4280.141.
- Built for x86_64, x86_64-musl.
- Tested on x86_64.
- Update chromium-widevine as well.

Using gold to link produces a segfault during linking on x86_64, so I have disabled it (just like we have done for i686 and musl).

@ericonr @q66 @Johnnynator Please let me know if you know of a different solution for the gold linker.



A patch file from https://github.com/void-linux/void-packages/pull/27752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chromium-27752.patch --]
[-- Type: text/x-diff, Size: 2857 bytes --]

From f3b905538f81f2c436ca2b356bed85c5cc3e19e3 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Thu, 7 Jan 2021 17:47:38 -0500
Subject: [PATCH 1/2] chromium: update to 87.0.4280.141.

---
 srcpkgs/chromium/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/chromium/template b/srcpkgs/chromium/template
index 7cb351b6f26..dd53d516f91 100644
--- a/srcpkgs/chromium/template
+++ b/srcpkgs/chromium/template
@@ -1,7 +1,7 @@
 # Template file for 'chromium'
 pkgname=chromium
 # See http://www.chromium.org/developers/calendar for the latest version
-version=87.0.4280.88
+version=87.0.4280.141
 revision=1
 archs="i686* x86_64* aarch64* armv7l* ppc64le*"
 short_desc="Google's attempt at creating a safer, faster, and more stable browser"
@@ -9,7 +9,7 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://www.chromium.org/"
 distfiles="https://commondatastorage.googleapis.com/chromium-browser-official/${pkgname}-${version}.tar.xz"
-checksum=3e4645328735ef60db78d1a313efb3770a3edeaede90d076414df52f567a09c0
+checksum=147591d7fc21e1a173701d28bbf35baddb91e64dd96ec16d8eee9a5113403375
 nocross=yes
 
 lib32disabled=yes
@@ -224,9 +224,11 @@ do_configure() {
 	)
 
 	# XXX: gold broken with musl and i686
+	# XXX: gold broken with x86_64 using binutils-2.35
 	case "${XBPS_TARGET_MACHINE}" in
 	*-musl) conf+=( 'use_gold=false' ) ;;
 	i686*) conf+=( 'use_gold=false' ) ;;
+	x86_64*) conf+=( 'use_gold=false' ) ;;
 	*) conf+=( 'use_gold=true' ) ;;
 	esac
 

From 8878062698b4095c6adf583e18c099b44e7f8598 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Thu, 7 Jan 2021 17:49:32 -0500
Subject: [PATCH 2/2] chromium-widevine: update to 87.0.4280.141.

---
 srcpkgs/chromium-widevine/INSTALL  | 2 +-
 srcpkgs/chromium-widevine/template | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/chromium-widevine/INSTALL b/srcpkgs/chromium-widevine/INSTALL
index 1f63fd0f44c..d4723ffdf1f 100644
--- a/srcpkgs/chromium-widevine/INSTALL
+++ b/srcpkgs/chromium-widevine/INSTALL
@@ -1,6 +1,6 @@
 # INSTALL
 
-checksum=4bc68502dc5e22d5c264b3fb5d0a1ecfdadc3ba21d945646d8d37de4b8a96e58
+checksum=b7edb7cd5c166bf3c0a1d245baa5924e242c3b81b97090468bec778f41f40373
 _baseUrl="https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable"
 _filename="google-chrome-stable_${VERSION%_*}-1_amd64.deb"
 DISTFILE="${_baseUrl}/${_filename}"
diff --git a/srcpkgs/chromium-widevine/template b/srcpkgs/chromium-widevine/template
index 32ede6c8bda..be13eec954a 100644
--- a/srcpkgs/chromium-widevine/template
+++ b/srcpkgs/chromium-widevine/template
@@ -6,7 +6,7 @@ _chromeVersion="current"
 _channel="stable"
 
 pkgname=chromium-widevine
-version=87.0.4280.88
+version=87.0.4280.141
 revision=1
 archs="x86_64"
 create_wrksrc=yes

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] chromium: update to 87.0.4280.141.
  2021-01-07 22:56 [PR PATCH] chromium: update to 87.0.4280.141 pbui
@ 2021-01-07 23:02 ` pbui
  2021-01-07 23:03 ` q66
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: pbui @ 2021-01-07 23:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

There is an updated pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages chromium
https://github.com/void-linux/void-packages/pull/27752

chromium: update to 87.0.4280.141.
[ci skip]

- Built for x86_64, x86_64-musl.
- Tested on x86_64.
- Update chromium-widevine as well.

Using gold to link produces a segfault during linking on x86_64, so I have disabled it (just like we have done for i686 and musl).

@ericonr @q66 @Johnnynator Please let me know if you know of a different solution for the gold linker.



A patch file from https://github.com/void-linux/void-packages/pull/27752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chromium-27752.patch --]
[-- Type: text/x-diff, Size: 2874 bytes --]

From 4ea720194c17fafa7b1fbdd8abf1d1291fa7bd0b Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Thu, 7 Jan 2021 17:47:38 -0500
Subject: [PATCH 1/2] chromium: update to 87.0.4280.141.

---
 srcpkgs/chromium/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/chromium/template b/srcpkgs/chromium/template
index 7cb351b6f26..c152d188f1b 100644
--- a/srcpkgs/chromium/template
+++ b/srcpkgs/chromium/template
@@ -1,7 +1,7 @@
 # Template file for 'chromium'
 pkgname=chromium
 # See http://www.chromium.org/developers/calendar for the latest version
-version=87.0.4280.88
+version=87.0.4280.141
 revision=1
 archs="i686* x86_64* aarch64* armv7l* ppc64le*"
 short_desc="Google's attempt at creating a safer, faster, and more stable browser"
@@ -9,7 +9,7 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://www.chromium.org/"
 distfiles="https://commondatastorage.googleapis.com/chromium-browser-official/${pkgname}-${version}.tar.xz"
-checksum=3e4645328735ef60db78d1a313efb3770a3edeaede90d076414df52f567a09c0
+checksum=147591d7fc21e1a173701d28bbf35baddb91e64dd96ec16d8eee9a5113403375
 nocross=yes
 
 lib32disabled=yes
@@ -223,10 +223,11 @@ do_configure() {
 		'use_lld=false'
 	)
 
-	# XXX: gold broken with musl and i686
+	# XXX: gold broken with musl, i686, and x86_64
 	case "${XBPS_TARGET_MACHINE}" in
 	*-musl) conf+=( 'use_gold=false' ) ;;
 	i686*) conf+=( 'use_gold=false' ) ;;
+	x86_64*) conf+=( 'use_gold=false' ) ;;
 	*) conf+=( 'use_gold=true' ) ;;
 	esac
 

From 3cec9a5dd314ea2a2103f53badd42401b88c33f5 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Thu, 7 Jan 2021 17:49:32 -0500
Subject: [PATCH 2/2] chromium-widevine: update to 87.0.4280.141.

---
 srcpkgs/chromium-widevine/INSTALL  | 2 +-
 srcpkgs/chromium-widevine/template | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/chromium-widevine/INSTALL b/srcpkgs/chromium-widevine/INSTALL
index 1f63fd0f44c..d4723ffdf1f 100644
--- a/srcpkgs/chromium-widevine/INSTALL
+++ b/srcpkgs/chromium-widevine/INSTALL
@@ -1,6 +1,6 @@
 # INSTALL
 
-checksum=4bc68502dc5e22d5c264b3fb5d0a1ecfdadc3ba21d945646d8d37de4b8a96e58
+checksum=b7edb7cd5c166bf3c0a1d245baa5924e242c3b81b97090468bec778f41f40373
 _baseUrl="https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable"
 _filename="google-chrome-stable_${VERSION%_*}-1_amd64.deb"
 DISTFILE="${_baseUrl}/${_filename}"
diff --git a/srcpkgs/chromium-widevine/template b/srcpkgs/chromium-widevine/template
index 32ede6c8bda..be13eec954a 100644
--- a/srcpkgs/chromium-widevine/template
+++ b/srcpkgs/chromium-widevine/template
@@ -6,7 +6,7 @@ _chromeVersion="current"
 _channel="stable"
 
 pkgname=chromium-widevine
-version=87.0.4280.88
+version=87.0.4280.141
 revision=1
 archs="x86_64"
 create_wrksrc=yes

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: chromium: update to 87.0.4280.141.
  2021-01-07 22:56 [PR PATCH] chromium: update to 87.0.4280.141 pbui
  2021-01-07 23:02 ` [PR PATCH] [Updated] " pbui
@ 2021-01-07 23:03 ` q66
  2021-01-08 17:36 ` [PR REVIEW] " ericonr
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: q66 @ 2021-01-07 23:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/27752#issuecomment-756439406

Comment:
let's just disable gold globally, the codebase is basically bitrotting and it won't be getting any better 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] chromium: update to 87.0.4280.141.
  2021-01-07 22:56 [PR PATCH] chromium: update to 87.0.4280.141 pbui
  2021-01-07 23:02 ` [PR PATCH] [Updated] " pbui
  2021-01-07 23:03 ` q66
@ 2021-01-08 17:36 ` ericonr
  2021-01-08 17:46 ` [PR PATCH] [Updated] " pbui
  2021-01-09  6:49 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-01-08 17:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27752#discussion_r554091417

Comment:
Agree with q66, we can just disable gold globally.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] chromium: update to 87.0.4280.141.
  2021-01-07 22:56 [PR PATCH] chromium: update to 87.0.4280.141 pbui
                   ` (2 preceding siblings ...)
  2021-01-08 17:36 ` [PR REVIEW] " ericonr
@ 2021-01-08 17:46 ` pbui
  2021-01-09  6:49 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: pbui @ 2021-01-08 17:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

There is an updated pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages chromium
https://github.com/void-linux/void-packages/pull/27752

chromium: update to 87.0.4280.141.
[ci skip]

- Built for x86_64, x86_64-musl.
- Tested on x86_64.
- Update chromium-widevine as well.

Using gold to link produces a segfault during linking on x86_64, so I have disabled it (just like we have done for i686 and musl).

@ericonr @q66 @Johnnynator Please let me know if you know of a different solution for the gold linker.



A patch file from https://github.com/void-linux/void-packages/pull/27752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chromium-27752.patch --]
[-- Type: text/x-diff, Size: 3042 bytes --]

From 72e5ba47df41a4ed94093fb5b9d073995b102006 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Thu, 7 Jan 2021 17:47:38 -0500
Subject: [PATCH 1/2] chromium: update to 87.0.4280.141.

Disable gold globally since it is now broken on i686, x86_64, and musl.
---
 srcpkgs/chromium/template | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/chromium/template b/srcpkgs/chromium/template
index 7cb351b6f26..5e4d8129e5d 100644
--- a/srcpkgs/chromium/template
+++ b/srcpkgs/chromium/template
@@ -1,7 +1,7 @@
 # Template file for 'chromium'
 pkgname=chromium
 # See http://www.chromium.org/developers/calendar for the latest version
-version=87.0.4280.88
+version=87.0.4280.141
 revision=1
 archs="i686* x86_64* aarch64* armv7l* ppc64le*"
 short_desc="Google's attempt at creating a safer, faster, and more stable browser"
@@ -9,7 +9,7 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://www.chromium.org/"
 distfiles="https://commondatastorage.googleapis.com/chromium-browser-official/${pkgname}-${version}.tar.xz"
-checksum=3e4645328735ef60db78d1a313efb3770a3edeaede90d076414df52f567a09c0
+checksum=147591d7fc21e1a173701d28bbf35baddb91e64dd96ec16d8eee9a5113403375
 nocross=yes
 
 lib32disabled=yes
@@ -223,12 +223,8 @@ do_configure() {
 		'use_lld=false'
 	)
 
-	# XXX: gold broken with musl and i686
-	case "${XBPS_TARGET_MACHINE}" in
-	*-musl) conf+=( 'use_gold=false' ) ;;
-	i686*) conf+=( 'use_gold=false' ) ;;
-	*) conf+=( 'use_gold=true' ) ;;
-	esac
+	# XXX: gold broken with musl, i686, and x86_64 so disable globally
+	conf+=( 'use_gold=false' )
 
 	# Always support proprietary codecs.
 	# Enable H.264 support in bundled ffmpeg.

From ccc21e9a543b45ab606d90046007f2639e7d8750 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Thu, 7 Jan 2021 17:49:32 -0500
Subject: [PATCH 2/2] chromium-widevine: update to 87.0.4280.141.

---
 srcpkgs/chromium-widevine/INSTALL  | 2 +-
 srcpkgs/chromium-widevine/template | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/chromium-widevine/INSTALL b/srcpkgs/chromium-widevine/INSTALL
index 1f63fd0f44c..d4723ffdf1f 100644
--- a/srcpkgs/chromium-widevine/INSTALL
+++ b/srcpkgs/chromium-widevine/INSTALL
@@ -1,6 +1,6 @@
 # INSTALL
 
-checksum=4bc68502dc5e22d5c264b3fb5d0a1ecfdadc3ba21d945646d8d37de4b8a96e58
+checksum=b7edb7cd5c166bf3c0a1d245baa5924e242c3b81b97090468bec778f41f40373
 _baseUrl="https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable"
 _filename="google-chrome-stable_${VERSION%_*}-1_amd64.deb"
 DISTFILE="${_baseUrl}/${_filename}"
diff --git a/srcpkgs/chromium-widevine/template b/srcpkgs/chromium-widevine/template
index 32ede6c8bda..be13eec954a 100644
--- a/srcpkgs/chromium-widevine/template
+++ b/srcpkgs/chromium-widevine/template
@@ -6,7 +6,7 @@ _chromeVersion="current"
 _channel="stable"
 
 pkgname=chromium-widevine
-version=87.0.4280.88
+version=87.0.4280.141
 revision=1
 archs="x86_64"
 create_wrksrc=yes

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: chromium: update to 87.0.4280.141.
  2021-01-07 22:56 [PR PATCH] chromium: update to 87.0.4280.141 pbui
                   ` (3 preceding siblings ...)
  2021-01-08 17:46 ` [PR PATCH] [Updated] " pbui
@ 2021-01-09  6:49 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-01-09  6:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

There's a merged pull request on the void-packages repository

chromium: update to 87.0.4280.141.
https://github.com/void-linux/void-packages/pull/27752

Description:
[ci skip]

- Built for x86_64, x86_64-musl.
- Tested on x86_64.
- Update chromium-widevine as well.

Using gold to link produces a segfault during linking on x86_64, so I have disabled it (just like we have done for i686 and musl).

@ericonr @q66 @Johnnynator Please let me know if you know of a different solution for the gold linker.



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-09  6:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 22:56 [PR PATCH] chromium: update to 87.0.4280.141 pbui
2021-01-07 23:02 ` [PR PATCH] [Updated] " pbui
2021-01-07 23:03 ` q66
2021-01-08 17:36 ` [PR REVIEW] " ericonr
2021-01-08 17:46 ` [PR PATCH] [Updated] " pbui
2021-01-09  6:49 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).