Github messages for voidlinux
 help / color / mirror / Atom feed
From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] wine: Add wine-staging patchset as a (non-default) build option
Date: Sat, 09 Jan 2021 23:00:01 +0100	[thread overview]
Message-ID: <20210109220001.BriqKcfjRSLHl48q0TwAlX3mkC9qRwScsjsXOk7n6XY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27791@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/27791#discussion_r554478002

Comment:
Use post_patch instead, so any void patches would be used. Move `if` inside of function. Move function just before pre_build.

  parent reply	other threads:[~2021-01-09 22:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 20:07 [PR PATCH] " aeadio
2021-01-09 20:46 ` ericonr
2021-01-09 20:49 ` [PR PATCH] [Updated] " aeadio
2021-01-09 22:00 ` Chocimier [this message]
2021-01-09 22:30 ` [PR PATCH] [Updated] wine: " aeadio
2021-01-09 22:31 ` aeadio
2021-01-12 17:35 ` Hoshpak
2021-01-12 20:51 ` [PR PATCH] [Updated] " aeadio
2021-01-12 20:51 ` aeadio
2021-01-12 20:53 ` [PR PATCH] [Updated] " aeadio
2021-01-12 21:09 ` ericonr
2021-01-14 18:22 ` [PR PATCH] [Merged]: " Hoshpak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210109220001.BriqKcfjRSLHl48q0TwAlX3mkC9qRwScsjsXOk7n6XY@z \
    --to=chocimier@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).