From: Hoshpak <Hoshpak@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: wine: Add wine-staging patchset as a (non-default) build option
Date: Tue, 12 Jan 2021 18:35:46 +0100 [thread overview]
Message-ID: <20210112173546.3CZHFCZfHtw_pBMR3pWdeXG95HtejjCqQgnqt9vw4pI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27791@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
New comment by Hoshpak on void-packages repository
https://github.com/void-linux/void-packages/pull/27791#issuecomment-758820834
Comment:
I don't like having `vopt_if` in distfiles and checksum. It is somewhat
clunky and I doubt that `xgensum` would work properly with that.
Another option would be to put an if block after the variable
declaration and append to the variables if necessary.
What workflow do you have in mind for wine and the staging build
option? In the current form, updating the wine package without also
updating the staging tarball would lead to a build option until someone
also updates staging. If the staging tarballs are released in a timely
manner after the wine release, perhaps putting the staging tarball
directly in distfiles would also be an option. The builder would then
extract both tarballs but only apply the staging patches when the build
option is set. I at least wouldn't mind waiting a day after a release
to update the wine package.
next prev parent reply other threads:[~2021-01-12 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 20:07 [PR PATCH] " aeadio
2021-01-09 20:46 ` ericonr
2021-01-09 20:49 ` [PR PATCH] [Updated] " aeadio
2021-01-09 22:00 ` [PR REVIEW] wine: " Chocimier
2021-01-09 22:30 ` [PR PATCH] [Updated] " aeadio
2021-01-09 22:31 ` aeadio
2021-01-12 17:35 ` Hoshpak [this message]
2021-01-12 20:51 ` aeadio
2021-01-12 20:51 ` aeadio
2021-01-12 20:53 ` [PR PATCH] [Updated] " aeadio
2021-01-12 21:09 ` ericonr
2021-01-14 18:22 ` [PR PATCH] [Merged]: " Hoshpak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112173546.3CZHFCZfHtw_pBMR3pWdeXG95HtejjCqQgnqt9vw4pI@z \
--to=hoshpak@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).