[PR PATCH] [breaking] pipewire: update to 0.3.19

[PR PATCH] [breaking] pipewire: update to 0.3.19

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

There is a new pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages pipewire-0.3.19
https://github.com/void-linux/void-packages/pull/27712

[breaking] pipewire: update to 0.3.19
> The config file format was changed to use the SPA JSON tokenizer. This makes it more flexible and extensible.

This requires manual intervention, as most have changed the config to enabled pipewire-pulse. It is explained in the install msg.

This also adds ncurses makedep to build pw-top. But `meson.build` needs a patch to find our ncurses

A patch file from https://github.com/void-linux/void-packages/pull/27712.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.19-27712.patch --]
[-- Type: text/x-diff, Size: 3097 bytes --]

From d9614e3f4d72860b210a9336f7a2695a51eb30fb Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Tue, 5 Jan 2021 23:15:47 +0100
Subject: [PATCH] pipewire: update to 0.3.19

* add ncurses makedep for pw-top
---
 srcpkgs/pipewire/INSTALL.msg            |  3 +++
 srcpkgs/pipewire/patches/ncursesw.patch | 11 +++++++++++
 srcpkgs/pipewire/template               |  6 +++---
 3 files changed, 17 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/pipewire/INSTALL.msg
 create mode 100644 srcpkgs/pipewire/patches/ncursesw.patch

diff --git a/srcpkgs/pipewire/INSTALL.msg b/srcpkgs/pipewire/INSTALL.msg
new file mode 100644
index 00000000000..f7c4437683d
--- /dev/null
+++ b/srcpkgs/pipewire/INSTALL.msg
@@ -0,0 +1,3 @@
+WARNING: pipewire>=0.3.19 changed the config file format. If
+you edited /etc/pipewire/pipewire.conf you must recreate it from
+/etc/pipewire/pipewire.conf.new-0.3.19_1 with your changes on top.
diff --git a/srcpkgs/pipewire/patches/ncursesw.patch b/srcpkgs/pipewire/patches/ncursesw.patch
new file mode 100644
index 00000000000..92598546b11
--- /dev/null
+++ b/srcpkgs/pipewire/patches/ncursesw.patch
@@ -0,0 +1,11 @@
+--- meson.build.orig	2021-01-05 18:40:24.345620177 +0100
++++ meson.build	2021-01-05 18:40:43.209619527 +0100
+@@ -325,7 +325,7 @@
+ pthread_lib = dependency('threads')
+ dbus_dep = dependency('dbus-1')
+ sdl_dep = dependency('sdl2', required : false)
+-ncurses_dep = dependency('ncurses', required : false)
++ncurses_dep = dependency('ncursesw', required : false)
+ sndfile_dep = dependency('sndfile', version : '>= 1.0.20', required : false)
+ 
+ if get_option('gstreamer')
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index bd2bafdada7..7ad025fa5a5 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.18
+version=0.3.19
 revision=1
 build_style=meson
 configure_args="-Dman=true -Dgstreamer=true -Ddocs=true -Dsystemd=false
@@ -8,7 +8,7 @@ configure_args="-Dman=true -Dgstreamer=true -Ddocs=true -Dsystemd=false
  -Dudevrulesdir=/usr/lib/udev/rules.d"
 hostmakedepends="doxygen graphviz pkg-config xmltoman"
 makedepends="SDL2-devel ffmpeg-devel gst-plugins-base1-devel jack-devel
- sbc-devel v4l-utils-devel libva-devel libbluetooth-devel"
+ sbc-devel v4l-utils-devel libva-devel libbluetooth-devel ncurses-devel"
 depends="libspa-alsa libspa-audioconvert libspa-audiomixer libspa-control"
 short_desc="Server and user space API to deal with multimedia pipelines"
 maintainer="Kridsada Thanabulpong <sirn@ogsite.net>"
@@ -16,7 +16,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=a7317de8e54f57190a2e2fe5f469ed332b9a12151fade03bf984765a55e5e24b
+checksum=de2e757a57ff313362341f4b18b976c707d397d853c0cd2032975b76d0c540dc
 conf_files="/etc/pipewire/pipewire.conf"
 
 replaces="libpulseaudio-pipewire>=0"

Re: [PR REVIEW] [breaking] pipewire: update to 0.3.19

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27712#discussion_r552894340

Comment:
Is this necessary? I think our ncurses is always `ncursesw`.

Re: [PR REVIEW] [breaking] pipewire: update to 0.3.19

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27712#discussion_r552899066

Comment:
> Is this necessary? I think our ncurses is always `ncursesw`.

we have no `ncurses.pc`, only `ncursesw.pc`, so without the patch it is not found...

Re: [PR REVIEW] [breaking] pipewire: update to 0.3.19

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/27712#discussion_r552899066

Comment:
> Is this necessary? I think our ncurses is always `ncursesw`.

we have no `ncurses.pc`, only `ncursesw.pc`, so without the patch it is not found... not sure what is the correct way to deal with this

Re: [PR REVIEW] [breaking] pipewire: update to 0.3.19

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27712#discussion_r552914655

Comment:
Hmm, me neither... Should we have a `ncurses.pc` symlink, maybe?

Re: [PR REVIEW] [breaking] pipewire: update to 0.3.19

[biopsin]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New review comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/27712#discussion_r553828545

Comment:
should this also not be added in the template, something like

```
pre_build() {
	vsed -i "s|ncurses'|ncursesw'|" meson.build
}
```
I'm probably mistaken, but my impression was patches should be rather added when things get more complicated..

Re: [breaking] pipewire: update to 0.3.19

[subsonik]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

New comment by subsonik on void-packages repository

https://github.com/void-linux/void-packages/pull/27712#issuecomment-760249248

Comment:
I was going to open a pull request for this, as it's quite an important update, and I've been using it very successfully on my machine, but I found this instead.

I'm not sure if a decision was reached re: the ncursesw patch, but I can confirm that it works fine for me (incl. pw-top).

Re: [breaking] pipewire: update to 0.3.19

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27712#issuecomment-760255132

Comment:
Should probably look to upstream a similar patch (trying both ncursesw and ncurses as a fallback).

Re: [PR PATCH] [Merged]: [breaking] pipewire: update to 0.3.19

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

There's a merged pull request on the void-packages repository

[breaking] pipewire: update to 0.3.19
https://github.com/void-linux/void-packages/pull/27712

Description:
> The config file format was changed to use the SPA JSON tokenizer. This makes it more flexible and extensible.

This requires manual intervention, as most have changed the config to launch pipewire-pulse. It is explained in the install msg.

This also adds ncurses makedep to build pw-top. But `meson.build` needs a patch to find our ncurses