Github messages for voidlinux
 help / color / mirror / Atom feed
From: adriangoransson <adriangoransson@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] sof-firmware: link firmwares for Jasper Lake and Tiger Lake
Date: Sat, 16 Jan 2021 10:17:08 +0100	[thread overview]
Message-ID: <20210116091708.3PodpTgzPwaBkd2ZlGMn9Iz9K-a3bQrL5shFps_cPhg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27917@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

There is an updated pull request by adriangoransson against master on the void-packages repository

https://github.com/adriangoransson/void-packages master
https://github.com/void-linux/void-packages/pull/27917

sof-firmware: link firmwares for Jasper Lake and Tiger Lake
After hours of trying to find out why SOF (from repo) didn't like my
hardware, I tried installing the archive directly from
github.com/thesofproject/sof-bin/ instead. To my surprise, it worked!

Taking a closer look at the template, I realized that the firmware files
for my system weren't linked, causing the following errors on boot.

```
[   11.829580] sof-audio-pci 0000:00:1f.3: error: request firmware intel/sof/sof-tgl.ri failed err: -2
[   11.829709] sof-audio-pci 0000:00:1f.3: error: failed to load DSP firmware -2
[   11.830177] sof-audio-pci 0000:00:1f.3: error: sof_probe_work failed err: -2
```

**Note**
I have only tested this on Tiger Lake.

A patch file from https://github.com/void-linux/void-packages/pull/27917.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-27917.patch --]
[-- Type: text/x-diff, Size: 1800 bytes --]

From bf60b0d9593938be7b18bc462392420cd8a20c69 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adrian=20G=C3=B6ransson?= <adriangoransson@gmail.com>
Date: Thu, 14 Jan 2021 10:13:40 +0100
Subject: [PATCH] sof-firmware: link firmwares for Elkhart Lake and Tiger Lake

After hours of trying to find out why SOF (from repo) didn't like my
hardware, I tried installing the archive directly from
github.com/thesofproject/sof-bin/ instead. To my surprise, it worked!

Taking a closer look at the template, I realized that the firmware files
for my system weren't linked, causing the following errors on boot.

```
[   11.829580] sof-audio-pci 0000:00:1f.3: error: request firmware intel/sof/sof-tgl.ri failed err: -2
[   11.829709] sof-audio-pci 0000:00:1f.3: error: failed to load DSP firmware -2
[   11.830177] sof-audio-pci 0000:00:1f.3: error: sof_probe_work failed err: -2
```

**Note**
I have only tested this with Tiger Lake.
---
 srcpkgs/sof-firmware/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index cf237de16a6..3f033e375b3 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,7 +1,7 @@
 # Template file for 'sof-firmware'
 pkgname=sof-firmware
 version=1.6.1
-revision=1
+revision=2
 archs="i686* x86_64*"
 wrksrc="sof-bin-${version}"
 depends="alsa-ucm-conf"
@@ -26,7 +26,7 @@ do_install() {
 	for arc in {bdw,byt,cht}; do
 		ln -s sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
 	done
-	for arc in {apl,cnl,icl}; do
+	for arc in {apl,cnl,icl,ehl,tgl}; do
 		ln -s intel-signed/sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
 	done
 	ln -s intel-signed/sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri

  parent reply	other threads:[~2021-01-16  9:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14  9:26 [PR PATCH] " adriangoransson
2021-01-14 10:26 ` [PR PATCH] [Updated] " adriangoransson
2021-01-16  3:15 ` [PR REVIEW] " cinerea0
2021-01-16  4:24 ` cinerea0
2021-01-16  9:17 ` adriangoransson [this message]
2021-01-16  9:17 ` [PR REVIEW] " adriangoransson
2021-01-20  0:06 ` sof-firmware: link firmwares for Elkhart " ericonr
2021-01-20  5:50 ` cinerea0
2021-01-20  9:07 ` adriangoransson
2021-01-20 15:27 ` ericonr
2021-01-21  0:29 ` cinerea0
2021-01-21 20:45 ` adriangoransson
2021-01-21 20:45 ` adriangoransson
2021-01-21 22:37 ` cinerea0
2021-01-23 10:51 ` [PR PATCH] [Updated] " adriangoransson
2021-01-23 10:55 ` sof-firmware: use provided install script adriangoransson
2021-01-26  3:12 ` ericonr
2021-01-26  3:12 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210116091708.3PodpTgzPwaBkd2ZlGMn9Iz9K-a3bQrL5shFps_cPhg@z \
    --to=adriangoransson@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).