Github messages for voidlinux
 help / color / mirror / Atom feed
From: cinerea0 <cinerea0@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: sof-firmware: link firmwares for Elkhart Lake and Tiger Lake
Date: Wed, 20 Jan 2021 06:50:19 +0100	[thread overview]
Message-ID: <20210120055019.ylOIs_qYVx5AHukKWPaL0c8ql0gm8ZUyHhO9w_58VRE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27917@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/27917#issuecomment-763352523

Comment:
Good news: I was able to find a way to use their own script to do the installation with only a little bit of patching required; I'll copy my files below. Bad news: I also realized that this package didn't install the firmware tools that come with it, and in my attempt to do so I've run into another problem. The xbps-src error I've encountered is `SONAME: libsof_tplg_parser.so <-> UNKNOWN PKG PLEASE FIX!`. I know this is a problem with `common/shlibs`, but for the life of me I can't figure out where this library comes from.

Changed part of the template:
```shell
do_install() {
	for bin in tools/v${version}/*; do
		vbin ${bin}
	done
	vlicense LICENCE.NXP
	vmkdir usr/lib/firmware/intel
	export ROOT=${DESTDIR}
	export SOF_VERSION=v${version}
	./go.sh
}
```

go.sh.patch:
```patch
--- go.sh	2020-12-18 07:13:44.000000000 -0500
+++ "go (copy).sh"	2021-01-20 00:29:55.823488423 -0500
@@ -11,13 +11,13 @@
 test -n "${ROOT}" ||  \
     ROOT=
 test -n "${INTEL_PATH}" || \
-    INTEL_PATH=lib/firmware/intel
+    INTEL_PATH=usr/lib/firmware/intel
 test -n "${SOF_VERSION}" || \
     SOF_VERSION=$(git symbolic-ref HEAD 2>/dev/null | cut -d"/" -f 3| cut -d"-" -f 2)
 test -n "${SOF_VERSION}" || \
     { echo "Can't work out SOF_VERSION using git, please specify SOF_VERSION as environment variable"; exit 1; }
 
-test -d ${INTEL_PATH}/sof-tplg-${SOF_VERSION} || \
+test -d lib/firmware/intel/sof-tplg-${SOF_VERSION} || \
     { echo "Can't find version ${SOF_VERSION} - are you missing leading v?"; exit 2; }
 
 echo "Installing Intel firmware and topology $SOF_VERSION to $INTEL_PATH"
@@ -28,8 +28,9 @@
 rm -rf ${ROOT}/${INTEL_PATH}/sof-tplg
 
 # copy to destination
-cd lib/firmware
-cp -rf intel ${ROOT}/lib/firmware
+cd lib/firmware/intel
+cp -rf sof ${ROOT}/${INTEL_PATH}
+cp -rf sof-tplg-${SOF_VERSION} ${ROOT}/${INTEL_PATH}
 
 # add symlinks
 cd ${ROOT}/${INTEL_PATH}/sof
```

  parent reply	other threads:[~2021-01-20  5:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14  9:26 [PR PATCH] sof-firmware: link firmwares for Jasper " adriangoransson
2021-01-14 10:26 ` [PR PATCH] [Updated] " adriangoransson
2021-01-16  3:15 ` [PR REVIEW] " cinerea0
2021-01-16  4:24 ` cinerea0
2021-01-16  9:17 ` [PR PATCH] [Updated] " adriangoransson
2021-01-16  9:17 ` [PR REVIEW] " adriangoransson
2021-01-20  0:06 ` sof-firmware: link firmwares for Elkhart " ericonr
2021-01-20  5:50 ` cinerea0 [this message]
2021-01-20  9:07 ` adriangoransson
2021-01-20 15:27 ` ericonr
2021-01-21  0:29 ` cinerea0
2021-01-21 20:45 ` adriangoransson
2021-01-21 20:45 ` adriangoransson
2021-01-21 22:37 ` cinerea0
2021-01-23 10:51 ` [PR PATCH] [Updated] " adriangoransson
2021-01-23 10:55 ` sof-firmware: use provided install script adriangoransson
2021-01-26  3:12 ` ericonr
2021-01-26  3:12 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120055019.ylOIs_qYVx5AHukKWPaL0c8ql0gm8ZUyHhO9w_58VRE@z \
    --to=cinerea0@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).