Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: swaylock-effects-1.6_3
@ 2021-01-17  2:43 desowyrm
  2021-01-17 11:17 ` [PR REVIEW] " Duncaen
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: desowyrm @ 2021-01-17  2:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

There is a new pull request by desowyrm against master on the void-packages repository

https://github.com/desowyrm/void-packages swaylock-effects-branch
https://github.com/void-linux/void-packages/pull/27971

New package: swaylock-effects-1.6_3
Swaylock-effects is a fork of swaylock. It adds upon swaylock with fancy effects such a blurring.

A patch file from https://github.com/void-linux/void-packages/pull/27971.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-swaylock-effects-branch-27971.patch --]
[-- Type: text/x-diff, Size: 1350 bytes --]

From b0547297635305b8fde835b0489519f10859df39 Mon Sep 17 00:00:00 2001
From: desowyrm <desowyrm.biomes@slmail.me>
Date: Sun, 17 Jan 2021 03:39:20 +0100
Subject: [PATCH] New package: swaylock-effects-1.6_3

---
 srcpkgs/swaylock-effects/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/swaylock-effects/template

diff --git a/srcpkgs/swaylock-effects/template b/srcpkgs/swaylock-effects/template
new file mode 100644
index 00000000000..820fe1085ed
--- /dev/null
+++ b/srcpkgs/swaylock-effects/template
@@ -0,0 +1,21 @@
+# Template file for 'swaylock-effects'
+pkgname=swaylock-effects
+version=1.6
+revision=3
+wrksrc=${pkgname}-${version}-${revision}
+build_style=meson
+conf_files="/etc/pam.d/swaylock"
+hostmakedepends="pkg-config wayland-devel scdoc git"
+makedepends="wayland-protocols cairo-devel gdk-pixbuf-devel pam-devel
+ libxkbcommon-devel wayland-devel libgomp-devel"
+short_desc="Screen locker for Wayland - Swaylock, with fancy effects"
+maintainer="desowyrm <desowyrm.biomes@slmail.me>"
+license="MIT"
+homepage="https://github.com/mortie/swaylock-effects"
+distfiles="https://github.com/mortie/${pkgname}/archive/v${version}-${revision}.tar.gz"
+checksum="c7c4e420276aef9bd952b321b68e24c31f050859a226edb8fde15a5ccee1a9fe"
+conflicts="swaylock"
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
@ 2021-01-17 11:17 ` Duncaen
  2021-01-17 11:18 ` Duncaen
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Duncaen @ 2021-01-17 11:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/27971#discussion_r559163653

Comment:
Revision is voids internal number to bump the package if a rebuild is required, i.e. because a dependency is updated.
This revision is part of the version number, i.e use something like:

```
version=1.6p3
wrksrc="${pkgname}-${version/p/-}"
distfiles="https://github.com/mortie/${pkgname}/archive/v${version/p/-}.tar.gz"
```

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
  2021-01-17 11:17 ` [PR REVIEW] " Duncaen
@ 2021-01-17 11:18 ` Duncaen
  2021-01-17 21:39 ` [PR PATCH] [Updated] " desowyrm
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Duncaen @ 2021-01-17 11:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/27971#discussion_r559163653

Comment:
Revision is voids internal number to bump the package if a rebuild is required, i.e. because a dependency is updated.
This revision (`3`) is part of the version number, i.e use something like:

```
version=1.6p3
wrksrc="${pkgname}-${version/p/-}"
distfiles="https://github.com/mortie/${pkgname}/archive/v${version/p/-}.tar.gz"
```

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
  2021-01-17 11:17 ` [PR REVIEW] " Duncaen
  2021-01-17 11:18 ` Duncaen
@ 2021-01-17 21:39 ` desowyrm
  2021-01-17 21:44 ` [PR REVIEW] " desowyrm
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: desowyrm @ 2021-01-17 21:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

There is an updated pull request by desowyrm against master on the void-packages repository

https://github.com/desowyrm/void-packages swaylock-effects-branch
https://github.com/void-linux/void-packages/pull/27971

New package: swaylock-effects-1.6_3
Swaylock-effects is a fork of swaylock. It adds upon swaylock with fancy effects such a blurring.

A patch file from https://github.com/void-linux/void-packages/pull/27971.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-swaylock-effects-branch-27971.patch --]
[-- Type: text/x-diff, Size: 2002 bytes --]

From e49229e05c43dbbbae87d84076fd856757a865e4 Mon Sep 17 00:00:00 2001
From: desowyrm <desowyrm.biomes@slmail.me>
Date: Sun, 17 Jan 2021 03:39:20 +0100
Subject: [PATCH] New package: swaylock-effects-1.6_3 Added patch and corrected
 template

---
 .../patches/meson.build.patch                 | 10 +++++++++
 srcpkgs/swaylock-effects/template             | 21 +++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 srcpkgs/swaylock-effects/patches/meson.build.patch
 create mode 100644 srcpkgs/swaylock-effects/template

diff --git a/srcpkgs/swaylock-effects/patches/meson.build.patch b/srcpkgs/swaylock-effects/patches/meson.build.patch
new file mode 100644
index 00000000000..e898782f84d
--- /dev/null
+++ b/srcpkgs/swaylock-effects/patches/meson.build.patch
@@ -0,0 +1,10 @@
+--- meson.build-orig	2021-01-17 22:22:48.531582216 +0100
++++ meson.build		2021-01-17 22:23:19.891581408 +0100
+@@ -18,7 +18,6 @@
+ 		'-Wundef',
+ 		'-Wvla',
+ 		'-fopenmp',
+-		'-mtune=native',
+ 	],
+ 	language: 'c',
+ )
diff --git a/srcpkgs/swaylock-effects/template b/srcpkgs/swaylock-effects/template
new file mode 100644
index 00000000000..2bb898e3f2d
--- /dev/null
+++ b/srcpkgs/swaylock-effects/template
@@ -0,0 +1,21 @@
+# Template file for 'swaylock-effects'
+pkgname=swaylock-effects
+version=1.6p3
+revision=1
+wrksrc="${pkgname}-${version/p/-}"
+build_style=meson
+conf_files="/etc/pam.d/swaylock"
+hostmakedepends="pkg-config wayland-devel scdoc git"
+makedepends="wayland-protocols cairo-devel gdk-pixbuf-devel pam-devel
+ libxkbcommon-devel wayland-devel libgomp-devel"
+short_desc="Screen locker for Wayland - Swaylock, with fancy effects"
+maintainer="desowyrm <desowyrm.biomes@slmail.me>"
+license="MIT"
+homepage="https://github.com/mortie/swaylock-effects"
+distfiles="https://github.com/mortie/${pkgname}/archive/v${version/p/-}.tar.gz"
+checksum="c7c4e420276aef9bd952b321b68e24c31f050859a226edb8fde15a5ccee1a9fe"
+conflicts="swaylock"
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
                   ` (2 preceding siblings ...)
  2021-01-17 21:39 ` [PR PATCH] [Updated] " desowyrm
@ 2021-01-17 21:44 ` desowyrm
  2021-01-17 22:43 ` ericonr
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: desowyrm @ 2021-01-17 21:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by desowyrm on void-packages repository

https://github.com/void-linux/void-packages/pull/27971#discussion_r559242762

Comment:
Thank you for your help. I really appreciate it. :smiley: 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
                   ` (3 preceding siblings ...)
  2021-01-17 21:44 ` [PR REVIEW] " desowyrm
@ 2021-01-17 22:43 ` ericonr
  2021-01-17 22:43 ` ericonr
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-01-17 22:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27971#discussion_r559249513

Comment:
Having this in cflags doesn't fill me with confidence about upstream...

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
                   ` (4 preceding siblings ...)
  2021-01-17 22:43 ` ericonr
@ 2021-01-17 22:43 ` ericonr
  2021-01-17 22:47 ` [PR PATCH] [Updated] " desowyrm
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-01-17 22:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27971#discussion_r559249636

Comment:
```suggestion
short_desc="Screen locker for Wayland with fancy effects"
```

It already has `swaylock` in the package name.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
                   ` (5 preceding siblings ...)
  2021-01-17 22:43 ` ericonr
@ 2021-01-17 22:47 ` desowyrm
  2021-01-17 23:01 ` desowyrm
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: desowyrm @ 2021-01-17 22:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

There is an updated pull request by desowyrm against master on the void-packages repository

https://github.com/desowyrm/void-packages swaylock-effects-branch
https://github.com/void-linux/void-packages/pull/27971

New package: swaylock-effects-1.6_3
Swaylock-effects is a fork of swaylock. It adds upon swaylock with fancy effects such a blurring.

A patch file from https://github.com/void-linux/void-packages/pull/27971.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-swaylock-effects-branch-27971.patch --]
[-- Type: text/x-diff, Size: 3181 bytes --]

From e49229e05c43dbbbae87d84076fd856757a865e4 Mon Sep 17 00:00:00 2001
From: desowyrm <desowyrm.biomes@slmail.me>
Date: Sun, 17 Jan 2021 03:39:20 +0100
Subject: [PATCH 1/2] New package: swaylock-effects-1.6_3 Added patch and
 corrected template

---
 .../patches/meson.build.patch                 | 10 +++++++++
 srcpkgs/swaylock-effects/template             | 21 +++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 srcpkgs/swaylock-effects/patches/meson.build.patch
 create mode 100644 srcpkgs/swaylock-effects/template

diff --git a/srcpkgs/swaylock-effects/patches/meson.build.patch b/srcpkgs/swaylock-effects/patches/meson.build.patch
new file mode 100644
index 00000000000..e898782f84d
--- /dev/null
+++ b/srcpkgs/swaylock-effects/patches/meson.build.patch
@@ -0,0 +1,10 @@
+--- meson.build-orig	2021-01-17 22:22:48.531582216 +0100
++++ meson.build		2021-01-17 22:23:19.891581408 +0100
+@@ -18,7 +18,6 @@
+ 		'-Wundef',
+ 		'-Wvla',
+ 		'-fopenmp',
+-		'-mtune=native',
+ 	],
+ 	language: 'c',
+ )
diff --git a/srcpkgs/swaylock-effects/template b/srcpkgs/swaylock-effects/template
new file mode 100644
index 00000000000..2bb898e3f2d
--- /dev/null
+++ b/srcpkgs/swaylock-effects/template
@@ -0,0 +1,21 @@
+# Template file for 'swaylock-effects'
+pkgname=swaylock-effects
+version=1.6p3
+revision=1
+wrksrc="${pkgname}-${version/p/-}"
+build_style=meson
+conf_files="/etc/pam.d/swaylock"
+hostmakedepends="pkg-config wayland-devel scdoc git"
+makedepends="wayland-protocols cairo-devel gdk-pixbuf-devel pam-devel
+ libxkbcommon-devel wayland-devel libgomp-devel"
+short_desc="Screen locker for Wayland - Swaylock, with fancy effects"
+maintainer="desowyrm <desowyrm.biomes@slmail.me>"
+license="MIT"
+homepage="https://github.com/mortie/swaylock-effects"
+distfiles="https://github.com/mortie/${pkgname}/archive/v${version/p/-}.tar.gz"
+checksum="c7c4e420276aef9bd952b321b68e24c31f050859a226edb8fde15a5ccee1a9fe"
+conflicts="swaylock"
+
+post_install() {
+	vlicense LICENSE
+}

From 0fd30cd2fff748a1a41c06d871b5c6136ce96a75 Mon Sep 17 00:00:00 2001
From: desowyrm <68990752+desowyrm@users.noreply.github.com>
Date: Sun, 17 Jan 2021 23:47:22 +0100
Subject: [PATCH 2/2] Update srcpkgs/swaylock-effects/template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Érico Nogueira Rolim <34201958+ericonr@users.noreply.github.com>
---
 srcpkgs/swaylock-effects/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/swaylock-effects/template b/srcpkgs/swaylock-effects/template
index 2bb898e3f2d..78f44bb3990 100644
--- a/srcpkgs/swaylock-effects/template
+++ b/srcpkgs/swaylock-effects/template
@@ -8,7 +8,7 @@ conf_files="/etc/pam.d/swaylock"
 hostmakedepends="pkg-config wayland-devel scdoc git"
 makedepends="wayland-protocols cairo-devel gdk-pixbuf-devel pam-devel
  libxkbcommon-devel wayland-devel libgomp-devel"
-short_desc="Screen locker for Wayland - Swaylock, with fancy effects"
+short_desc="Screen locker for Wayland with fancy effects"
 maintainer="desowyrm <desowyrm.biomes@slmail.me>"
 license="MIT"
 homepage="https://github.com/mortie/swaylock-effects"

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
                   ` (6 preceding siblings ...)
  2021-01-17 22:47 ` [PR PATCH] [Updated] " desowyrm
@ 2021-01-17 23:01 ` desowyrm
  2021-01-17 23:01 ` [PR PATCH] [Closed]: " desowyrm
  2021-01-17 23:05 ` [PR REVIEW] " desowyrm
  9 siblings, 0 replies; 11+ messages in thread
From: desowyrm @ 2021-01-17 23:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

New comment by desowyrm on void-packages repository

https://github.com/void-linux/void-packages/pull/27971#issuecomment-761896272

Comment:
> For what it's worth, there's probably a reason upstream hasn't accepted this.
> 
> I'd also like to point you at https://www.jwz.org/xscreensaver/toolkits.html about complex lock screens.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Closed]: New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
                   ` (7 preceding siblings ...)
  2021-01-17 23:01 ` desowyrm
@ 2021-01-17 23:01 ` desowyrm
  2021-01-17 23:05 ` [PR REVIEW] " desowyrm
  9 siblings, 0 replies; 11+ messages in thread
From: desowyrm @ 2021-01-17 23:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

There's a closed pull request on the void-packages repository

New package: swaylock-effects-1.6_3
https://github.com/void-linux/void-packages/pull/27971

Description:
Swaylock-effects is a fork of swaylock. It adds upon swaylock with fancy effects such a blurring.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: swaylock-effects-1.6_3
  2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
                   ` (8 preceding siblings ...)
  2021-01-17 23:01 ` [PR PATCH] [Closed]: " desowyrm
@ 2021-01-17 23:05 ` desowyrm
  9 siblings, 0 replies; 11+ messages in thread
From: desowyrm @ 2021-01-17 23:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New review comment by desowyrm on void-packages repository

https://github.com/void-linux/void-packages/pull/27971#discussion_r559252629

Comment:
Thanks for linking me to that article. I haven't really thought about it from a security perspective. It's quite eye-opening and raises valid points.

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-01-17 23:05 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-17  2:43 [PR PATCH] New package: swaylock-effects-1.6_3 desowyrm
2021-01-17 11:17 ` [PR REVIEW] " Duncaen
2021-01-17 11:18 ` Duncaen
2021-01-17 21:39 ` [PR PATCH] [Updated] " desowyrm
2021-01-17 21:44 ` [PR REVIEW] " desowyrm
2021-01-17 22:43 ` ericonr
2021-01-17 22:43 ` ericonr
2021-01-17 22:47 ` [PR PATCH] [Updated] " desowyrm
2021-01-17 23:01 ` desowyrm
2021-01-17 23:01 ` [PR PATCH] [Closed]: " desowyrm
2021-01-17 23:05 ` [PR REVIEW] " desowyrm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).