[PR PATCH] liquid-dsp: fix build

[PR PATCH] liquid-dsp: fix build

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages liquid-dsp
https://github.com/void-linux/void-packages/pull/28013

liquid-dsp: fix build
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to include "[ci skip]' in
either the PR title or this description. When skipping CI, uncomment and complete
the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

[ci skip]
-->


A patch file from https://github.com/void-linux/void-packages/pull/28013.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-liquid-dsp-28013.patch --]
[-- Type: text/x-diff, Size: 1092 bytes --]

From c6ebac9c5178d77753267849d5793722be8aee45 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 20:51:30 +0700
Subject: [PATCH] liquid-dsp: fix build

---
 srcpkgs/liquid-dsp/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/liquid-dsp/template b/srcpkgs/liquid-dsp/template
index b1cff261bc1..d03535ae660 100644
--- a/srcpkgs/liquid-dsp/template
+++ b/srcpkgs/liquid-dsp/template
@@ -3,6 +3,7 @@ pkgname=liquid-dsp
 version=1.3.1
 revision=1
 build_style=gnu-configure
+configure_args="--exec-prefix="
 hostmakedepends="automake"
 makedepends="fftw-devel"
 short_desc="Signal processing library for software-defined radios (SDR)"
@@ -12,10 +13,6 @@ homepage="http://liquidsdr.org/"
 distfiles="https://github.com/jgaeddert/liquid-dsp/archive/v${version}.tar.gz"
 checksum=e3f66ce72a3b5d74eea5ccffb049c62c422c91b0ab92d6dbbef21af3c3bfec73
 
-case "$XBPS_TARGET_MACHINE" in
-	i686) configure_args+=" --exec-prefix=" ;;
-esac
-
 pre_configure() {
 	autoreconf -fi
 }

Re: [PR PATCH] [Closed]: liquid-dsp: fix build

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

There's a closed pull request on the void-packages repository

liquid-dsp: fix build
https://github.com/void-linux/void-packages/pull/28013

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to include "[ci skip]' in
either the PR title or this description. When skipping CI, uncomment and complete
the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

[ci skip]
-->

Re: [PR PATCH] [Updated] liquid-dsp: fix build

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages liquid-dsp
https://github.com/void-linux/void-packages/pull/28013

liquid-dsp: fix build
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to include "[ci skip]' in
either the PR title or this description. When skipping CI, uncomment and complete
the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

[ci skip]
-->


A patch file from https://github.com/void-linux/void-packages/pull/28013.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-liquid-dsp-28013.patch --]
[-- Type: text/x-diff, Size: 1828 bytes --]

From c6ebac9c5178d77753267849d5793722be8aee45 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 20:51:30 +0700
Subject: [PATCH 1/2] liquid-dsp: fix build

---
 srcpkgs/liquid-dsp/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/liquid-dsp/template b/srcpkgs/liquid-dsp/template
index b1cff261bc1..d03535ae660 100644
--- a/srcpkgs/liquid-dsp/template
+++ b/srcpkgs/liquid-dsp/template
@@ -3,6 +3,7 @@ pkgname=liquid-dsp
 version=1.3.1
 revision=1
 build_style=gnu-configure
+configure_args="--exec-prefix="
 hostmakedepends="automake"
 makedepends="fftw-devel"
 short_desc="Signal processing library for software-defined radios (SDR)"
@@ -12,10 +13,6 @@ homepage="http://liquidsdr.org/"
 distfiles="https://github.com/jgaeddert/liquid-dsp/archive/v${version}.tar.gz"
 checksum=e3f66ce72a3b5d74eea5ccffb049c62c422c91b0ab92d6dbbef21af3c3bfec73
 
-case "$XBPS_TARGET_MACHINE" in
-	i686) configure_args+=" --exec-prefix=" ;;
-esac
-
 pre_configure() {
 	autoreconf -fi
 }

From 9d073b4d6d745d283b81bfbf219e4827651f3a64 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 20:57:48 +0700
Subject: [PATCH 2/2] GitHub Action: build on push to non-master branches

---
 .github/workflows/build.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d8328911eec..bdc04c7b6d0 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -1,6 +1,10 @@
-name: Check PR
+name: Check build
 
-on: pull_request
+on:
+  pull_request:
+  push:
+    branches-ignore:
+      - master
 
 jobs:
   # Lint changed templates.

Re: [PR PATCH] [Updated] liquid-dsp: fix build

[sgn]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages liquid-dsp
https://github.com/void-linux/void-packages/pull/28013

liquid-dsp: fix build
See https://github.com/sgn/void-packages/actions/runs/493766269

A patch file from https://github.com/void-linux/void-packages/pull/28013.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-liquid-dsp-28013.patch --]
[-- Type: text/x-diff, Size: 1828 bytes --]

From c6ebac9c5178d77753267849d5793722be8aee45 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 20:51:30 +0700
Subject: [PATCH 1/2] liquid-dsp: fix build

---
 srcpkgs/liquid-dsp/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/liquid-dsp/template b/srcpkgs/liquid-dsp/template
index b1cff261bc1..d03535ae660 100644
--- a/srcpkgs/liquid-dsp/template
+++ b/srcpkgs/liquid-dsp/template
@@ -3,6 +3,7 @@ pkgname=liquid-dsp
 version=1.3.1
 revision=1
 build_style=gnu-configure
+configure_args="--exec-prefix="
 hostmakedepends="automake"
 makedepends="fftw-devel"
 short_desc="Signal processing library for software-defined radios (SDR)"
@@ -12,10 +13,6 @@ homepage="http://liquidsdr.org/"
 distfiles="https://github.com/jgaeddert/liquid-dsp/archive/v${version}.tar.gz"
 checksum=e3f66ce72a3b5d74eea5ccffb049c62c422c91b0ab92d6dbbef21af3c3bfec73
 
-case "$XBPS_TARGET_MACHINE" in
-	i686) configure_args+=" --exec-prefix=" ;;
-esac
-
 pre_configure() {
 	autoreconf -fi
 }

From 94b3e190f4e2b356c457650d7ada551db0a4338a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 21:02:52 +0700
Subject: [PATCH 2/2] GitHub Action: build on push to non-master branches

---
 .github/workflows/build.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d8328911eec..bdc04c7b6d0 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -1,6 +1,10 @@
-name: Check PR
+name: Check build
 
-on: pull_request
+on:
+  pull_request:
+  push:
+    branches-ignore:
+      - master
 
 jobs:
   # Lint changed templates.

Re: GitHub Action: build on push to non-master branches

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28013#issuecomment-762280378

Comment:
Doesn't this mean that a staging branch with huge changes will be unnecessarily running CI? I have a couple branches I keep around that I don't want to have CI run on... Opening a PR on your own repo is the simplest way of achieving this without spending a bunch of time running builds.

Re: GitHub Action: build on push to non-master branches

[sgn]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28013#issuecomment-762285031

Comment:
We can set the ignore to pattern matching, let's say, ignore branches with name: 'wip-*'

Re: [PR PATCH] [Updated] GitHub Action: build on push to non-master branches

[sgn]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages liquid-dsp
https://github.com/void-linux/void-packages/pull/28013

GitHub Action: build on push to non-master branches
See https://github.com/sgn/void-packages/actions/runs/493766269

A patch file from https://github.com/void-linux/void-packages/pull/28013.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-liquid-dsp-28013.patch --]
[-- Type: text/x-diff, Size: 1874 bytes --]

From b68a299f86b446d886da9674226e301da4fcdb7b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 20:51:30 +0700
Subject: [PATCH 1/2] liquid-dsp: fix build

---
 srcpkgs/liquid-dsp/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/liquid-dsp/template b/srcpkgs/liquid-dsp/template
index b1cff261bc1..d03535ae660 100644
--- a/srcpkgs/liquid-dsp/template
+++ b/srcpkgs/liquid-dsp/template
@@ -3,6 +3,7 @@ pkgname=liquid-dsp
 version=1.3.1
 revision=1
 build_style=gnu-configure
+configure_args="--exec-prefix="
 hostmakedepends="automake"
 makedepends="fftw-devel"
 short_desc="Signal processing library for software-defined radios (SDR)"
@@ -12,10 +13,6 @@ homepage="http://liquidsdr.org/"
 distfiles="https://github.com/jgaeddert/liquid-dsp/archive/v${version}.tar.gz"
 checksum=e3f66ce72a3b5d74eea5ccffb049c62c422c91b0ab92d6dbbef21af3c3bfec73
 
-case "$XBPS_TARGET_MACHINE" in
-	i686) configure_args+=" --exec-prefix=" ;;
-esac
-
 pre_configure() {
 	autoreconf -fi
 }

From ed937533c4d9449620591ec79fa4c8064910a536 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 21:02:52 +0700
Subject: [PATCH 2/2] GitHub Action: build on push to non-wip non-master
 branches

---
 .github/workflows/build.yaml | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d8328911eec..12b632f1916 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -1,6 +1,12 @@
-name: Check PR
+name: Check build
 
-on: pull_request
+on:
+  pull_request:
+  push:
+    branches-ignore:
+      - master
+      - 'wip-*'
+      - '*-wip'
 
 jobs:
   # Lint changed templates.

Re: [PR PATCH] [Updated] GitHub Action: build on push to non-master branches

[sgn]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages liquid-dsp
https://github.com/void-linux/void-packages/pull/28013

GitHub Action: build on push to non-master branches
See https://github.com/sgn/void-packages/actions/runs/493766269

A patch file from https://github.com/void-linux/void-packages/pull/28013.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-liquid-dsp-28013.patch --]
[-- Type: text/x-diff, Size: 1876 bytes --]

From b68a299f86b446d886da9674226e301da4fcdb7b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 20:51:30 +0700
Subject: [PATCH 1/2] liquid-dsp: fix build

---
 srcpkgs/liquid-dsp/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/liquid-dsp/template b/srcpkgs/liquid-dsp/template
index b1cff261bc1..d03535ae660 100644
--- a/srcpkgs/liquid-dsp/template
+++ b/srcpkgs/liquid-dsp/template
@@ -3,6 +3,7 @@ pkgname=liquid-dsp
 version=1.3.1
 revision=1
 build_style=gnu-configure
+configure_args="--exec-prefix="
 hostmakedepends="automake"
 makedepends="fftw-devel"
 short_desc="Signal processing library for software-defined radios (SDR)"
@@ -12,10 +13,6 @@ homepage="http://liquidsdr.org/"
 distfiles="https://github.com/jgaeddert/liquid-dsp/archive/v${version}.tar.gz"
 checksum=e3f66ce72a3b5d74eea5ccffb049c62c422c91b0ab92d6dbbef21af3c3bfec73
 
-case "$XBPS_TARGET_MACHINE" in
-	i686) configure_args+=" --exec-prefix=" ;;
-esac
-
 pre_configure() {
 	autoreconf -fi
 }

From 0ebbc554c950c7495b3671efadd560359e67e683 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 21:02:52 +0700
Subject: [PATCH 2/2] GitHub Action: build on push to non-wip non-master
 branches

---
 .github/workflows/build.yaml | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d8328911eec..47266a17f5f 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -1,6 +1,12 @@
-name: Check PR
+name: Check build
 
-on: pull_request
+on:
+  pull_request:
+  push:
+    branches-ignore:
+      - master
+      - 'wip-**'
+      - '**-wip'
 
 jobs:
   # Lint changed templates.

Re: GitHub Action: build on push to non-master branches

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28013#issuecomment-762327451

Comment:
I'm concerned about people who aren't aware of this new default getting lots of notifications and spending more CI time than they expect. GH is kinda stupid as well, so it will have separate CI runs for the PR and for the branch in the person's repo.

Anyway, if you think this is useful (and I believe others have requested it as well), we can turn it on. As long as this doesn't impact us too much (by, say, counting the number of machines we are using by including forks), I think we can push as something experimental.

Re: GitHub Action: build on push to non-master branches

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/28013#issuecomment-762523214

Comment:
Whats the liquid-dsp change?

Re: GitHub Action: build on push to non-master branches

[sgn]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28013#issuecomment-762526561

Comment:
On 2021-01-18 16:10:09-0800, fosslinux <notifications@github.com> wrote:
> Whats the liquid-dsp change?

That one was pushed out b68a299f86b446d886da9674226e301da4fcdb7b

Re: GitHub Action: build on push to non-master branches

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28013#issuecomment-786121450

Comment:
@sgn maybe we can make CI run on branches named `ci-*` instead? That way it's opt-in.

Re: GitHub Action: build on push to non-master branches

[sgn]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28013#issuecomment-786309531

Comment:
Yay, let's do that instead.

Re: [PR PATCH] [Updated] GitHub Action: build on push to non-master branches

[sgn]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages liquid-dsp
https://github.com/void-linux/void-packages/pull/28013

GitHub Action: build on push to non-master branches
See https://github.com/sgn/void-packages/actions/runs/493766269

A patch file from https://github.com/void-linux/void-packages/pull/28013.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-liquid-dsp-28013.patch --]
[-- Type: text/x-diff, Size: 728 bytes --]

From 677e4cb4ab2ca153882025c21dc8045d7332f643 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 18 Jan 2021 21:02:52 +0700
Subject: [PATCH] GitHub Action: build on push to branches designated for CI

---
 .github/workflows/build.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d8328911eec..c08aaf94451 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -1,6 +1,10 @@
-name: Check PR
+name: Check build
 
-on: pull_request
+on:
+  pull_request:
+  push:
+    branches:
+      - 'ci-**'
 
 jobs:
   # Lint changed templates.

Re: [PR PATCH] [Merged]: GitHub Action: build on push to non-master branches

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

There's a merged pull request on the void-packages repository

GitHub Action: build on push to non-master branches
https://github.com/void-linux/void-packages/pull/28013

Description:
See https://github.com/sgn/void-packages/actions/runs/493766269