Re: -fstack-clash-protection breaks clang-built packages

Re: -fstack-clash-protection breaks clang-built packages

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/issues/10244#issuecomment-541000095

Comment:
@Hoshpak could we make the build-system smart enough to figure out we`re using `clan` and not add this `security flag` to the `CFLAGS`?.

Re: -fstack-clash-protection breaks clang-built packages

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/issues/10244#issuecomment-541000095

Comment:
@Hoshpak could we make the build-system smart enough to figure out we`re using `clan` and not add this `security flag` to the `CFLAGS`?.

@Hoshpak wait, how can I override `CFLAGS` and `CXXFLAGS` when it's [overwritten by the `build_system`](https://github.com/void-linux/void-packages/commit/6b81302e380aaf6688982b932a4efff7c642a7f5#diff-01d3507d632da4c62a40525dd3c0005dR20-R21)? 

Re: -fstack-clash-protection breaks clang-built packages

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/issues/10244#issuecomment-541020050

Comment:
@leahneukirchen @pullmoll 

I think we should handle it like the [linux kernel](https://github.com/torvalds/linux/blob/9e208aa06c2109b45eec6be049a8e47034748c20/tools/perf/util/setup.py#L18) and not add this protection unless our clang supports it.

Re: -fstack-clash-protection breaks clang-built packages

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/10244#issuecomment-541033697

Comment:
I don't think there is a good way to know which `CC` is going to be used, configure and make can do all sorts of things to use a different `CC` than what `xbps-src` exports.
`xbps-src` assumes gcc is the default compiler. I don't see a problem with templates that use a non default option having to work around the default `CFLAGS` compared to adding a probably more broken and unpredictable workaround to `xbps-src`.

Re: -fstack-clash-protection breaks clang-built packages

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/issues/10244#issuecomment-541304162

Comment:
I agree. We could of course add a compiler variable to specify if clang or gcc is used for the build but every build might still pull in the other compiler indirectly. So waiting for a clang fix and working around in the templates that need it seems the best option for me.

Re: [ISSUE] [CLOSED] -fstack-clash-protection breaks clang-built packages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Closed issue by Francesco149 on void-packages repository

https://github.com/void-linux/void-packages/issues/10244

Description:
clang doesn't support ```-fstack-clash-protection```. because of this, packages such as godot fail to build with errors like ```clang-7: error: unknown argument: '-fstack-clash-protection```

seems like this was introduced in 6b81302e380aaf6688982b932a4efff7c642a7f5

not sure if it's worth removing the flag when you can just remove it from CFLAGS in such packages, but i thought it's worth reporting

Re: -fstack-clash-protection breaks clang-built packages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/10244#issuecomment-764853570

Comment:
clang has been fixed