* Re: socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
@ 2021-01-04 23:21 ` ericonr
2021-01-05 10:07 ` [PR PATCH] [Updated] " paper42
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ericonr @ 2021-01-04 23:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27620#issuecomment-754281098
Comment:
@paper42 can you explain what this does in the commit message? I couldn't understand exactly.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Updated] socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
2021-01-04 23:21 ` ericonr
@ 2021-01-05 10:07 ` paper42
2021-01-05 10:08 ` paper42
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-01-05 10:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages 0001-socat-enable-openssl-method.patch
https://github.com/void-linux/void-packages/pull/27620
socat: enable openssl-method
A patch file from https://github.com/void-linux/void-packages/pull/27620.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-0001-socat-enable-openssl-method.patch-27620.patch --]
[-- Type: text/x-diff, Size: 844 bytes --]
From c33e89458f1e926314db1538d8c8b68e7130f61d Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 2 Jan 2021 12:27:00 +0100
Subject: [PATCH] socat: enable openssl-method
---
srcpkgs/socat/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/socat/template b/srcpkgs/socat/template
index a163d2099c0..c94b2cf8d88 100644
--- a/srcpkgs/socat/template
+++ b/srcpkgs/socat/template
@@ -1,9 +1,9 @@
# Template file for 'socat'
pkgname=socat
version=1.7.3.4
-revision=2
+revision=3
build_style=gnu-configure
-configure_args="--disable-libwrap --enable-fips
+configure_args="--disable-libwrap --enable-fips --enable-openssl-method
ac_cv_have_z_modifier=yes"
makedepends="readline-devel libressl-devel"
short_desc="Relay for bidirectional data transfer between two independent channels"
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
2021-01-04 23:21 ` ericonr
2021-01-05 10:07 ` [PR PATCH] [Updated] " paper42
@ 2021-01-05 10:08 ` paper42
2021-01-05 11:02 ` Piraty
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-01-05 10:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/27620#issuecomment-754539903
Comment:
Added to the commit message:
> allows users to specify the TLS/SSL protocol version
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
` (2 preceding siblings ...)
2021-01-05 10:08 ` paper42
@ 2021-01-05 11:02 ` Piraty
2021-01-22 8:37 ` Piraty
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Piraty @ 2021-01-05 11:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/27620#issuecomment-754566349
Comment:
```
$ grep -r -B3 openssl-method CHANGES
Porting:
OpenSSL functions TLS1_client_method() and similar are
deprecated. Socat now uses recommended TLS_client_method(). The old
functions and dependend option openssl-method can still be
used when configuring socat with --enable-openssl-method
```
sounds like it's worth a build option (off by default)?
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
` (3 preceding siblings ...)
2021-01-05 11:02 ` Piraty
@ 2021-01-22 8:37 ` Piraty
2021-01-22 11:48 ` [PR PATCH] [Updated] " paper42
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Piraty @ 2021-01-22 8:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 154 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/27620#issuecomment-765236867
Comment:
ping @paper42
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Updated] socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
` (4 preceding siblings ...)
2021-01-22 8:37 ` Piraty
@ 2021-01-22 11:48 ` paper42
2021-01-22 11:49 ` paper42
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-01-22 11:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages 0001-socat-enable-openssl-method.patch
https://github.com/void-linux/void-packages/pull/27620
socat: enable openssl-method
A patch file from https://github.com/void-linux/void-packages/pull/27620.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-0001-socat-enable-openssl-method.patch-27620.patch --]
[-- Type: text/x-diff, Size: 1232 bytes --]
From 5533a5b91fe8a711dcec3c1b848f2c1cccc0d006 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 2 Jan 2021 12:27:00 +0100
Subject: [PATCH] socat: add option to enable openssl-method
---
srcpkgs/socat/template | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/socat/template b/srcpkgs/socat/template
index a163d2099c0..d819696ecad 100644
--- a/srcpkgs/socat/template
+++ b/srcpkgs/socat/template
@@ -4,7 +4,7 @@ version=1.7.3.4
revision=2
build_style=gnu-configure
configure_args="--disable-libwrap --enable-fips
- ac_cv_have_z_modifier=yes"
+ $(vopt_if opensslmethod --enable-openssl-method) ac_cv_have_z_modifier=yes"
makedepends="readline-devel libressl-devel"
short_desc="Relay for bidirectional data transfer between two independent channels"
maintainer="q66 <daniel@octaforge.org>"
@@ -13,6 +13,9 @@ homepage="http://www.dest-unreach.org/socat/"
distfiles="http://www.dest-unreach.org/socat/download/socat-${version}.tar.bz2"
checksum=972374ca86f65498e23e3259c2ee1b8f9dbeb04d12c2a78c0c9b5d1cb97dfdfc
+build_options="opensslmethod"
+desc_option_opensslmethod="Enable openssl-method"
+
case "$XBPS_TARGET_MACHINE" in
*-musl) CFLAGS="-D_LINUX_IF_ETHER_H";;
esac
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Updated] socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
` (5 preceding siblings ...)
2021-01-22 11:48 ` [PR PATCH] [Updated] " paper42
@ 2021-01-22 11:49 ` paper42
2021-01-22 12:00 ` paper42
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-01-22 11:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages 0001-socat-enable-openssl-method.patch
https://github.com/void-linux/void-packages/pull/27620
socat: enable openssl-method
A patch file from https://github.com/void-linux/void-packages/pull/27620.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-0001-socat-enable-openssl-method.patch-27620.patch --]
[-- Type: text/x-diff, Size: 1285 bytes --]
From 8cf683ef1f7dda0e75cd7c347b630da058722c43 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 2 Jan 2021 12:27:00 +0100
Subject: [PATCH] socat: add option to enable openssl-method
allows users to specify the TLS/SSL protocol version
---
srcpkgs/socat/template | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/socat/template b/srcpkgs/socat/template
index a163d2099c0..d819696ecad 100644
--- a/srcpkgs/socat/template
+++ b/srcpkgs/socat/template
@@ -4,7 +4,7 @@ version=1.7.3.4
revision=2
build_style=gnu-configure
configure_args="--disable-libwrap --enable-fips
- ac_cv_have_z_modifier=yes"
+ $(vopt_if opensslmethod --enable-openssl-method) ac_cv_have_z_modifier=yes"
makedepends="readline-devel libressl-devel"
short_desc="Relay for bidirectional data transfer between two independent channels"
maintainer="q66 <daniel@octaforge.org>"
@@ -13,6 +13,9 @@ homepage="http://www.dest-unreach.org/socat/"
distfiles="http://www.dest-unreach.org/socat/download/socat-${version}.tar.bz2"
checksum=972374ca86f65498e23e3259c2ee1b8f9dbeb04d12c2a78c0c9b5d1cb97dfdfc
+build_options="opensslmethod"
+desc_option_opensslmethod="Enable openssl-method"
+
case "$XBPS_TARGET_MACHINE" in
*-musl) CFLAGS="-D_LINUX_IF_ETHER_H";;
esac
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
` (6 preceding siblings ...)
2021-01-22 11:49 ` paper42
@ 2021-01-22 12:00 ` paper42
2021-01-24 16:34 ` q66
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-01-22 12:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/27620#issuecomment-765351289
Comment:
sorry for the delay, I made it an option disabled by default as suggested
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
` (7 preceding siblings ...)
2021-01-22 12:00 ` paper42
@ 2021-01-24 16:34 ` q66
2021-01-24 16:35 ` q66
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: q66 @ 2021-01-24 16:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/27620#issuecomment-766390444
Comment:
i don't really see a reason to add this
also, your option name does not follow conventions
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
` (8 preceding siblings ...)
2021-01-24 16:34 ` q66
@ 2021-01-24 16:35 ` q66
2021-01-24 17:55 ` paper42
2021-01-24 17:55 ` [PR PATCH] [Closed]: " paper42
11 siblings, 0 replies; 13+ messages in thread
From: q66 @ 2021-01-24 16:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/27620#issuecomment-766390444
Comment:
i don't really see a reason to add this (considering it's deprecated APIs, and especially considering we don't know how this will interact with the migration to openssl later)
also, your option name does not follow conventions
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
` (9 preceding siblings ...)
2021-01-24 16:35 ` q66
@ 2021-01-24 17:55 ` paper42
2021-01-24 17:55 ` [PR PATCH] [Closed]: " paper42
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-01-24 17:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/27620#issuecomment-766402801
Comment:
At second thought, I don't think other people would benefit from this.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PR PATCH] [Closed]: socat: enable openssl-method
2021-01-02 11:52 [PR PATCH] socat: enable openssl-method paper42
` (10 preceding siblings ...)
2021-01-24 17:55 ` paper42
@ 2021-01-24 17:55 ` paper42
11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2021-01-24 17:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
There's a closed pull request on the void-packages repository
socat: enable openssl-method
https://github.com/void-linux/void-packages/pull/27620
Description:
^ permalink raw reply [flat|nested] 13+ messages in thread