Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gopass: update to 1.11.0.
@ 2021-01-25 22:44 kkga
  2021-01-25 23:24 ` ericonr
  2021-01-25 23:24 ` [PR PATCH] [Closed]: " ericonr
  0 siblings, 2 replies; 15+ messages in thread
From: kkga @ 2021-01-25 22:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]

There is a new pull request by kkga against master on the void-packages repository

https://github.com/kkga/void-packages update-gopass
https://github.com/void-linux/void-packages/pull/28231

gopass: update to 1.11.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28231.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-gopass-28231.patch --]
[-- Type: text/x-diff, Size: 1134 bytes --]

From beb235969e724f6a1ec5a0b55d3d5cc9242a6e8a Mon Sep 17 00:00:00 2001
From: Gadzhi Kharkharov <me@kkga.me>
Date: Tue, 26 Jan 2021 01:44:01 +0300
Subject: [PATCH] gopass: update to 1.11.0.

---
 srcpkgs/gopass/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gopass/template b/srcpkgs/gopass/template
index 2f6f5c860fa..30477c4fcab 100644
--- a/srcpkgs/gopass/template
+++ b/srcpkgs/gopass/template
@@ -1,7 +1,7 @@
 # Template file for 'gopass'
 pkgname=gopass
-version=1.10.1
-revision=2
+version=1.11.0
+revision=1
 build_style=go
 go_import_path=github.com/gopasspw/gopass
 go_package="${go_import_path} ${go_import_path}/cmd/..."
@@ -13,7 +13,7 @@ license="MIT"
 homepage="https://www.gopass.pw/"
 changelog="https://raw.githubusercontent.com/gopasspw/gopass/master/CHANGELOG.md"
 distfiles="https://github.com/gopasspw/gopass/archive/v${version}.tar.gz"
-checksum=f4bfe03bc26701baf411795faafe774aa6025bc6050ab3ebf7e931e5ff821961
+checksum=26ac90ef60d7f08e7d9361280d6457edb90642e821edba2c5e5cb0a09ca20b08
 
 if [ "$CROSS_BUILD" ]; then
 	# Depend on system gopass to generate completions

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-25 22:44 [PR PATCH] gopass: update to 1.11.0 kkga
@ 2021-01-25 23:24 ` ericonr
  2021-01-25 23:24 ` [PR PATCH] [Closed]: " ericonr
  1 sibling, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-25 23:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28231#issuecomment-767177478

Comment:
Duplicate of #28202 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Closed]: gopass: update to 1.11.0.
  2021-01-25 22:44 [PR PATCH] gopass: update to 1.11.0 kkga
  2021-01-25 23:24 ` ericonr
@ 2021-01-25 23:24 ` ericonr
  1 sibling, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-25 23:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]

There's a closed pull request on the void-packages repository

gopass: update to 1.11.0.
https://github.com/void-linux/void-packages/pull/28231

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
                   ` (10 preceding siblings ...)
  2021-01-27 15:22 ` dshynkev
@ 2021-02-02 18:47 ` ahesford
  11 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2021-02-02 18:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-771884062

Comment:
https://github.com/gopasspw/gopass/commit/2b2c605b584cbfa6d56167f4b492c0db7698b4ac

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
                   ` (9 preceding siblings ...)
  2021-01-27 15:08 ` ahesford
@ 2021-01-27 15:22 ` dshynkev
  2021-02-02 18:47 ` ahesford
  11 siblings, 0 replies; 15+ messages in thread
From: dshynkev @ 2021-01-27 15:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by dshynkev on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-768359685

Comment:
Thanks for reporting it to them!

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
                   ` (8 preceding siblings ...)
  2021-01-27 15:08 ` ahesford
@ 2021-01-27 15:08 ` ahesford
  2021-01-27 15:22 ` dshynkev
  2021-02-02 18:47 ` ahesford
  11 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2021-01-27 15:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-768349447

Comment:
FYI, upstream is considering [properly looking for the `gpg2` binary](https://github.com/gopasspw/gopass/pull/1758). Might want to keep an eye on that PR and, if it's accepted, backport the patch for this release if they don't cut a new release.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
                   ` (7 preceding siblings ...)
  2021-01-25 13:29 ` ericonr
@ 2021-01-27 15:08 ` ahesford
  2021-01-27 15:08 ` ahesford
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2021-01-27 15:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-768349447

Comment:
FYI, upstream is looking at a [properly looking for the `gpg2` binary](https://github.com/gopasspw/gopass/pull/1758). Might want to keep an eye on that PR and, if it's accepted, backport the patch for this release if they don't cut a new release.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
                   ` (6 preceding siblings ...)
  2021-01-25 12:54 ` ahesford
@ 2021-01-25 13:29 ` ericonr
  2021-01-27 15:08 ` ahesford
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-25 13:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-766816635

Comment:
@dshynkev see https://github.com/void-linux/void-packages/pull/28217 :)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
                   ` (5 preceding siblings ...)
  2021-01-25  1:33 ` ericonr
@ 2021-01-25 12:54 ` ahesford
  2021-01-25 13:29 ` ericonr
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2021-01-25 12:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-766795720

Comment:
Upstream is doing this wrong. GPG2 provides `gpgconf` to provide a machine-readable way to discover the path to the gpg binary. If `gpgconf` is available, you query that for the full path to the `gpg` executable, which in Void returns `/usr/bin/gpg2`. If `gpgconf` is not available, then you fall back to looking for `gpg` in the path.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
                   ` (4 preceding siblings ...)
  2021-01-25  0:27 ` dshynkev
@ 2021-01-25  1:33 ` ericonr
  2021-01-25 12:54 ` ahesford
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-25  1:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-766484822

Comment:
> It might take a while to phase out v1 if at least one of its revdeps really requires it.

Fair enough :)

Ideally, we want to make the package with as little friction as possible. If Void still defaulting to gnupg 1 makes it an issue (assuming most users do actually use gnupg2 instead), we can consider patching, IMO. I'm tagging @fnogcps so they can leave their thoughts here.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
                   ` (3 preceding siblings ...)
  2021-01-25  0:27 ` dshynkev
@ 2021-01-25  0:27 ` dshynkev
  2021-01-25  1:33 ` ericonr
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 15+ messages in thread
From: dshynkev @ 2021-01-25  0:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by dshynkev on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-766469265

Comment:
I've tentatively added a message.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
                   ` (2 preceding siblings ...)
  2021-01-24 23:02 ` ericonr
@ 2021-01-25  0:27 ` dshynkev
  2021-01-25  0:27 ` dshynkev
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 15+ messages in thread
From: dshynkev @ 2021-01-25  0:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

New comment by dshynkev on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-766469183

Comment:
It should be possible. A few of current gnupg revdeps definitely support gnupg2.

I'll file an RFC, but perhaps for now a post-install message is best?
It might take a while to phase out v1 if at least one of its revdeps really requires it.

I could also patch gopass if that's more appropriate. Sorry, not sure about the Void packaging etiquette.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
  2021-01-24 21:59 ` dshynkev
  2021-01-24 22:00 ` dshynkev
@ 2021-01-24 23:02 ` ericonr
  2021-01-25  0:27 ` dshynkev
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-01-24 23:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-766455350

Comment:
I'd use `/usr/bin/gpg2` directly instead of which.

You could also open an RFC for dropping old GPG, if you think it's feasible.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
  2021-01-24 21:59 ` dshynkev
@ 2021-01-24 22:00 ` dshynkev
  2021-01-24 23:02 ` ericonr
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 15+ messages in thread
From: dshynkev @ 2021-01-24 22:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

New comment by dshynkev on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-766439616

Comment:
One thing of note: this version changed the way the `gpg` binary is selected. They assume `gpg` points to the version of GPG the user uses, but on Void it points to GPG v1, which is probably not what most use.

One must `export GOPASS_GPG_BINARY=$(which gpg2)` for it to keep working with GPG v2.

Should I note this in a post-install message?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: gopass: update to 1.11.0.
  2021-01-24 21:55 [PR PATCH] " dshynkev
@ 2021-01-24 21:59 ` dshynkev
  2021-01-24 22:00 ` dshynkev
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 15+ messages in thread
From: dshynkev @ 2021-01-24 21:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

New comment by dshynkev on void-packages repository

https://github.com/void-linux/void-packages/pull/28202#issuecomment-766439616

Comment:
One thing of note: this version changed the way the `gpg` binary is selected. They assume `gpg` points to the version of GPG the user uses, but on Void it points to GPG v1, which is probably not what most use.

One must `export GOPASS_GPG_BINARY=$(which gpg)` for it to keep working.

Should I note this in a post-install message?

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2021-02-02 18:47 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 22:44 [PR PATCH] gopass: update to 1.11.0 kkga
2021-01-25 23:24 ` ericonr
2021-01-25 23:24 ` [PR PATCH] [Closed]: " ericonr
  -- strict thread matches above, loose matches on Subject: below --
2021-01-24 21:55 [PR PATCH] " dshynkev
2021-01-24 21:59 ` dshynkev
2021-01-24 22:00 ` dshynkev
2021-01-24 23:02 ` ericonr
2021-01-25  0:27 ` dshynkev
2021-01-25  0:27 ` dshynkev
2021-01-25  1:33 ` ericonr
2021-01-25 12:54 ` ahesford
2021-01-25 13:29 ` ericonr
2021-01-27 15:08 ` ahesford
2021-01-27 15:08 ` ahesford
2021-01-27 15:22 ` dshynkev
2021-02-02 18:47 ` ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).